Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

KIM Integration - Purpose default configurable per landscape #1234

Merged
merged 2 commits into from
Oct 2, 2024
Merged

KIM Integration - Purpose default configurable per landscape #1234

merged 2 commits into from
Oct 2, 2024

Conversation

jaroslaw-pieszka
Copy link
Contributor

Description

Changes proposed in this pull request:

  • Freemium and Trial plans set default to evaluation regardless of landscape
  • Remaining plans use configurable setting per landscape as default

Related issue(s)

#905

@jaroslaw-pieszka jaroslaw-pieszka requested a review from a team as a code owner October 1, 2024 13:06
@jaroslaw-pieszka jaroslaw-pieszka self-assigned this Oct 1, 2024
@jaroslaw-pieszka jaroslaw-pieszka added the kind/enhancement Categorizes issue or PR as related to modifying or improving an existing feature label Oct 1, 2024
@kyma-bot kyma-bot added the cla: yes Indicates the PR's author has signed the CLA. label Oct 1, 2024
@kyma-gopher-bot kyma-gopher-bot enabled auto-merge (squash) October 1, 2024 13:06
@kyma-bot kyma-bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Oct 1, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Oct 1, 2024

Add one of following labels

- kind/feature -> Use it when you want to submit a new feature

- kind/enhancement -> Use it when you modify or improve an existing feature

- kind/bug -> Use it when you fix a bug

@kyma-bot kyma-bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Oct 1, 2024
ralikio
ralikio previously approved these changes Oct 2, 2024
View reviewed changes
@kyma-bot kyma-bot added the lgtm Looks good to me! label Oct 2, 2024
@kyma-bot kyma-bot removed the lgtm Looks good to me! label Oct 2, 2024
@jaroslaw-pieszka
purpose default per landscape
ef00a9f 
TODOs removed

azure tests corrected

step test cases corrected

go imports
@kyma-bot kyma-bot added the lgtm Looks good to me! label Oct 2, 2024
@kyma-gopher-bot kyma-gopher-bot merged commit a3c60ce into kyma-project:main Oct 2, 2024
24 of 25 checks passed
@jaroslaw-pieszka jaroslaw-pieszka deleted the purpose-done-properly branch October 2, 2024 11:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ralikio ralikio ralikio approved these changes

Assignees

@jaroslaw-pieszka jaroslaw-pieszka

@ralikio ralikio

Labels
cla: yes Indicates the PR's author has signed the CLA. kind/enhancement Categorizes issue or PR as related to modifying or improving an existing feature lgtm Looks good to me! size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@jaroslaw-pieszka @ralikio @kyma-bot @kyma-gopher-bot