Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

KIM Integration - safe checks and test cases #1232

Merged
merged 5 commits into from
Oct 2, 2024
Merged

KIM Integration - safe checks and test cases #1232

merged 5 commits into from
Oct 2, 2024

Conversation

jaroslaw-pieszka
Copy link
Contributor

Description

Changes proposed in this pull request:

  • Fixed zones handling for sap-converged-cloud
  • More tests cases for sap-converged-cloud
  • Missing tests for gcp plans

Related issue(s)

#905

@jaroslaw-pieszka
sap cc default test case added
95f7110 
corrected logic for zones

panic en route

still panic but simpler code

TODOs added

tests for GCP
@jaroslaw-pieszka
safe checks for AWS
ca101a5
@jaroslaw-pieszka jaroslaw-pieszka requested a review from a team as a code owner October 1, 2024 11:17
@jaroslaw-pieszka jaroslaw-pieszka self-assigned this Oct 1, 2024
@jaroslaw-pieszka jaroslaw-pieszka added the kind/enhancement Categorizes issue or PR as related to modifying or improving an existing feature label Oct 1, 2024
@kyma-bot kyma-bot added the cla: yes Indicates the PR's author has signed the CLA. label Oct 1, 2024
@kyma-gopher-bot kyma-gopher-bot enabled auto-merge (squash) October 1, 2024 11:17
@github-actions GitHub Actions
Copy link

github-actions bot commented Oct 1, 2024

Add one of following labels

- kind/feature -> Use it when you want to submit a new feature

- kind/enhancement -> Use it when you modify or improve an existing feature

- kind/bug -> Use it when you fix a bug

@kyma-bot kyma-bot added the size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. label Oct 1, 2024
@ukff ukff self-requested a review October 2, 2024 08:19
@kyma-bot kyma-bot added the lgtm Looks good to me! label Oct 2, 2024
@kyma-gopher-bot kyma-gopher-bot merged commit e8fb56d into kyma-project:main Oct 2, 2024
24 of 25 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ukff ukff ukff approved these changes

Assignees

@jaroslaw-pieszka jaroslaw-pieszka

@ukff ukff

Labels
cla: yes Indicates the PR's author has signed the CLA. kind/enhancement Categorizes issue or PR as related to modifying or improving an existing feature lgtm Looks good to me! size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@jaroslaw-pieszka @ukff @kyma-bot @kyma-gopher-bot