Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

KIM Integration - setting default values - fix #1178

Merged

Conversation

jaroslaw-pieszka
Copy link
Contributor

Description

Changes proposed in this pull request:

  • not using generic function, more verbose but proper way

Related issue(s)

#905

@jaroslaw-pieszka jaroslaw-pieszka added the kind/enhancement Categorizes issue or PR as related to modifying or improving an existing feature label Sep 23, 2024
@jaroslaw-pieszka jaroslaw-pieszka self-assigned this Sep 23, 2024
@jaroslaw-pieszka jaroslaw-pieszka requested a review from a team as a code owner September 23, 2024 16:29
@kyma-bot kyma-bot added the cla: yes Indicates the PR's author has signed the CLA. label Sep 23, 2024
Copy link

Add one of following labels

- kind/feature -> Use it when you want to submit a new feature

- kind/enhancement -> Use it when you modify or improve an existing feature

- kind/bug -> Use it when you fix a bug

@kyma-bot kyma-bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Sep 23, 2024
@kyma-bot kyma-bot added the lgtm Looks good to me! label Sep 23, 2024
@kyma-bot kyma-bot merged commit fb15201 into kyma-project:main Sep 23, 2024
25 checks passed
ukff pushed a commit to ukff/kyma-environment-broker that referenced this pull request Sep 25, 2024
* reverting correct way of setting defaults

* reverting correct way of setting defaults

* more test cases
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes Indicates the PR's author has signed the CLA. kind/enhancement Categorizes issue or PR as related to modifying or improving an existing feature lgtm Looks good to me! size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants