Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

KIM integration - Preview plan and tests #947

Merged
merged 1 commit into from
Jul 25, 2024
Merged

KIM integration - Preview plan and tests #947

merged 1 commit into from
Jul 25, 2024

Conversation

jaroslaw-pieszka
Copy link
Contributor

@jaroslaw-pieszka jaroslaw-pieszka commented Jul 24, 2024 •
edited
Loading

Description

Changes proposed in this pull request:

  • Preview plan supported
  • Basic tests for AWS, GCP, Azure and Preview

Related issue(s)

#905

@jaroslaw-pieszka jaroslaw-pieszka added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. kind/enhancement Categorizes issue or PR as related to modifying or improving an existing feature labels Jul 24, 2024
@jaroslaw-pieszka jaroslaw-pieszka self-assigned this Jul 24, 2024
@jaroslaw-pieszka jaroslaw-pieszka requested a review from a team as a code owner July 24, 2024 13:20
@kyma-bot kyma-bot added cla: yes Indicates the PR's author has signed the CLA. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. labels Jul 24, 2024
@github-actions GitHub Actions
Copy link

Add one of following labels

- kind/feature -> Use it when you want to submit a new feature

- kind/enhancement -> Use it when you modify or improve an existing feature

- kind/bug -> Use it when you fix a bug

@kyma-bot kyma-bot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Jul 24, 2024
@jaroslaw-pieszka
fixure refactoring
0772461 
follow-up

two yaml cases for azure

two assertions for azure - actual creation

assert on region

assert on region

AWS tests failing on real creation - assertions

AWS tests passing on real creation

test for preview - basic

one more TODO

go imports

tests refactor

gcp yaml only tests

gcp complete

defaults infix added to test functions names

Purpose set
szwedm
szwedm approved these changes Jul 25, 2024
View reviewed changes
Copy link
Contributor

@szwedm szwedm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@kyma-bot kyma-bot added the lgtm Looks good to me! label Jul 25, 2024
@kyma-bot kyma-bot merged commit 97d748f into kyma-project:main Jul 25, 2024
24 checks passed
@jaroslaw-pieszka jaroslaw-pieszka deleted the preview-plan branch July 25, 2024 14:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@szwedm szwedm szwedm approved these changes

Assignees

@jaroslaw-pieszka jaroslaw-pieszka

@szwedm szwedm

Labels
cla: yes Indicates the PR's author has signed the CLA. kind/enhancement Categorizes issue or PR as related to modifying or improving an existing feature lgtm Looks good to me! size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jaroslaw-pieszka @szwedm @kyma-bot