Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

KIM integration - skip volume type and size for SAP converged cloud plan #1143

Merged

Conversation

jaroslaw-pieszka
Copy link
Contributor

Description

SAP converged cloud does not support volume.size and volume.type settings.

Changes proposed in this pull request:

  • for sap-converged-cloud plan disk type and size are not set.

Related issue(s)

#905

@jaroslaw-pieszka jaroslaw-pieszka requested a review from a team as a code owner September 16, 2024 11:22
@jaroslaw-pieszka jaroslaw-pieszka self-assigned this Sep 16, 2024
@kyma-bot kyma-bot added cla: yes Indicates the PR's author has signed the CLA. labels Sep 16, 2024
@jaroslaw-pieszka jaroslaw-pieszka added the kind/enhancement Categorizes issue or PR as related to modifying or improving an existing feature label Sep 16, 2024
Copy link

Add one of following labels

- kind/feature -> Use it when you want to submit a new feature

- kind/enhancement -> Use it when you modify or improve an existing feature

- kind/bug -> Use it when you fix a bug

@kyma-bot kyma-bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Sep 16, 2024
@jaroslaw-pieszka jaroslaw-pieszka changed the title KIM integrations - skip volume type and size for SAP converged cloud plan KIM integration - skip volume type and size for SAP converged cloud plan Sep 16, 2024
@kyma-bot kyma-bot added the lgtm Looks good to me! label Sep 16, 2024
@MarekMichali MarekMichali merged commit d19fd31 into kyma-project:main Sep 16, 2024
41 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes Indicates the PR's author has signed the CLA. kind/enhancement Categorizes issue or PR as related to modifying or improving an existing feature lgtm Looks good to me! size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants