Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

KIM Integration - GCP Trial plan #942

Merged
merged 4 commits into from
Jul 24, 2024
Merged

KIM Integration - GCP Trial plan #942

merged 4 commits into from
Jul 24, 2024

Conversation

jaroslaw-pieszka
Copy link
Contributor

@jaroslaw-pieszka jaroslaw-pieszka commented Jul 22, 2024 •
edited
Loading

Description

Changes proposed in this pull request:

  • Shoot data for GCP Trial

Related issue(s)

#905

@jaroslaw-pieszka jaroslaw-pieszka requested a review from a team as a code owner July 22, 2024 11:18
@kyma-bot kyma-bot added cla: yes Indicates the PR's author has signed the CLA. labels Jul 22, 2024
@jaroslaw-pieszka jaroslaw-pieszka self-assigned this Jul 22, 2024
@github-actions GitHub Actions
Copy link

Add one of following labels

- kind/feature -> Use it when you want to submit a new feature

- kind/enhancement -> Use it when you modify or improve an existing feature

- kind/bug -> Use it when you fix a bug

@jaroslaw-pieszka jaroslaw-pieszka added the kind/enhancement Categorizes issue or PR as related to modifying or improving an existing feature label Jul 22, 2024
@kyma-bot kyma-bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Jul 22, 2024
@ralikio
Copy link
Member

ralikio commented Jul 24, 2024

Refers to #905

ralikio
ralikio approved these changes Jul 24, 2024
View reviewed changes
Copy link
Member

@ralikio ralikio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add tests for internal/provider/gcp.go in #905

@kyma-bot kyma-bot added the lgtm Looks good to me! label Jul 24, 2024
@ralikio ralikio mentioned this pull request Jul 24, 2024
Closed
3 tasks
@kyma-bot kyma-bot merged commit 517b7ee into kyma-project:main Jul 24, 2024
22 of 24 checks passed
@jaroslaw-pieszka jaroslaw-pieszka deleted the remaining-trial-plans branch August 7, 2024 07:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ralikio ralikio ralikio approved these changes

Assignees

@jaroslaw-pieszka jaroslaw-pieszka

@ralikio ralikio

Labels
cla: yes Indicates the PR's author has signed the CLA. kind/enhancement Categorizes issue or PR as related to modifying or improving an existing feature lgtm Looks good to me! size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jaroslaw-pieszka @ralikio @kyma-bot