Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

KIM Integration - Skipping Get_Kubeconfig step for KIM driven plans #1053

Merged
merged 3 commits into from
Aug 22, 2024
Merged

KIM Integration - Skipping Get_Kubeconfig step for KIM driven plans #1053

merged 3 commits into from
Aug 22, 2024

Conversation

jaroslaw-pieszka
Copy link
Contributor

Description

Changes proposed in this pull request:

  • Skip if plan is driven by KIM only, then kubeconfig is created by KIM and used by LCM, in Get_Kubeconfig we call provisioner to get kubeconfig from RuntimeStatus.

Related issue(s)

#791
#905

@jaroslaw-pieszka jaroslaw-pieszka requested a review from a team as a code owner August 22, 2024 11:32
@jaroslaw-pieszka jaroslaw-pieszka self-assigned this Aug 22, 2024
@kyma-bot kyma-bot added the cla: yes Indicates the PR's author has signed the CLA. label Aug 22, 2024
@jaroslaw-pieszka jaroslaw-pieszka added kind/enhancement Categorizes issue or PR as related to modifying or improving an existing feature and removed cla: yes Indicates the PR's author has signed the CLA. labels Aug 22, 2024
@github-actions GitHub Actions
Copy link

Add one of following labels

- kind/feature -> Use it when you want to submit a new feature

- kind/enhancement -> Use it when you modify or improve an existing feature

- kind/bug -> Use it when you fix a bug

@kyma-bot kyma-bot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. cla: yes Indicates the PR's author has signed the CLA. labels Aug 22, 2024
@kyma-bot kyma-bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Aug 22, 2024
@kyma-bot kyma-bot added the lgtm Looks good to me! label Aug 22, 2024
@jaroslaw-pieszka jaroslaw-pieszka merged commit a6a27b2 into kyma-project:main Aug 22, 2024
27 checks passed
@jaroslaw-pieszka jaroslaw-pieszka deleted the kubeconfig-in-kim-path branch August 22, 2024 12:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@KsaweryZietara KsaweryZietara KsaweryZietara approved these changes

Assignees

@jaroslaw-pieszka jaroslaw-pieszka

@KsaweryZietara KsaweryZietara

Labels
cla: yes Indicates the PR's author has signed the CLA. kind/enhancement Categorizes issue or PR as related to modifying or improving an existing feature lgtm Looks good to me! size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jaroslaw-pieszka @KsaweryZietara @kyma-bot