KIM Integration - shoot name and networking for basic plans #951
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Add one of following labels |
kyma-bot
added
the
size/XS
jaroslaw-pieszka
added
do-not-merge/work-in-progress
kyma-bot
added
size/XS
simple logic for failure tolerance, to be validated TODO added failure tolerance set assertion for tolerance networking set asserting Networking
jaroslaw-pieszka
force-pushed
the
networking-for-basic-plans
branch
from
2c11fd8 to
7698d6b
Compare
kyma-bot
added
size/L
ralikio
reviewed
Jul 26, 2024
|
|
||
| var failureTolerance *gardener.HighAvailability | ||
| if s.config.ControlPlaneFailureTolerance == string(gardener.FailureToleranceTypeZone) { | ||
| failureTolerance = &gardener.HighAvailability{ |
There was a problem hiding this comment.
Can we shorten this method and only set "Type" field in the if block?
There was a problem hiding this comment.
Which form is easier to read is highly subjective.
There was a problem hiding this comment.
In the next commit
| } | ||
|
|
||
| return imv1.Networking{ | ||
| Pods: DefaultIfParamNotSet(networking.DefaultPodsCIDR, networkingParams.PodsCidr), |
There was a problem hiding this comment.
I don't get you question.
ralikio
reviewed
Jul 26, 2024
|
|
||
| failureType := gardener.FailureToleranceTypeZone | ||
| if s.config.ControlPlaneFailureTolerance != string(gardener.FailureToleranceTypeZone) { | ||
| failureType = gardener.FailureToleranceTypeNode |
There was a problem hiding this comment.
Can we change name to toleranceType?
ralikio
approved these changes
Jul 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Changes proposed in this pull request:
Related issue(s)
#905