Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

KIM Integration - deprovisioning does not call provisioner if Runtime CR controlled by KIM #1148

Merged
merged 3 commits into from
Sep 18, 2024
Merged

KIM Integration - deprovisioning does not call provisioner if Runtime CR controlled by KIM #1148

merged 3 commits into from
Sep 18, 2024

Conversation

jaroslaw-pieszka
Copy link
Contributor

@jaroslaw-pieszka jaroslaw-pieszka commented Sep 17, 2024 •
edited
Loading

Description

Changes proposed in this pull request:

  • Calling provisioner if Runtime CR exists and is controlled by provisioner

Related issue(s)

#905
#1147

@jaroslaw-pieszka jaroslaw-pieszka requested a review from a team as a code owner September 17, 2024 10:05
@jaroslaw-pieszka jaroslaw-pieszka self-assigned this Sep 17, 2024
@jaroslaw-pieszka jaroslaw-pieszka added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Sep 17, 2024
@kyma-bot kyma-bot added the cla: yes Indicates the PR's author has signed the CLA. label Sep 17, 2024
@github-actions GitHub Actions
Copy link

Add one of following labels

- kind/feature -> Use it when you want to submit a new feature

- kind/enhancement -> Use it when you modify or improve an existing feature

- kind/bug -> Use it when you fix a bug

@jaroslaw-pieszka jaroslaw-pieszka added the kind/enhancement Categorizes issue or PR as related to modifying or improving an existing feature label Sep 17, 2024
@kyma-bot kyma-bot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Sep 17, 2024
@jaroslaw-pieszka jaroslaw-pieszka added do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. and removed do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. labels Sep 17, 2024
@jaroslaw-pieszka
simplifing label handling and reshuffle steps
750bb86 
logic but doubts remain

tests finished

field added to model, remove runtime uses field from operations

Test done
@jaroslaw-pieszka jaroslaw-pieszka force-pushed the do-not-call-provisioner-if-kim-driven-runtime branch from c13a4f0 to 750bb86 Compare September 17, 2024 14:43
@jaroslaw-pieszka jaroslaw-pieszka added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. and removed do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. labels Sep 17, 2024
@kyma-bot kyma-bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Sep 17, 2024
@kyma-bot kyma-bot added the lgtm Looks good to me! label Sep 18, 2024
@kyma-bot kyma-bot removed the lgtm Looks good to me! label Sep 18, 2024
@kyma-bot kyma-bot added the lgtm Looks good to me! label Sep 18, 2024
@kyma-bot kyma-bot merged commit baa652b into kyma-project:main Sep 18, 2024
25 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@piotrmiskiewicz piotrmiskiewicz piotrmiskiewicz approved these changes

Assignees

@piotrmiskiewicz piotrmiskiewicz

@jaroslaw-pieszka jaroslaw-pieszka

Labels
cla: yes Indicates the PR's author has signed the CLA. kind/enhancement Categorizes issue or PR as related to modifying or improving an existing feature lgtm Looks good to me! size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jaroslaw-pieszka @piotrmiskiewicz @kyma-bot