Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update L1Scouting Data Format tests and minor code fixes #43984

Merged
merged 3 commits into from
Feb 23, 2024
Merged

Update L1Scouting Data Format tests and minor code fixes #43984

merged 3 commits into from
Feb 23, 2024

Conversation

Mmiglio
Copy link
Contributor

@Mmiglio Mmiglio commented Feb 15, 2024

PR description:

The aim of this PR is to add test files to DataFormats/L1Scouting and DataFormats/L1ScoutingRawData, as requested in #43467 (comment). Test files have been added to cms-data in these two PRs:

Additionally, I've taken the opportunity to introduce minor changes in other modules, most notably:

  • Using an approximate value for the phi LSB of caloL2 trigger objects to match the current usage by caloL2 trigger emulator.
  • New set of ScoutingDataSourceIDs for TCP/IP-based readout of calo primitives. Calo Unpacker will be reformated in a future PR.
  • Fixing a bug in OrbitCollection data format

PR validation:

Validated files produced with this new version files against a set of reference data.

Update L1 scouting data format test scripts
9574458 
* Add test files to L1 Scouting data format
* Reordered in alphabetical order DataFormats/L1Scouting/src/classes_def.xml
* fixed minor bug in OrbitCollection
* Correct Calo phiLSB conversion to reflect the approximation currently being used by caloL2Trigger
* Added new ScoutinngDataSource IDs for the calo scouting TCP-based DAQ.
@cmsbuild cmsbuild added this to the CMSSW_14_1_X milestone Feb 15, 2024
@cmsbuild
Copy link
Contributor

cmsbuild commented Feb 15, 2024 •
edited
Loading

cms-bot internal usage

@cmsbuild
Copy link
Contributor

-code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-43984/38899

  • This PR adds an extra 24KB to repository

Code check has found code style and quality issues which could be resolved by applying following patch(s)

@cmsbuild
Copy link
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-43984/38901

  • This PR adds an extra 24KB to repository

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @Mmiglio (Matteo Migliorini) for master.

It involves the following packages:

  • DataFormats/L1Scouting (daq)
  • DataFormats/L1ScoutingRawData (daq)
  • EventFilter/L1ScoutingRawToDigi (daq)
  • EventFilter/Utilities (daq)
  • L1TriggerScouting/Utilities (daq)

@emeschi, @smorovic, @cmsbuild can you please review it and eventually sign? Thanks.
@missirol, @Martin-Grunewald, @rovere this is something you requested to watch as well.
@antoniovilela, @rappoccio, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

@smorovic
Copy link
Contributor

please test with cms-data/DataFormats-L1Scouting#2 and cms-data/DataFormats-L1ScoutingRawData#2

@smorovic
Copy link
Contributor

@cmsbuild please test with cms-data/DataFormats-L1Scouting#2 and cms-data/DataFormats-L1ScoutingRawData#2

@smorovic
Copy link
Contributor

@cmsbuild please test with cms-data/DataFormats-L1Scouting#2

@smorovic
Copy link
Contributor

@cmsbuild abort tests

@smorovic
Copy link
Contributor

@cmsbuild abort test

@smorovic
Copy link
Contributor

@cmsbuild please test with cms-data/DataFormats-L1Scouting#2 cms-data/DataFormats-L1ScoutingRawData#2

@smorovic
Copy link
Contributor

@cmsbuild please test with cms-data/DataFormats-L1Scouting#2 , cms-data/DataFormats-L1ScoutingRawData#2

@cmsbuild
Copy link
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-43984/38989

  • This PR adds an extra 16KB to repository

@cmsbuild
Copy link
Contributor

Pull request #43984 was updated. @emeschi, @cmsbuild, @smorovic can you please check and sign again.

@smorovic
Copy link
Contributor

@cmsbuild please test with cms-data/DataFormats-L1Scouting#2 , cms-data/DataFormats-L1ScoutingRawData#2

@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-3b73c2/37612/summary.html
COMMIT: 122acb5
CMSSW: CMSSW_14_1_X_2024-02-21-1100/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/43984/37612/install.sh to create a dev area with all the needed externals and cmssw changes.

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:

You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-3b73c2/37612/git-recent-commits.json
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-3b73c2/37612/git-merge-result

Comparison Summary

Summary:

  • You potentially added 211 lines to the logs
  • ROOTFileChecks: Some differences in event products or their sizes found
  • Reco comparison results: 69 differences found in the comparisons
  • DQMHistoTests: Total files compared: 48
  • DQMHistoTests: Total histograms compared: 3245310
  • DQMHistoTests: Total failures: 9722
  • DQMHistoTests: Total nulls: 55
  • DQMHistoTests: Total successes: 3235511
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: -3775.9739999999997 KiB( 47 files compared)
  • DQMHistoSizes: changed ( 141.042,... ): -738.156 KiB HLT/TOP
  • DQMHistoSizes: changed ( 141.042,... ): -308.779 KiB HLT/SUSY
  • DQMHistoSizes: changed ( 141.042,... ): -145.439 KiB HLT/JME
  • DQMHistoSizes: changed ( 141.042,... ): -60.436 KiB HLT/Filters
  • DQMHistoSizes: changed ( 141.042,... ): -7.955 KiB HLT/TAU
  • DQMHistoSizes: changed ( 23234.0,... ): 1.054 KiB MTD/Tracks
  • Checked 200 log files, 161 edm output root files, 48 DQM output files
  • TriggerResults: found differences in 3 / 46 workflows

@smorovic
Copy link
Contributor

+daq

@cmsbuild cmsbuild mentioned this pull request Feb 22, 2024
Merged
@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @sextonkennedy, @rappoccio, @antoniovilela (and backports should be raised in the release meeting by the corresponding L2)
Notice This PR was tested with additional Pull Request(s), please also merge them if necessary: cms-data/DataFormats-L1Scouting#2, cms-data/DataFormats-L1ScoutingRawData#2

@cmsbuild cmsbuild mentioned this pull request Feb 22, 2024
Merged
@rappoccio
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit 58c4cd7 into cms-sw:master Feb 23, 2024
11 checks passed
This was referenced Feb 23, 2024
Merged
Merged
Merged
@Mmiglio Mmiglio mentioned this pull request Mar 13, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
code-checks-approved daq-approved fully-signed orp-approved requires-external tests-approved
Projects
None yet
Milestone
CMSSW_14_1_X
Development

Successfully merging this pull request may close these issues.
4 participants
@Mmiglio @cmsbuild @smorovic @rappoccio