Lepton time-life info for NanoAOD #43525

mbluj · 2023-12-08T11:53:52Z

PR description:

This PR adds a customization to add lepton time-life related information to NanoAOD. The information contains:

(refitted) secondary vertex for 3-prong taus (with covariance matrix),
impact parameter vector (with significance) of the electron, muon and tau tracks wrt PV fitted with beam-spot constraint,
parameters of electron, muon and tau tracks (with covariance matrix),
primary vertex with beam-spot constraint (position and covariance matrix).

All those variables are used in the measurement of CP structure of the Higgs-tau Yukawa coupling and related analyses, e.g. measurement of polarization of Z in decays to taus.

Technically all lepton time-life variables are stored in a newly introduced data-format TrackTimeLifeInfo produced by a new producer PATLeptonTimeLifeInfoProducer (a template class instantiated for pat::Electron, pat::Muon and pat::Tau) and then added by an instance of simple table producer. The PV with BS information is stored with a new instance (for reco::Vertex) of a simple table producer.
In the case of Run-2 input samples the PV with the BS constraint is produced with a custom producer (PATRefitVertexProducer) with miniAOD inputs (a new reco::Vertex collection with one item) as vertices with BS are not available in those samples.

In case a given new variable is not computed, e.g. SV for 1-prong taus or variables for a lepton is not passing selection, zeros are stored which are then effectively compressed in an output file.

PR validation:

Validated using 2022 and 2018 TTbar samples with customized default NanoAOD workflow obtained as follows:

cmsDriver.py --python_filename NanoAOD_lifeTimeCustom_cfg.py --eventcontent NANOAODSIM --customise_commands="process.add_(cms.Service('InitRootHandlers',EnableIMT = cms.untracked.bool(False)));process.MessageLogger.cerr.FwkReport.reportEvery=1000" --datatier NANOAODSIM --fileout file:NanoAOD_lifeTimeCustom.root --conditions auto:phase1_2018_realistic --step NANO:@LepTimeLife --filein file:some_ttbar2018file.root --era Run2_2018,run2_nanoAOD_106Xv2 --no_exec --mc -n -1

Added variables increase size of NanoAOD by ~8.5% (wrt 14_0_0_pre1 default) which is distributed between taus (~3%), electrons and muons (~2% each) and PV with BS (~1%)
In the current setup the variables are added to default workflow with LepTimeLife customization defining extended NANO step like this --step NANO:@LepTimeLife.

Presentation at the XPOG meeting: link

If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:

It is foreseen to backport to 14_0_X.

cmsbuild · 2023-12-08T12:01:26Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-43525/38107

This PR adds an extra 64KB to repository
Found files with invalid states:
- PhysicsTools/PatAlgos/plugins/PATLeptonTimeLifeInfoUpdater.cc:
  - Added: 8463711
  - Deleted: dd9dc87
There are other open Pull requests which might conflict with changes you have proposed:
- File PhysicsTools/NanoAOD/plugins/BuildFile.xml modified in PR(s): [NanoAOD,BTVNano] Btvnano integration as customized module #43485
- File PhysicsTools/NanoAOD/plugins/VertexTableProducer.cc modified in PR(s): Add PV sumPT2 of pf charged particles associated to PV in NanoAOD #43487
- File PhysicsTools/NanoAOD/python/electrons_cff.py modified in PR(s): EGamma custom nano #42607, Add HZZ electron ID for Run3 #43430
- File PhysicsTools/NanoAOD/python/vertices_cff.py modified in PR(s): Add PV sumPT2 of pf charged particles associated to PV in NanoAOD #43487

cmsbuild · 2023-12-08T12:01:54Z

A new Pull Request was created by @mbluj for master.

It involves the following packages:

DataFormats/NanoAOD (xpog)
PhysicsTools/NanoAOD (xpog)
PhysicsTools/PatAlgos (reconstruction, xpog)

@cmsbuild, @vlimant, @jfernan2, @simonepigazzini, @mandrenguyen can you please review it and eventually sign? Thanks.
@emilbols, @seemasharmafnal, @andrzejnovak, @mbluj, @jdolen, @gkasieczka, @JyothsnaKomaragiri, @schoef, @nhanvtran, @jdamgov, @hatakeyamak, @ahinzmann, @azotz, @rovere, @gpetruc, @Senphy, @gouskos, @Ming-Yan, @mmarionncern, @missirol, @mariadalfonso, @AnnikaStein, @AlexDeMoor, @rappoccio, @demuller this is something you requested to watch as well.
@sextonkennedy, @rappoccio, @antoniovilela you are the release manager for this.

cms-bot commands are listed here

vlimant · 2023-12-11T08:18:13Z

enable nano

vlimant · 2023-12-11T08:40:13Z

hell @mbluj are you able to present this at the upcoming xpog meeting (dec 13) ?

PhysicsTools/PatAlgos/plugins/MiniAODRefitVertexProducer.cc

PhysicsTools/NanoAOD/plugins/LeptonTimeLifeInfoTableProducer.cc

DataFormats/NanoAOD/interface/LeptonTimeLifeInfo.h

PhysicsTools/NanoAOD/interface/SimpleFlatTableProducer.h

PhysicsTools/NanoAOD/plugins/VertexTableProducer.cc

mbluj · 2023-12-11T10:10:07Z

hell @mbluj are you able to present this at the upcoming xpog meeting (dec 13) ?

I am participating at L1 workshop, but I can try to prepare a short presentation.

mbluj · 2023-12-13T09:18:39Z

hell @mbluj are you able to present this at the upcoming xpog meeting (dec 13) ?

I am participating at L1 workshop, but I can try to prepare a short presentation.

I prepared a couple of slides, could you, please, give me a slot in agenda of the meeting?

cmsbuild · 2023-12-22T15:43:49Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-43525/38289

This PR adds an extra 36KB to repository
Found files with invalid states:
- DataFormats/NanoAOD/src/LeptonTimeLifeInfo.cc:
  - Added: dd9dc87
  - Deleted: 5a1ba08
- DataFormats/NanoAOD/interface/LeptonTimeLifeInfo.h:
  - Added: dd9dc87
  - Deleted: 5a1ba08
- PhysicsTools/PatAlgos/plugins/PATLeptonTimeLifeInfoUpdater.cc:
  - Added: 8463711
  - Deleted: dd9dc87
There are other open Pull requests which might conflict with changes you have proposed:
- File PhysicsTools/NanoAOD/plugins/BuildFile.xml modified in PR(s): [NanoAOD,BTVNano] Btvnano integration as customized module #43485
- File PhysicsTools/NanoAOD/plugins/VertexTableProducer.cc modified in PR(s): Add PV sumPT2 of pf charged particles associated to PV in NanoAOD #43487
- File PhysicsTools/NanoAOD/python/electrons_cff.py modified in PR(s): EGamma custom nano #42607, Add HZZ electron ID for Run3 #43430
- File PhysicsTools/NanoAOD/python/muons_cff.py modified in PR(s): Soft muon MVA id for run3 #43622
- File PhysicsTools/NanoAOD/python/vertices_cff.py modified in PR(s): Add PV sumPT2 of pf charged particles associated to PV in NanoAOD #43487

cmsbuild · 2023-12-22T15:44:15Z

Pull request #43525 was updated. @cmsbuild, @hqucms, @jfernan2, @mandrenguyen, @vlimant can you please check and sign again.

mbluj · 2023-12-22T15:48:38Z

The two last commits address review comments (hopefully):

Auxillary TimeLifeInfo class moved from DataFormats/NanoAOD to DataFormats/VertexReco and renamed as suggested,
Definition of variables dumped to tables decoupled from definition of simple table producers,
Removed "heavy" use #typedef in Vertex and TimeLifeInfo table producers.

If the changes in this PR are accepted I will add newly added variables to NanoAOD DQM as this is still missing.

mbluj · 2024-01-09T09:49:04Z

@vlimant, I wonder if you have had time to review update of this PR? Do you have any further comments?

PhysicsTools/NanoAOD/plugins/VertexTableProducer.cc

PhysicsTools/NanoAOD/plugins/LeptonTimeLifeInfoTableProducer.cc

cmsbuild · 2024-02-20T16:23:56Z

Pull request #43525 was updated. @hqucms, @jfernan2, @cmsbuild, @vlimant, @mandrenguyen can you please check and sign again.

vlimant · 2024-02-20T18:13:09Z

please test

cmsbuild · 2024-02-20T22:34:05Z

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-4f2664/37588/summary.html
COMMIT: bef9e17
CMSSW: CMSSW_14_1_X_2024-02-20-1100/el8_amd64_gcc12
Additional Tests: NANO
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/43525/37588/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

You potentially removed 62 lines from the logs
Reco comparison results: 44 differences found in the comparisons
DQMHistoTests: Total files compared: 48
DQMHistoTests: Total histograms compared: 3248389
DQMHistoTests: Total failures: 3
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 3248364
DQMHistoTests: Total skipped: 22
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 0.0 KiB( 47 files compared)
Checked 200 log files, 161 edm output root files, 48 DQM output files
TriggerResults: no differences found

NANO Comparison Summary

Summary:

You potentially added 1 lines to the logs
Reco comparison results: 0 differences found in the comparisons
DQMHistoTests: Total files compared: 15
DQMHistoTests: Total histograms compared: 16430
DQMHistoTests: Total failures: 0
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 16430
DQMHistoTests: Total skipped: 0
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 0.0 KiB( 14 files compared)
Checked 38 log files, 18 edm output root files, 15 DQM output files

Nano size comparison Summary:

Sample	kb/ev	ref kb/ev	diff kb/ev	ev/s/thd	ref ev/s/thd	diff rate	mem/thd	ref mem/thd
2500.0	2.551	2.551	0.000 ( +0.0% )	5.23	5.30	-1.2%	2.237	2.221
2500.001	2.700	2.700	0.000 ( +0.0% )	4.65	4.76	-2.3%	2.686	2.652
2500.002	2.641	2.641	0.000 ( +0.0% )	4.87	4.91	-0.8%	2.676	2.655
2500.01	1.322	1.322	0.000 ( +0.0% )	9.57	9.83	-2.6%	2.366	2.291
2500.011	1.745	1.745	0.000 ( +0.0% )	5.23	5.21	+0.5%	2.547	2.468
2500.012	1.586	1.586	0.000 ( +0.0% )	7.59	7.52	+0.8%	2.466	2.430
2500.1	2.194	2.194	0.000 ( +0.0% )	5.32	5.32	-0.0%	2.087	2.070
2500.2	2.310	2.310	0.000 ( +0.0% )	6.07	6.00	+1.2%	2.000	1.983
2500.21	1.185	1.185	0.000 ( +0.0% )	4.31	4.40	-2.1%	2.294	2.260
2500.211	1.549	1.549	0.000 ( +0.0% )	3.74	3.82	-1.9%	2.382	2.340
2500.3	2.060	2.060	0.000 ( +0.0% )	12.71	12.68	+0.2%	1.988	1.966
2500.31	1.257	1.257	0.000 ( +0.0% )	20.13	20.02	+0.6%	2.381	2.357
2500.311	1.646	1.646	0.000 ( +0.0% )	12.18	12.82	-5.0%	2.461	2.409
2500.312	7.159	7.159	0.000 ( +0.0% )	1.39	1.46	-4.8%	1.703	1.690
2500.313	1.564	1.564	0.000 ( +0.0% )	6.78	6.69	+1.3%	1.056	1.042
2500.4	2.060	2.060	0.000 ( +0.0% )	12.68	12.75	-0.6%	1.985	1.967
2500.5	19.575	19.575	0.000 ( +0.0% )	1.36	1.27	+6.7%	1.372	1.354

mandrenguyen · 2024-02-21T06:31:30Z

+reconstruction

vlimant · 2024-02-21T09:35:08Z

+1

cmsbuild · 2024-02-21T09:35:33Z

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @sextonkennedy, @rappoccio, @antoniovilela (and backports should be raised in the release meeting by the corresponding L2)

vlimant · 2024-02-21T09:36:08Z

please prepare the backport PR asap

mbluj · 2024-02-21T10:41:48Z

please prepare the backport PR asap

OK. Can I backport the new typed value map table producer together with this development or two separate PR should be prepared? Or the producer is already backported?

vlimant · 2024-02-21T10:44:09Z

backport both at the same time please

mbluj · 2024-02-21T12:15:44Z

For reference: backported to 14_0_X in #44040.

rappoccio · 2024-02-21T17:28:16Z

+1

vlimant · 2024-02-22T18:39:15Z

please work on a PR with a test workflow in the nano matrix for this feature ; following the example for MUO, EGM, etc (no need to have it in backport though)

cmsbuild added this to the CMSSW_14_0_X milestone Dec 8, 2023

cmsbuild added reconstruction-pending pending-signatures tests-pending orp-pending code-checks-pending xpog-pending labels Dec 8, 2023

cmsbuild added code-checks-approved and removed code-checks-pending labels Dec 8, 2023

cmsbuild mentioned this pull request Dec 8, 2023

Add PV sumPT2 of pf charged particles associated to PV in NanoAOD #43487

Merged

vlimant suggested changes Dec 11, 2023

View reviewed changes

cmsbuild mentioned this pull request Dec 20, 2023

Soft muon MVA id for run3 #43622

Merged

cmsbuild added code-checks-pending tracking and removed code-checks-approved labels Dec 22, 2023

cmsbuild added code-checks-approved and removed code-checks-pending labels Dec 22, 2023

cmsbuild mentioned this pull request Jan 2, 2024

Clean up some unnecessary {begin,end}{Run,LuminosityBlock} transition functions #43648

Merged

vlimant reviewed Jan 10, 2024

View reviewed changes

PhysicsTools/NanoAOD/plugins/VertexTableProducer.cc Outdated Show resolved Hide resolved

vlimant reviewed Jan 10, 2024

View reviewed changes

PhysicsTools/NanoAOD/plugins/LeptonTimeLifeInfoTableProducer.cc Outdated Show resolved Hide resolved

cmsbuild added code-checks-approved and removed code-checks-pending labels Feb 20, 2024

cmsbuild added tests-started and removed tests-pending labels Feb 20, 2024

cmsbuild added tests-approved and removed tests-started labels Feb 20, 2024

cmsbuild added reconstruction-approved and removed reconstruction-pending labels Feb 21, 2024

cmsbuild added fully-signed xpog-approved and removed pending-signatures xpog-pending labels Feb 21, 2024

mbluj mentioned this pull request Feb 21, 2024

Lepton time-life info for NanoAOD and Nano branches from ValueMap of elaborated types (14_0_X) #44040

Merged

cmsbuild added orp-approved and removed orp-pending labels Feb 21, 2024

cmsbuild merged commit aeadc17 into cms-sw:master Feb 21, 2024
13 checks passed

cmsbuild mentioned this pull request Feb 22, 2024

Update L1Scouting Data Format tests and minor code fixes #43984

Merged

mbluj mentioned this pull request Feb 29, 2024

Test workflows for lepton time-life customization of NanoAOD #44263

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Lepton time-life info for NanoAOD #43525

Lepton time-life info for NanoAOD #43525

mbluj commented Dec 8, 2023 •

edited

Loading

cmsbuild commented Dec 8, 2023

cmsbuild commented Dec 8, 2023 •

edited

Loading

vlimant commented Dec 11, 2023

vlimant commented Dec 11, 2023

mbluj commented Dec 11, 2023

mbluj commented Dec 13, 2023

cmsbuild commented Dec 22, 2023

cmsbuild commented Dec 22, 2023

mbluj commented Dec 22, 2023

mbluj commented Jan 9, 2024

cmsbuild commented Feb 20, 2024

vlimant commented Feb 20, 2024

cmsbuild commented Feb 20, 2024

mandrenguyen commented Feb 21, 2024

vlimant commented Feb 21, 2024

cmsbuild commented Feb 21, 2024

vlimant commented Feb 21, 2024

mbluj commented Feb 21, 2024

vlimant commented Feb 21, 2024

mbluj commented Feb 21, 2024

rappoccio commented Feb 21, 2024

vlimant commented Feb 22, 2024

Lepton time-life info for NanoAOD #43525

Lepton time-life info for NanoAOD #43525

Conversation

mbluj commented Dec 8, 2023 • edited Loading

PR description:

PR validation:

If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:

cmsbuild commented Dec 8, 2023

cmsbuild commented Dec 8, 2023 • edited Loading

vlimant commented Dec 11, 2023

vlimant commented Dec 11, 2023

mbluj commented Dec 11, 2023

mbluj commented Dec 13, 2023

cmsbuild commented Dec 22, 2023

cmsbuild commented Dec 22, 2023

mbluj commented Dec 22, 2023

mbluj commented Jan 9, 2024

cmsbuild commented Feb 20, 2024

vlimant commented Feb 20, 2024

cmsbuild commented Feb 20, 2024

Comparison Summary

NANO Comparison Summary

mandrenguyen commented Feb 21, 2024

vlimant commented Feb 21, 2024

cmsbuild commented Feb 21, 2024

vlimant commented Feb 21, 2024

mbluj commented Feb 21, 2024

vlimant commented Feb 21, 2024

mbluj commented Feb 21, 2024

rappoccio commented Feb 21, 2024

vlimant commented Feb 22, 2024

mbluj commented Dec 8, 2023 •

edited

Loading

cmsbuild commented Dec 8, 2023 •

edited

Loading