Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[NanoAOD,BTVNano] Btvnano integration as customized module #43485

Merged
merged 18 commits into from
Apr 8, 2024

Conversation

Ming-Yan
Copy link
Contributor

@Ming-Yan Ming-Yan commented Dec 4, 2023

PR description:

  • integrate the PFNano to customized NanoAOD module according to the discussion with XPOG
  • additional PFCands, variables to derive SFs are included
  • remove btagHbb tagger in NANOAOD
  • add PNetCvsNotB for the tagger correction

time& size report doc

MC (test with /store/mc/Run3Summer22EEMiniAODv4/QCD_PT-15to20_MuEnrichedPt5_TuneCP5_13p6TeV_pythia8/MINIAODSIM/130X_mcRun3_2022_realistic_postEE_v6-v2/2520000/177762d0-23ed-436f-aa0d-a20c33e33dc3.root)
size : 5.61 kb/event
TimeReport ---------- Event Summary ---[sec]----
TimeReport event loop CPU/event = 0.072606
TimeReport event loop Real/event = 0.032194
TimeReport sum Streams Real/event = 0.096403
TimeReport efficiency CPU/Real/thread = 0.563817

data (test with /store/data/Run2022C/BTagMu/MINIAOD/22Sep2023-v1/40000/fc8f31f6-4bf7-4b51-8f6d-ef0833c1e383.root)
size : 5.91 kb/event
TimeReport ---------- Event Summary ---[sec]----
TimeReport event loop CPU/event = 0.101517
TimeReport event loop Real/event = 0.040990
TimeReport sum Streams Real/event = 0.139760
TimeReport efficiency CPU/Real/thread = 0.619164

PR validation:

  • passes the standard runTheMatrix test: runTheMatrix.py -l limited -i all --ibeos

@cmsbuild
Copy link
Contributor

cmsbuild commented Dec 4, 2023

-code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-43485/38054

  • This PR adds an extra 80KB to repository

Code check has found code style and quality issues which could be resolved by applying following patch(s)

@jfernan2
Copy link
Contributor

jfernan2 commented Dec 4, 2023

assign btv-pog

@jfernan2
Copy link
Contributor

jfernan2 commented Dec 4, 2023

assign pf

@cmsbuild
Copy link
Contributor

cmsbuild commented Dec 5, 2023

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-43485/38071

  • This PR adds an extra 80KB to repository

@cmsbuild
Copy link
Contributor

cmsbuild commented Dec 5, 2023

New categories assigned: btv-pog,pf

@bellan,@kdlong,@swagata87,@SWuchterl,@mondalspandan you have been requested to review this Pull request/Issue and eventually sign? Thanks

@cmsbuild
Copy link
Contributor

cmsbuild commented Dec 5, 2023

A new Pull Request was created by @Ming-Yan (Ming-Yan, Lee) for master.

It involves the following packages:

  • PhysicsTools/NanoAOD (xpog)
  • PhysicsTools/PatAlgos (xpog, reconstruction)
  • RecoBTag/FeatureTools (reconstruction)
  • RecoBTag/ONNXRuntime (reconstruction)

@kdlong, @SWuchterl, @mondalspandan, @swagata87, @bellan, @vlimant, @mandrenguyen, @simonepigazzini, @cmsbuild, @jfernan2 can you please review it and eventually sign? Thanks.
@andrzejnovak, @jdamgov, @missirol, @AlexDeMoor, @seemasharmafnal, @schoef, @mariadalfonso, @hqucms, @nhanvtran, @AnnikaStein, @JyothsnaKomaragiri, @mmarionncern, @gouskos, @Ming-Yan, @jdolen, @Senphy, @demuller, @azotz, @gkasieczka, @ahinzmann, @rappoccio, @emilbols, @hatakeyamak, @mbluj, @gpetruc this is something you requested to watch as well.
@sextonkennedy, @antoniovilela, @rappoccio you are the release manager for this.

cms-bot commands are listed here

@jfernan2
Copy link
Contributor

please test

@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-89d7f3/36407/summary.html
COMMIT: 736532d
CMSSW: CMSSW_14_0_X_2023-12-10-2300/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/43485/36407/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

@jfernan2
Copy link
Contributor

enable nano

@jfernan2
Copy link
Contributor

please test

@AdrianoDee
Copy link
Contributor

+pdmv

@AdrianoDee
Copy link
Contributor

My only comment here would be that maybe the title is slightly misleading with respect to the content of the PR.

@srimanob
Copy link
Contributor

srimanob commented Apr 5, 2024

+Upgrade

@jfernan2
Copy link
Contributor

jfernan2 commented Apr 5, 2024

+1

@swagata87
Copy link
Contributor

+1

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 5, 2024

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @sextonkennedy, @antoniovilela, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)

@antoniovilela
Copy link
Contributor

+1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.