-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[NanoAOD,BTVNano] Btvnano integration as customized module #43485
Conversation
-code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-43485/38054
Code check has found code style and quality issues which could be resolved by applying following patch(s)
|
assign btv-pog |
assign pf |
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-43485/38071
|
New categories assigned: btv-pog,pf @bellan,@kdlong,@swagata87,@SWuchterl,@mondalspandan you have been requested to review this Pull request/Issue and eventually sign? Thanks |
A new Pull Request was created by @Ming-Yan (Ming-Yan, Lee) for master. It involves the following packages:
@kdlong, @SWuchterl, @mondalspandan, @swagata87, @bellan, @vlimant, @mandrenguyen, @simonepigazzini, @cmsbuild, @jfernan2 can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
please test |
+1 Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-89d7f3/36407/summary.html Comparison SummarySummary:
|
enable nano |
please test |
+pdmv |
My only comment here would be that maybe the title is slightly misleading with respect to the content of the PR. |
+Upgrade |
+1 |
+1 |
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @sextonkennedy, @antoniovilela, @rappoccio (and backports should be raised in the release meeting by the corresponding L2) |
+1 |
PR description:
time& size report doc
MC (test with
/store/mc/Run3Summer22EEMiniAODv4/QCD_PT-15to20_MuEnrichedPt5_TuneCP5_13p6TeV_pythia8/MINIAODSIM/130X_mcRun3_2022_realistic_postEE_v6-v2/2520000/177762d0-23ed-436f-aa0d-a20c33e33dc3.root
)size : 5.61 kb/event
TimeReport ---------- Event Summary ---[sec]----
TimeReport event loop CPU/event = 0.072606
TimeReport event loop Real/event = 0.032194
TimeReport sum Streams Real/event = 0.096403
TimeReport efficiency CPU/Real/thread = 0.563817
data (test with
/store/data/Run2022C/BTagMu/MINIAOD/22Sep2023-v1/40000/fc8f31f6-4bf7-4b51-8f6d-ef0833c1e383.root
)size : 5.91 kb/event
TimeReport ---------- Event Summary ---[sec]----
TimeReport event loop CPU/event = 0.101517
TimeReport event loop Real/event = 0.040990
TimeReport sum Streams Real/event = 0.139760
TimeReport efficiency CPU/Real/thread = 0.619164
PR validation: