[Backport 14.0.X] backport customize BTVNano changes

[Ming-Yan]

PR description:

backport for customize btvnano #43485

PR validation:

nano matrix

If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:

backport from CMSSW_14_1_X(master) for this changes #43485

[cmsbuild]

A new Pull Request was created by @Ming-Yan for CMSSW_14_0_X.

It involves the following packages:

• Configuration/PyReleaseValidation (upgrade, pdmv)
• PhysicsTools/NanoAOD (xpog)
• PhysicsTools/PatAlgos (xpog, reconstruction)
• RecoBTag/FeatureTools (reconstruction)
• RecoBTag/ONNXRuntime (reconstruction)

@jfernan2, @sunilUIET, @hqucms, @subirsarkar, @cmsbuild, @AdrianoDee, @miquork, @srimanob, @vlimant, @mandrenguyen can you please review it and eventually sign? Thanks.
@demuller, @schoef, @jdamgov, @gkasieczka, @rappoccio, @missirol, @mbluj, @jdolen, @azotz, @andrzejnovak, @slomeo, @mariadalfonso, @gouskos, @hqucms, @fabiocos, @seemasharmafnal, @AlexDeMoor, @gpetruc, @nhanvtran, @Martin-Grunewald, @hatakeyamak, @Ming-Yan, @ahinzmann, @emilbols, @AnnikaStein, @makortel, @Senphy, @mmarionncern, @JyothsnaKomaragiri this is something you requested to watch as well.
@antoniovilela, @rappoccio, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

• Backported from [NanoAOD,BTVNano] Btvnano integration as customized module #43485

[cmsbuild]

cms-bot internal usage

[jfernan2]

assign btv-pog

[jfernan2]

assign pf

[cmsbuild]

New categories assigned: btv-pog,pf

@bellan,@kdlong,@swagata87,@SWuchterl,@mondalspandan you have been requested to review this Pull request/Issue and eventually sign? Thanks

[jfernan2]

enable nano

[jfernan2]

please test

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-d8fb1b/38614/summary.html
COMMIT: 6fb36e0
CMSSW: CMSSW_14_0_X_2024-04-04-2300/el8_amd64_gcc12
Additional Tests: NANO
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/44627/38614/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

• You potentially removed 81 lines from the logs
• ROOTFileChecks: Some differences in event products or their sizes found
• Reco comparison results: 140 differences found in the comparisons
• DQMHistoTests: Total files compared: 49
• DQMHistoTests: Total histograms compared: 3346180
• DQMHistoTests: Total failures: 1361
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3344797
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 8.045999999999998 KiB( 48 files compared)
• DQMHistoSizes: changed ( 11634.0,... ): 0.648 KiB Physics/NanoAODDQM
• DQMHistoSizes: changed ( 13234.0,... ): 0.390 KiB Physics/NanoAODDQM
• Checked 205 log files, 166 edm output root files, 49 DQM output files
• TriggerResults: no differences found

NANO Comparison Summary

Summary:

• You potentially added 1 lines to the logs
• ROOTFileChecks: Some differences in event products or their sizes found
• Reco comparison results: 0 differences found in the comparisons
• DQMHistoTests: Total files compared: 15
• DQMHistoTests: Total histograms compared: 16430
• DQMHistoTests: Total failures: 0
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 16430
• DQMHistoTests: Total skipped: 0
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 5.19 KiB( 14 files compared)
• DQMHistoSizes: changed ( 2500.001,... ): 0.648 KiB Physics/NanoAODDQM
• DQMHistoSizes: changed ( 2500.011,... ): 0.390 KiB Physics/NanoAODDQM
• Checked 47 log files, 27 edm output root files, 15 DQM output files

Nano size comparison Summary:

• Nano ERROR: Missing ref/2500.318-size.json
• Nano ERROR: Missing ref/2500.318-size.json
• Nano ERROR: Missing ref/2500.405-size.json
• Nano ERROR: Missing ref/2500.405-size.json
  | Sample | kb/ev | ref kb/ev | diff kb/ev | ev/s/thd | ref ev/s/thd | diff rate | mem/thd | ref mem/thd |
  | --- | --- | --- | --- | --- | --- | --- | --- | --- |
  | 2500.0 | 2.553 | 2.553 | 0.000 ( +0.0% ) | 5.24 | 5.18 | +1.1% | 2.230 | 2.176 |
  | 2500.001 | 2.703 | 2.703 | 0.000 ( +0.0% ) | 4.68 | 4.65 | +0.7% | 2.657 | 2.591 |
  | 2500.002 | 2.643 | 2.643 | 0.000 ( +0.0% ) | 4.88 | 4.83 | +1.0% | 2.645 | 2.571 |
  | 2500.01 | 1.318 | 1.318 | 0.000 ( +0.0% ) | 9.66 | 9.49 | +1.9% | 2.359 | 2.275 |
  | 2500.011 | 1.740 | 1.740 | 0.000 ( +0.0% ) | 5.21 | 5.22 | -0.2% | 2.529 | 2.454 |
  | 2500.012 | 1.581 | 1.581 | 0.000 ( +0.0% ) | 7.51 | 7.27 | +3.4% | 2.375 | 2.352 |
  | 2500.1 | 2.197 | 2.196 | 0.001 ( +0.0% ) | 5.27 | 5.21 | +1.1% | 2.070 | 1.997 |
  | 2500.2 | 2.314 | 2.313 | 0.001 ( +0.1% ) | 6.03 | 5.90 | +2.2% | 1.988 | 1.897 |
  | 2500.21 | 1.182 | 1.181 | 0.001 ( +0.1% ) | 4.28 | 4.25 | +0.7% | 2.267 | 2.210 |
  | 2500.211 | 1.546 | 1.545 | 0.001 ( +0.1% ) | 3.77 | 3.72 | +1.1% | 2.349 | 2.201 |
  | 2500.3 | 2.065 | 2.063 | 0.002 ( +0.1% ) | 12.36 | 12.18 | +1.5% | 1.979 | 1.903 |
  | 2500.301 | 2.637 | 2.635 | 0.002 ( +0.1% ) | 10.21 | 9.98 | +2.3% | 1.953 | 1.827 |
  | 2500.31 | 1.255 | 1.254 | 0.001 ( +0.1% ) | 19.87 | 19.47 | +2.0% | 2.366 | 2.265 |
  | 2500.311 | 1.641 | 1.640 | 0.001 ( +0.1% ) | 13.59 | 13.49 | +0.8% | 2.439 | 2.321 |
  | 2500.312 | 7.159 | 7.159 | 0.000 ( +0.0% ) | 1.43 | 1.43 | -0.3% | 1.700 | 1.697 |
  | 2500.313 | 1.564 | 1.564 | 0.000 ( +0.0% ) | 6.68 | 6.93 | -3.7% | 1.051 | 1.050 |
  | 2500.314 | 1.163 | 1.163 | 0.000 ( +0.0% ) | 14.36 | 13.92 | +3.1% | 2.227 | 2.204 |
  | 2500.315 | 1.757 | 1.756 | 0.001 ( +0.1% ) | 14.22 | 13.75 | +3.4% | 2.335 | 2.294 |
  | 2500.316 | 3.093 | 3.091 | 0.002 ( +0.1% ) | 2.25 | 2.24 | +0.7% | 2.276 | 2.156 |
  | 2500.317 | 1.788 | 1.787 | 0.001 ( +0.1% ) | 13.61 | 13.36 | +1.8% | 2.172 | 2.260 |
  | 2500.4 | 2.226 | 2.224 | 0.002 ( +0.1% ) | 12.07 | 11.90 | +1.5% | 1.886 | 1.817 |
  | 2500.401 | 1.749 | 1.749 | 0.000 ( +0.0% ) | 10.33 | 10.06 | +2.7% | 1.864 | 1.812 |
  | 2500.402 | 2.770 | 2.769 | 0.002 ( +0.1% ) | 10.01 | 9.83 | +1.9% | 1.864 | 1.748 |
  | 2500.403 | 5.080 | 5.078 | 0.002 ( +0.0% ) | 1.62 | 1.59 | +2.0% | 1.943 | 1.941 |
  | 2500.404 | 2.778 | 2.777 | 0.002 ( +0.1% ) | 10.18 | 9.61 | +6.0% | 1.833 | 1.710 |
  | 2500.5 | 4.936 | 4.936 | 0.000 ( +0.0% ) | 16.51 | 16.23 | +1.7% | 1.507 | 1.543 |
  | 2500.51 | 8.960 | 8.960 | 0.000 ( +0.0% ) | 9.83 | 9.89 | -0.6% | 1.536 | 1.537 |

[vlimant]

as mentioned before, #44587 is already taking care of btagPNetCvNotB which therefore has to be removed from here

[Ming-Yan]

as mentioned before, #44587 is already taking care of btagPNetCvNotB which therefore has to be removed from here

Hi @vlimant thanks, indeed the commits here is exactly same( I did not see the differences from git diff for PhysicsTools/NanoAOD/python/jetsAK4_Puppi_cff.py) how can I fix it technically?

[mandrenguyen]

backport of #43485

[vlimant]

if you rebase to the latest 14.0.X IB, the change relative to btagPNetCvNotB will already be there and should not appear in the PR ; maybe this will all go away in conflict resolving

[hqucms]

+1

[mondalspandan]

+1

[swagata87]

+1

[AdrianoDee]

+pdmv

[jfernan2]

+1

[srimanob]

+Upgrade

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next CMSSW_14_0_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_14_1_X is complete. This pull request will now be reviewed by the release team before it's merged. @sextonkennedy, @antoniovilela, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)

[hqucms]

@cms-sw/orp-l2 Could you please merge this so we can proceed with the integration of #44660? Thanks!

[antoniovilela]

@cms-sw/orp-l2 Could you please merge this so we can proceed with the integration of #44660? Thanks!

@cms-sw/xpog-l2 @cms-sw/reconstruction-l2 @cms-sw/orp-l2

Please clarify the impact of the changes in this PR for RECO & MiniAOD (hopefully no impact).
Thanks.

[hqucms]

@cms-sw/orp-l2 Could you please merge this so we can proceed with the integration of #44660? Thanks!

@cms-sw/xpog-l2 @cms-sw/reconstruction-l2 @cms-sw/orp-l2

Please clarify the impact of the changes in this PR for RECO & MiniAOD (hopefully no impact). Thanks.

@antoniovilela This one has no impact on RECO & MiniAOD (& official NanoAOD) -- it only introduces a custom flavor of NanoAOD.

[mandrenguyen]

@cms-sw/orp-l2 Could you please merge this so we can proceed with the integration of #44660? Thanks!

@cms-sw/xpog-l2 @cms-sw/reconstruction-l2 @cms-sw/orp-l2
Please clarify the impact of the changes in this PR for RECO & MiniAOD (hopefully no impact). Thanks.

@antoniovilela This one has no impact on RECO & MiniAOD (& official NanoAOD) -- it only introduces a custom flavor of NanoAOD.

+1 from reco

[antoniovilela]

@cms-sw/orp-l2 Could you please merge this so we can proceed with the integration of #44660? Thanks!

@cms-sw/xpog-l2 @cms-sw/reconstruction-l2 @cms-sw/orp-l2
Please clarify the impact of the changes in this PR for RECO & MiniAOD (hopefully no impact). Thanks.

@antoniovilela This one has no impact on RECO & MiniAOD (& official NanoAOD) -- it only introduces a custom flavor of NanoAOD.

Ok, I will first cut the patch release for data taking, tomorrow, and then merge this PR.

[rappoccio]

+1