Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add reduced lepton time-life info to NanoAOD #44637

Merged
merged 2 commits into from
Apr 12, 2024

Conversation

mbluj
Copy link
Contributor

@mbluj mbluj commented Apr 5, 2024

PR description:

This PR adds base lepton time-life info to common (Phys) NanoAOD tables while lepton track parameters can be added through customization.
The base lepton time-life info increases size of nanoAOD with RelVal TTBar MC by ~3.5% compared to ~11% for the full info containing track parameters (reduction by factor of ~3). Further details in those slides:
Tau-Lifetime in NanoAOD.pdf

PR validation:

Tested with the standard nanoAOD workflow.

If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:

If accepted backport to 14_0_X will be provided.

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 5, 2024

cms-bot internal usage

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 5, 2024

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-44637/39824

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 5, 2024

A new Pull Request was created by @mbluj for master.

It involves the following packages:

  • Configuration/PyReleaseValidation (upgrade, pdmv)
  • PhysicsTools/NanoAOD (xpog)

@vlimant, @hqucms, @sunilUIET, @subirsarkar, @srimanob, @miquork, @cmsbuild, @AdrianoDee can you please review it and eventually sign? Thanks.
@missirol, @Martin-Grunewald, @AnnikaStein, @gpetruc, @fabiocos, @slomeo, @makortel this is something you requested to watch as well.
@rappoccio, @antoniovilela, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

@vlimant
Copy link
Contributor

vlimant commented Apr 7, 2024

enable nano

@vlimant
Copy link
Contributor

vlimant commented Apr 7, 2024

please test

@vlimant
Copy link
Contributor

vlimant commented Apr 7, 2024

type tau

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 7, 2024

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-939514/38667/summary.html
COMMIT: e07a1ac
CMSSW: CMSSW_14_1_X_2024-04-07-0000/el8_amd64_gcc12
Additional Tests: NANO
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/44637/38667/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • You potentially added 9 lines to the logs
  • ROOTFileChecks: Some differences in event products or their sizes found
  • Reco comparison results: 47 differences found in the comparisons
  • DQMHistoTests: Total files compared: 48
  • DQMHistoTests: Total histograms compared: 3307717
  • DQMHistoTests: Total failures: 0
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3307697
  • DQMHistoTests: Total skipped: 20
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 43.38 KiB( 47 files compared)
  • DQMHistoSizes: changed ( 13234.0,... ): 4.820 KiB Physics/NanoAODDQM
  • Checked 202 log files, 165 edm output root files, 48 DQM output files
  • TriggerResults: no differences found

NANO Comparison Summary

Summary:

  • You potentially removed 1 lines from the logs
  • ROOTFileChecks: Some differences in event products or their sizes found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 15
  • DQMHistoTests: Total histograms compared: 16430
  • DQMHistoTests: Total failures: 0
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 16430
  • DQMHistoTests: Total skipped: 0
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 33.74 KiB( 14 files compared)
  • DQMHistoSizes: changed ( 2500.011,... ): 4.820 KiB Physics/NanoAODDQM
  • Checked 49 log files, 27 edm output root files, 15 DQM output files

Nano size comparison Summary:

Sample kb/ev ref kb/ev diff kb/ev ev/s/thd ref ev/s/thd diff rate mem/thd ref mem/thd
2500.0 2.669 2.553 0.116 ( +4.5% ) 4.57 4.69 -2.4% 2.177 2.168
2500.001 2.782 2.703 0.079 ( +2.9% ) 4.04 4.16 -2.7% 2.597 2.593
2500.002 2.730 2.643 0.087 ( +3.3% ) 4.22 4.31 -1.9% 2.591 2.584
2500.01 1.381 1.318 0.063 ( +4.8% ) 8.12 8.40 -3.3% 2.273 2.276
2500.011 1.817 1.739 0.078 ( +4.5% ) 4.50 4.61 -2.5% 2.425 2.444
2500.012 1.675 1.580 0.095 ( +6.0% ) 6.31 6.54 -3.6% 2.362 2.354
2500.1 2.272 2.196 0.076 ( +3.4% ) 4.61 4.63 -0.3% 2.016 2.070
2500.2 2.388 2.313 0.075 ( +3.3% ) 5.34 5.32 +0.5% 1.980 1.972
2500.21 1.254 1.181 0.072 ( +6.1% ) 3.51 3.55 -1.0% 2.215 2.271
2500.211 1.627 1.545 0.083 ( +5.3% ) 3.14 3.18 -1.3% 2.247 2.253
2500.3 2.143 2.069 0.074 ( +3.6% ) 10.24 10.41 -1.6% 1.967 1.965
2500.301 2.724 2.642 0.082 ( +3.1% ) 8.54 8.62 -1.0% 1.958 1.951
2500.31 7.159 7.159 0.000 ( +0.0% ) 1.37 1.42 -4.0% 1.702 1.702
2500.311 1.564 1.564 0.000 ( +0.0% ) 5.92 7.18 -17.5% 1.052 1.054
2500.312 540.453 540.453 0.000 ( +0.0% ) 0.53 0.53 -0.1% 1.590 1.594
2500.313 817.689 817.689 0.000 ( +0.0% ) 0.73 0.74 -0.6% 1.579 1.585
2500.32 1.323 1.255 0.067 ( +5.4% ) 12.85 13.24 -2.9% 2.299 2.317
2500.321 1.723 1.642 0.081 ( +5.0% ) 10.08 10.01 +0.7% 2.426 2.401
2500.322 1.204 1.163 0.041 ( +3.5% ) 10.05 10.50 -4.3% 2.201 2.213
2500.323 1.839 1.758 0.081 ( +4.6% ) 10.11 10.16 -0.5% 2.160 2.147
2500.324 3.175 3.093 0.081 ( +2.6% ) 1.84 1.83 +0.6% 2.244 2.097
2500.325 1.777 1.789 -0.012 ( -0.7% ) 10.35 10.34 +0.1% 2.184 2.295
2500.4 2.306 2.227 0.078 ( +3.5% ) 9.83 9.91 -0.9% 1.866 1.840
2500.401 1.791 1.755 0.036 ( +2.0% ) 8.26 8.37 -1.2% 1.740 1.728
2500.402 2.857 2.771 0.086 ( +3.1% ) 8.38 8.30 +0.9% 1.863 1.835
2500.403 5.166 5.081 0.086 ( +1.7% ) 1.35 1.34 +0.9% 1.820 1.843
2500.404 2.767 2.779 -0.012 ( -0.4% ) 8.50 8.42 +0.9% 1.807 1.749
2500.5 4.936 4.936 0.000 ( +0.0% ) 15.89 15.97 -0.5% 1.329 1.300
2500.51 8.960 8.960 0.000 ( +0.0% ) 9.69 9.73 -0.3% 1.393 1.397

@mbluj
Copy link
Contributor Author

mbluj commented Apr 10, 2024

Rebased to solve merge conflicts which appeared because of changes in master.

@cmsbuild
Copy link
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-44637/39889

@cmsbuild
Copy link
Contributor

Pull request #44637 was updated. @sunilUIET, @subirsarkar, @hqucms, @srimanob, @miquork, @cmsbuild, @vlimant, @AdrianoDee can you please check and sign again.

@hqucms
Copy link
Contributor

hqucms commented Apr 10, 2024

please test

@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-939514/38748/summary.html
COMMIT: 1abff44
CMSSW: CMSSW_14_1_X_2024-04-10-1100/el8_amd64_gcc12
Additional Tests: NANO
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/44637/38748/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • You potentially added 102 lines to the logs
  • ROOTFileChecks: Some differences in event products or their sizes found
  • Reco comparison results: 41 differences found in the comparisons
  • DQMHistoTests: Total files compared: 48
  • DQMHistoTests: Total histograms compared: 3316263
  • DQMHistoTests: Total failures: 3
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3316240
  • DQMHistoTests: Total skipped: 20
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 43.38 KiB( 47 files compared)
  • DQMHistoSizes: changed ( 13234.0,... ): 4.820 KiB Physics/NanoAODDQM
  • Checked 202 log files, 165 edm output root files, 48 DQM output files
  • TriggerResults: no differences found

NANO Comparison Summary

Summary:

  • You potentially added 3 lines to the logs
  • ROOTFileChecks: Some differences in event products or their sizes found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 15
  • DQMHistoTests: Total histograms compared: 16484
  • DQMHistoTests: Total failures: 0
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 16484
  • DQMHistoTests: Total skipped: 0
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 33.74 KiB( 14 files compared)
  • DQMHistoSizes: changed ( 2500.011,... ): 4.820 KiB Physics/NanoAODDQM
  • Checked 53 log files, 30 edm output root files, 15 DQM output files

Nano size comparison Summary:

Sample kb/ev ref kb/ev diff kb/ev ev/s/thd ref ev/s/thd diff rate mem/thd ref mem/thd
2500.0 2.691 2.574 0.117 ( +4.5% ) 4.53 4.50 +0.6% 2.232 2.209
2500.001 2.802 2.722 0.081 ( +3.0% ) 4.02 4.02 +0.1% 2.555 2.231
2500.002 2.749 2.667 0.082 ( +3.1% ) 4.20 4.16 +0.8% 2.549 2.249
2500.01 1.381 1.318 0.063 ( +4.8% ) 8.02 8.08 -0.7% 2.277 1.986
2500.011 1.817 1.739 0.078 ( +4.5% ) 4.51 4.50 +0.4% 2.433 1.999
2500.012 1.675 1.580 0.095 ( +6.0% ) 6.39 6.36 +0.4% 2.351 2.017
2500.1 2.294 2.218 0.076 ( +3.4% ) 4.63 4.49 +3.1% 2.083 2.052
2500.2 2.409 2.333 0.076 ( +3.3% ) 5.26 5.08 +3.6% 1.993 1.931
2500.21 1.254 1.182 0.072 ( +6.1% ) 3.54 3.46 +2.2% 2.289 1.954
2500.211 1.629 1.546 0.083 ( +5.3% ) 3.18 3.04 +4.6% 2.365 2.052
2500.3 2.163 2.089 0.074 ( +3.5% ) 10.20 9.56 +6.6% 1.974 1.961
2500.301 2.748 2.667 0.082 ( +3.1% ) 8.73 8.10 +7.7% 1.961 1.957
2500.31 7.159 7.159 0.000 ( +0.0% ) 1.44 1.33 +7.8% 1.701 1.702
2500.311 1.564 1.564 0.000 ( +0.0% ) 6.97 6.94 +0.4% 1.049 1.052
2500.312 540.453 540.453 0.000 ( +0.0% ) 0.53 0.49 +7.3% 1.601 1.592
2500.313 817.689 817.689 0.000 ( +0.0% ) 0.74 0.67 +9.9% 1.578 1.604
2500.32 1.324 1.256 0.068 ( +5.4% ) 13.17 12.01 +9.7% 2.367 1.905
2500.321 1.724 1.643 0.081 ( +4.9% ) 9.72 9.19 +5.9% 2.417 2.090
2500.322 1.204 1.163 0.041 ( +3.5% ) 10.30 9.91 +3.9% 2.142 2.125
2500.323 7.768 7.768 0.000 ( +0.0% ) 3.40 3.25 +4.6% 1.924 1.822
2500.324 1.840 1.759 0.081 ( +4.6% ) 10.16 9.62 +5.6% 2.193 2.176
2500.325 4.225 4.144 0.081 ( +2.0% ) 4.30 4.05 +6.3% 2.218 1.793
2500.326 3.176 3.095 0.081 ( +2.6% ) 1.80 1.71 +4.8% 2.055 1.926
2500.327 1.778 1.791 -0.012 ( -0.7% ) 10.47 9.74 +7.5% 2.328 2.034
2500.4 2.323 2.245 0.078 ( +3.5% ) 9.76 9.15 +6.6% 1.851 1.826
2500.401 1.814 1.778 0.036 ( +2.0% ) 8.67 8.09 +7.3% 1.738 1.699
2500.402 2.881 2.795 0.086 ( +3.1% ) 8.39 7.93 +5.9% 1.912 1.908
2500.403 8.838 8.752 0.086 ( +1.0% ) 2.82 2.65 +6.7% 1.924 1.821
2500.404 5.191 5.105 0.086 ( +1.7% ) 1.33 1.28 +4.2% 1.765 1.782
2500.405 2.791 2.803 -0.012 ( -0.4% ) 8.35 7.71 +8.3% 1.907 1.901
2500.5 5.192 5.192 0.000 ( +0.0% ) 15.78 15.28 +3.2% 1.496 1.562
2500.51 9.119 9.119 0.000 ( +0.0% ) 9.64 9.42 +2.3% 1.311 1.512

@hqucms
Copy link
Contributor

hqucms commented Apr 11, 2024

+1

@srimanob
Copy link
Contributor

+Upgrade

@AdrianoDee
Copy link
Contributor

+pdmv

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @sextonkennedy, @antoniovilela, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)

@rappoccio
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit 7135c7d into cms-sw:master Apr 12, 2024
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants