Customized L1T NanoAOD #43957
Customized L1T NanoAOD #43957
Conversation
|
cms-bot internal usage |
|
-code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-43957/38843
Code check has found code style and quality issues which could be resolved by applying following patch(s)
|
cmsbuild
added
code-checks-rejected
code-checks-pending
and removed
code-checks-pending
code-checks-rejected
labels
|
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-43957/38844 |
|
A new Pull Request was created by @lathomas for master. It involves the following packages:
The following packages do not have a category, yet: DPGAnalysis/L1TNanoAOD @cmsbuild can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
|
I guess this should be assigned to XPOG ? @vlimant @hqucms |
|
assign xpog |
|
The first two recommendations are to follow the |
|
#40663 allows to add the unpacked L1 objects to central NANO, starting from MINIAOD. This PR is much more generic: it allows to define a custom NANO format, that stores both emulated and unpacked L1 objects, but also the Trigger Primitives (calo only for now). This package aims at replacing https://github.com/cms-sw/cmssw/tree/master/L1Trigger/L1TNtuples/ |
|
About the test workflow, I guess I need to add some lines like HCAL did in https://github.com/cms-sw/cmssw/blob/master/Configuration/PyReleaseValidation/python/relval_production.py#L41-L42 |
This I didn't really get, sorry. Could you provide an example of what you mean? |
|
please see #43065 for the test and the |
|
@lathomas I used this as a reference:
#42238
And in the PR from above it must be here:
<https://github.com/cms-sw/cmssw/pull/43065/files#diff-2380e1dfdfadf32cba9abec31248637f27f5ce4dc6fc0b2179de7232c78728ba>
[3865030.jpeg]
Fixes/impovements towards the first production version of the custom muon DPG NANO by battibass · Pull Request #43065 · cms-sw/cmssw<https://github.com/cms-sw/cmssw/pull/43065/files#diff-2380e1dfdfadf32cba9abec31248637f27f5ce4dc6fc0b2179de7232c78728ba>
github.com<https://github.com/cms-sw/cmssw/pull/43065/files#diff-2380e1dfdfadf32cba9abec31248637f27f5ce4dc6fc0b2179de7232c78728ba>
Message ID: ***@***.***>
|
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
|
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-43957/39484 |
|
+1 Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-c45c51/38550/summary.html Comparison SummarySummary:
NANO Comparison SummarySummary:
Nano size comparison Summary:
|
|
+l1
|
|
@AdrianoDee @srimanob can you take a look and sign if happy? Thanks ! |
|
+Upgrade |
|
Just a remark for the future: unless really needed I would append the new wfs rather than placing them in the middle resulting in a change to the wf numbering. Maybe in this case it is just an artifact due to the multiple concurrent PRs and the need to rebase, but still. |
|
+pdmv |
cmsbuild
added
fully-signed
pdmv-approved
and removed
pending-signatures
pdmv-pending
labels
|
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @sextonkennedy, @antoniovilela, @rappoccio (and backports should be raised in the release meeting by the corresponding L2) |
|
+1 |
|
I am puzzled how tests succeeded here and lead to #44666 ... |
|
This PR was tested with |
PR description:
This package allows to save Level 1 Trigger information (unpacked or reemulated) in a standard NANOAOD format. A few examples of cmsDriver commands are provided for Run 3 data and simulated samples in the README file.
The current PR focuses on Phase 1 L1 objects (unpacked or reemulated), and calorimeter trigger primitives and trigger towers. It is expected to be completed in the future with additional information (e.g. on muon TPs).
PR validation:
The
cmsDriver.pycommands in the README are found to properly run.