l1nano import location

[vlimant]

PR description:

trivial move of the import

PR validation:

nano matrix

[vlimant]

enable nano

[cmsbuild]

cms-bot internal usage

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-44391/39452

• This PR adds an extra 16KB to repository

• There are other open Pull requests which might conflict with changes you have proposed:

  • File PhysicsTools/NanoAOD/python/autoNANO.py modified in PR(s): [NanoAOD,BTVNano] Btvnano integration as customized module #43485, adding JME nano in autoNano #44087

[cmsbuild]

A new Pull Request was created by @vlimant for master.

It involves the following packages:

• PhysicsTools/NanoAOD (xpog)

@cmsbuild, @vlimant, @hqucms can you please review it and eventually sign? Thanks.
@AnnikaStein, @gpetruc this is something you requested to watch as well.
@sextonkennedy, @antoniovilela, @rappoccio you are the release manager for this.

cms-bot commands are listed here

[vlimant]

please test

[cmsbuild]

-1

Failed Tests: RelVals-INPUT RelVals-NANO
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-352eb2/38105/summary.html
COMMIT: 6784a28
CMSSW: CMSSW_14_1_X_2024-03-13-1100/el8_amd64_gcc12
Additional Tests: NANO
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/44391/38105/install.sh to create a dev area with all the needed externals and cmssw changes.

RelVals-INPUT

• 2500.2112500.211_NANOdata124Xrun3/step2_NANOdata124Xrun3.log
• 2500.3112500.311_NANOdata130Xrun3/step2_NANOdata130Xrun3.log

RelVals-NANO

• 2500.2112500.211_NANOdata124Xrun3/step2_NANOdata124Xrun3.log
• 2500.3112500.311_NANOdata130Xrun3/step2_NANOdata130Xrun3.log

Comparison Summary

Summary:

• You potentially added 91 lines to the logs
• Reco comparison results: 49 differences found in the comparisons
• DQMHistoTests: Total files compared: 48
• DQMHistoTests: Total histograms compared: 3297383
• DQMHistoTests: Total failures: 3
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3297360
• DQMHistoTests: Total skipped: 20
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 47 files compared)
• Checked 202 log files, 165 edm output root files, 48 DQM output files
• TriggerResults: no differences found

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-44391/39470

• This PR adds an extra 24KB to repository

• There are other open Pull requests which might conflict with changes you have proposed:

  • File Configuration/DataProcessing/python/Reco.py modified in PR(s): [Dummy] Try creating big-enough cache to cause splitting #44368
  • File Configuration/PyReleaseValidation/python/relval_nano.py modified in PR(s): [NanoAOD,BTVNano] Btvnano integration as customized module #43485, adding JME nano in autoNano #44087
  • File PhysicsTools/NanoAOD/python/autoNANO.py modified in PR(s): [NanoAOD,BTVNano] Btvnano integration as customized module #43485, adding JME nano in autoNano #44087

[cmsbuild]

Pull request #44391 was updated. @davidlange6, @rappoccio, @fabiocos, @antoniovilela, @subirsarkar, @srimanob can you please check and sign again.

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-352eb2/38494/summary.html
COMMIT: 310cc3e
CMSSW: CMSSW_14_1_X_2024-03-28-1100/el8_amd64_gcc12
Additional Tests: NANO
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/44391/38494/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

• You potentially added 97 lines to the logs
• Reco comparison results: 40 differences found in the comparisons
• DQMHistoTests: Total files compared: 48
• DQMHistoTests: Total histograms compared: 3297437
• DQMHistoTests: Total failures: 3
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3297414
• DQMHistoTests: Total skipped: 20
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 47 files compared)
• Checked 202 log files, 165 edm output root files, 48 DQM output files
• TriggerResults: no differences found

NANO Comparison Summary

Summary:

• You potentially removed 1 lines from the logs
• Reco comparison results: 0 differences found in the comparisons
• DQMHistoTests: Total files compared: 15
• DQMHistoTests: Total histograms compared: 16402
• DQMHistoTests: Total failures: 0
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 16402
• DQMHistoTests: Total skipped: 0
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 14 files compared)
• Checked 47 log files, 27 edm output root files, 15 DQM output files

Nano size comparison Summary:

Sample	kb/ev	ref kb/ev	diff kb/ev	ev/s/thd	ref ev/s/thd	diff rate	mem/thd	ref mem/thd
2500.0	2.548	2.548	0.000 ( +0.0% )	4.50	4.63	-2.8%	2.163	2.134
2500.001	2.697	2.697	0.000 ( +0.0% )	4.04	4.13	-2.1%	2.542	2.553
2500.002	2.637	2.637	0.000 ( +0.0% )	4.17	4.30	-3.0%	2.533	2.546
2500.01	1.318	1.318	0.000 ( +0.0% )	7.93	8.35	-5.0%	2.267	2.219
2500.011	1.739	1.739	0.000 ( +0.0% )	4.49	4.60	-2.3%	2.405	2.353
2500.012	1.580	1.580	0.000 ( +0.0% )	6.31	6.57	-3.9%	2.402	2.318
2500.1	2.192	2.192	0.000 ( +0.0% )	4.54	4.62	-1.9%	2.063	1.958
2500.2	2.308	2.308	0.000 ( +0.0% )	5.13	5.29	-3.0%	1.974	1.860
2500.21	1.181	1.181	0.000 ( +0.0% )	3.48	3.53	-1.5%	2.255	2.157
2500.211	1.545	1.545	0.000 ( +0.0% )	2.94	3.12	-5.8%	2.231	2.170
2500.3	2.064	2.064	0.000 ( +0.0% )	9.33	9.98	-6.5%	1.962	1.859
2500.301	2.637	2.637	0.000 ( +0.0% )	8.00	8.28	-3.4%	1.946	1.791
2500.31	1.255	1.255	0.000 ( +0.0% )	12.32	13.28	-7.2%	2.333	2.207
2500.311	1.642	1.642	0.000 ( +0.0% )	9.47	9.74	-2.8%	2.301	2.245
2500.312	7.159	7.159	0.000 ( +0.0% )	1.36	1.42	-4.2%	1.709	1.708
2500.313	1.564	1.564	0.000 ( +0.0% )	6.44	6.85	-6.0%	1.064	1.054
2500.314	1.163	1.163	0.000 ( +0.0% )	9.11	10.32	-11.7%	2.225	2.215
2500.315	1.758	1.758	0.000 ( +0.0% )	9.37	10.45	-10.4%	2.285	2.280
2500.316	3.093	3.093	0.000 ( +0.0% )	1.67	1.82	-8.8%	2.252	2.056
2500.317	1.789	1.789	0.000 ( +0.0% )	9.02	10.24	-11.9%	2.211	2.258
2500.4	2.221	2.221	0.000 ( +0.0% )	9.23	9.89	-6.6%	1.886	1.838
2500.401	1.755	1.755	0.000 ( +0.0% )	7.86	8.54	-7.9%	1.700	1.684
2500.402	2.766	2.766	0.000 ( +0.0% )	7.89	8.52	-7.4%	1.780	1.766
2500.403	5.068	5.068	0.000 ( +0.0% )	1.26	1.34	-5.5%	1.829	1.800
2500.404	2.774	2.774	0.000 ( +0.0% )	7.53	8.16	-7.7%	1.699	1.697
2500.5	4.936	4.936	0.000 ( +0.0% )	14.90	16.15	-7.7%	1.599	1.580
2500.51	8.960	8.960	0.000 ( +0.0% )	9.20	9.65	-4.6%	1.439	1.404

[AdrianoDee]

+pdmv

• re-sign

[srimanob]

+Upgrade

[vlimant]

could we bypass the operations signature to merge this in ?

[antoniovilela]

N.B git cms-rebase-topic vlimant:l1nano_include gives me all sorts of conflicts that are not detected here, therefore I cannot test anything locally and going blind

@vlimant
Is it working locally now?

[antoniovilela]

could we bypass the operations signature to merge this in ?

@vlimant
Do not worry about the @cms-sw/operations-l2 signature. ORP signs for operations, and usually we will sign and merge simultaneously, after the other signatures are cleared (as previously mentioned, you can raise PRs in the weekly meeting requesting missing signatures).

[vlimant]

all good on testing

[antoniovilela]

+1

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will be automatically merged.