Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Slight update to TensorFlowAOT interface. #44586

Merged
merged 2 commits into from
Apr 3, 2024

Conversation

riga
Copy link
Contributor

@riga riga commented Apr 2, 2024

PR description

This PR extends the TensorFlowAOT interface to simplify the configuration of dynamic batching rules (defining, e.g., how batch size X should be composed of batch sizes s1,s2,... that a model was compiled for; see this talk, slide 12) for plugins.

As batch rules could in principle be defined at execution time through options, a helper that converts strings such as 5:4,1 (i.e, run models for batch sizes 4 and 1 to compose batch size 5) to batch rules is required, which is provided by this PR.

PR validation

The existing interface unit tests are updated to cover the conversion.

Should be tested with cms-sw/cmsdist#9108.

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 2, 2024

cms-bot internal usage

@smuzaffar
Copy link
Contributor

test parameters:

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 2, 2024

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-44586/39753

  • This PR adds an extra 16KB to repository

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 2, 2024

A new Pull Request was created by @riga for master.

It involves the following packages:

  • PhysicsTools/TensorFlowAOT (ml)

@wpmccormack, @valsdav, @cmsbuild can you please review it and eventually sign? Thanks.
@makortel this is something you requested to watch as well.
@sextonkennedy, @antoniovilela, @rappoccio you are the release manager for this.

cms-bot commands are listed here

@smuzaffar
Copy link
Contributor

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 2, 2024

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-c166d2/38549/summary.html
COMMIT: 8e69cad
CMSSW: CMSSW_14_1_X_2024-04-02-1100/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/44586/38549/install.sh to create a dev area with all the needed externals and cmssw changes.

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:

You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-c166d2/38549/git-recent-commits.json
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-c166d2/38549/git-merge-result

Comparison Summary

Summary:

  • You potentially added 16 lines to the logs
  • Reco comparison results: 45 differences found in the comparisons
  • DQMHistoTests: Total files compared: 48
  • DQMHistoTests: Total histograms compared: 3297469
  • DQMHistoTests: Total failures: 6
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3297443
  • DQMHistoTests: Total skipped: 20
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 29848.476 KiB( 47 files compared)
  • DQMHistoSizes: changed ( 10224.0,... ): 2132.034 KiB Muons/RecoDisplacedMuonV
  • Checked 202 log files, 165 edm output root files, 48 DQM output files
  • TriggerResults: no differences found

@valsdav
Copy link
Contributor

valsdav commented Apr 3, 2024

+ml

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 3, 2024

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @sextonkennedy, @antoniovilela, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)
Notice This PR was tested with additional Pull Request(s), please also merge them if necessary: cms-sw/cmsdist#9108

@antoniovilela
Copy link
Contributor

+1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants