Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lepton time-life info for NanoAOD and Nano branches from ValueMap of elaborated types (14_0_X) #44040

Merged
merged 14 commits into from
Feb 29, 2024

Conversation

mbluj
Copy link
Contributor

@mbluj mbluj commented Feb 21, 2024

PR description:

This PR adds a customization to add lepton time-life related information to NanoAOD. The information contains:

  • (refitted) secondary vertex for 3-prong taus (with covariance matrix),
  • impact parameter vector (with significance) of the electron, muon and tau tracks wrt PV fitted with beam-spot constraint,
  • parameters of electron, muon and tau tracks (with covariance matrix),
  • primary vertex with beam-spot constraint (position and covariance matrix).

All those variables are used in the measurement of CP structure of the Higgs-tau Yukawa coupling and related analyses, e.g. measurement of polarization of Z in decays to taus.

In addition, this PR introduces producer of NanoAOD branches from ValueMap of elaborated types in order to enable table extensions using elaborated types other than numeric types (int, float, ...). The new producer is used to store lepton time-life related information in NanoAOD.

This PR backports #43525 and #43916 to 14_0_X.

PR validation:

Validated in original PRs.
In addition customized NanoAOD workflow (with the following cmsDriver command) run successfully:

cmsDriver.py --python_filename NanoAOD_lifeTimeCustom_cfg.py --eventcontent NANOAODSIM --customise_commands="process.add_(cms.Service('InitRootHandlers',EnableIMT = cms.untracked.bool(False)));process.MessageLogger.cerr.FwkReport.reportEvery=1000" --datatier NANOAODSIM --fileout file:NanoAOD_lifeTimeCustom.root --conditions auto:phase1_2018_realistic --step NANO:@LepTimeLife,DQM:@nanoAODDQM--filein file:some_ttbar2018file.root --era Run2_2018,run2_nanoAOD_106Xv2 --no_exec --mc -n -1

If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:

Backport of #43525 and #43916 to 14_0_X which is production release series for 2024.

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @mbluj for CMSSW_14_0_X.

It involves the following packages:

  • DataFormats/VertexReco (reconstruction)
  • PhysicsTools/NanoAOD (xpog)
  • PhysicsTools/PatAlgos (reconstruction, xpog)

@cmsbuild, @jfernan2, @hqucms, @mandrenguyen, @vlimant can you please review it and eventually sign? Thanks.
@VinInn, @missirol, @VourMa, @mmarionncern, @mtosi, @mmusich, @demuller, @ahinzmann, @Senphy, @gkasieczka, @mbluj, @JanFSchulte, @andrzejnovak, @seemasharmafnal, @AnnikaStein, @rovere, @jdolen, @nhanvtran, @gpetruc, @hatakeyamak, @schoef, @jdamgov, @Ming-Yan, @rappoccio, @JyothsnaKomaragiri, @gouskos, @emilbols, @mariadalfonso, @AlexDeMoor, @azotz this is something you requested to watch as well.
@antoniovilela, @rappoccio, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

@cmsbuild
Copy link
Contributor

cmsbuild commented Feb 21, 2024

cms-bot internal usage

@vlimant
Copy link
Contributor

vlimant commented Feb 21, 2024

enable nano

@vlimant
Copy link
Contributor

vlimant commented Feb 21, 2024

please test

@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-d0ab7b/37596/summary.html
COMMIT: f0ab643
CMSSW: CMSSW_14_0_X_2024-02-21-1100/el8_amd64_gcc12
Additional Tests: NANO
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/44040/37596/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

NANO Comparison Summary

Summary:

  • You potentially added 3 lines to the logs
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 15
  • DQMHistoTests: Total histograms compared: 16524
  • DQMHistoTests: Total failures: 0
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 16524
  • DQMHistoTests: Total skipped: 0
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 14 files compared)
  • Checked 38 log files, 18 edm output root files, 15 DQM output files

Nano size comparison Summary:

Sample kb/ev ref kb/ev diff kb/ev ev/s/thd ref ev/s/thd diff rate mem/thd ref mem/thd
2500.0 2.545 2.545 0.000 ( +0.0% ) 5.25 5.28 -0.6% 2.149 2.175
2500.001 2.692 2.692 0.000 ( +0.0% ) 4.73 4.75 -0.5% 2.560 2.606
2500.002 2.631 2.631 0.000 ( +0.0% ) 4.90 4.86 +0.9% 2.545 2.590
2500.01 1.315 1.315 0.000 ( +0.0% ) 9.48 9.71 -2.3% 2.306 2.265
2500.011 1.732 1.732 0.000 ( +0.0% ) 5.18 5.26 -1.6% 2.443 2.428
2500.012 1.578 1.578 0.000 ( +0.0% ) 7.43 7.45 -0.4% 2.317 2.399
2500.1 2.193 2.193 0.000 ( +0.0% ) 5.33 5.31 +0.3% 1.992 2.073
2500.2 2.307 2.307 0.000 ( +0.0% ) 6.09 6.09 -0.0% 1.898 1.984
2500.21 1.183 1.183 0.000 ( +0.0% ) 4.36 4.32 +0.9% 2.192 2.267
2500.211 1.547 1.547 0.000 ( +0.0% ) 3.74 3.78 -0.9% 2.248 2.341
2500.3 2.063 2.063 0.000 ( +0.0% ) 12.42 12.79 -2.9% 1.904 1.973
2500.31 1.259 1.259 0.000 ( +0.0% ) 19.68 19.83 -0.7% 2.311 2.364
2500.311 1.648 1.648 0.000 ( +0.0% ) 11.95 12.11 -1.4% 2.335 2.421
2500.312 7.159 7.159 0.000 ( +0.0% ) 1.36 1.39 -2.2% 1.711 1.698
2500.313 1.564 1.564 0.000 ( +0.0% ) 6.01 6.73 -10.7% 1.064 1.050
2500.4 2.063 2.063 0.000 ( +0.0% ) 12.46 12.77 -2.4% 1.906 1.975
2500.5 19.575 19.575 0.000 ( +0.0% ) 1.15 1.12 +2.6% 1.129 1.124

@vlimant
Copy link
Contributor

vlimant commented Feb 26, 2024

+1

@mandrenguyen
Copy link
Contributor

backport of #43525 and #43916

@mandrenguyen
Copy link
Contributor

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_14_0_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_14_1_X is complete. This pull request will now be reviewed by the release team before it's merged. @sextonkennedy, @antoniovilela, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)

@rappoccio
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit 4177026 into cms-sw:CMSSW_14_0_X Feb 29, 2024
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants