Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test workflows for lepton time-life customization of NanoAOD #44263

Merged
merged 1 commit into from
Mar 12, 2024

Conversation

mbluj
Copy link
Contributor

@mbluj mbluj commented Feb 29, 2024

PR description:

This PR adds test workflows for lepton time-life customization of NanoAOD.
Those workflows completes inclusion of the customization into CMSSW and were requested in the original PR: #43525 (comment).

Backport of this PR is not foreseen.

PR validation:

The newly added workflows run successfully like this:

runTheMatrix.py -l 2500.403,2500.316 -i all --ibeos

@cmsbuild
Copy link
Contributor

cmsbuild commented Feb 29, 2024

cms-bot internal usage

@cmsbuild
Copy link
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-44263/39281

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @mbluj for master.

It involves the following packages:

  • Configuration/PyReleaseValidation (pdmv, upgrade)

@srimanob, @miquork, @cmsbuild, @AdrianoDee, @sunilUIET, @subirsarkar can you please review it and eventually sign? Thanks.
@missirol, @fabiocos, @makortel, @Martin-Grunewald, @slomeo this is something you requested to watch as well.
@antoniovilela, @sextonkennedy, @rappoccio you are the release manager for this.

cms-bot commands are listed here

@vlimant
Copy link
Contributor

vlimant commented Mar 2, 2024

enable nano

@vlimant
Copy link
Contributor

vlimant commented Mar 2, 2024

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 2, 2024

-1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-b7d4c9/37862/summary.html
COMMIT: 5af9617
CMSSW: CMSSW_14_1_X_2024-03-02-1100/el8_amd64_gcc12
Additional Tests: NANO
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/44263/37862/install.sh to create a dev area with all the needed externals and cmssw changes.

This pull request cannot be automatically merged, could you please rebase it?
You can see the log for git cms-merge-topic here: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-b7d4c9/37862/git-merge-result

@mbluj
Copy link
Contributor Author

mbluj commented Mar 4, 2024

Rebased to fix issue with merging in tests - tests can be restarted, please do it.
After rebasing added test workflows' numbers were increased, so PR description was updated accordingly.

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 4, 2024

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-44263/39314

  • This PR adds an extra 12KB to repository

  • There are other open Pull requests which might conflict with changes you have proposed:

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 4, 2024

Pull request #44263 was updated. @AdrianoDee, @subirsarkar, @sunilUIET, @srimanob, @cmsbuild, @miquork can you please check and sign again.

@vlimant
Copy link
Contributor

vlimant commented Mar 4, 2024

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 4, 2024

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-b7d4c9/37873/summary.html
COMMIT: 4f47ac5
CMSSW: CMSSW_14_1_X_2024-03-03-2300/el8_amd64_gcc12
Additional Tests: NANO
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/44263/37873/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

NANO Comparison Summary

Summary:

  • You potentially added 2 lines to the logs
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 15
  • DQMHistoTests: Total histograms compared: 16430
  • DQMHistoTests: Total failures: 0
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 16430
  • DQMHistoTests: Total skipped: 0
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 14 files compared)
  • Checked 43 log files, 23 edm output root files, 15 DQM output files

Nano size comparison Summary:

  • Nano ERROR: Missing ref/2500.316-size.json
  • Nano ERROR: Missing ref/2500.316-size.json
  • Nano ERROR: Missing ref/2500.403-size.json
  • Nano ERROR: Missing ref/2500.403-size.json
    | Sample | kb/ev | ref kb/ev | diff kb/ev | ev/s/thd | ref ev/s/thd | diff rate | mem/thd | ref mem/thd |
    | --- | --- | --- | --- | --- | --- | --- | --- | --- |
    | 2500.0 | 2.551 | 2.551 | 0.000 ( +0.0% ) | 4.81 | 5.04 | -4.6% | 2.222 | 2.165 |
    | 2500.001 | 2.700 | 2.700 | 0.000 ( +0.0% ) | 4.70 | 4.64 | +1.2% | 2.638 | 2.575 |
    | 2500.002 | 2.641 | 2.641 | 0.000 ( +0.0% ) | 4.86 | 4.78 | +1.7% | 2.632 | 2.586 |
    | 2500.01 | 1.322 | 1.322 | 0.000 ( +0.0% ) | 9.78 | 9.28 | +5.3% | 2.271 | 2.242 |
    | 2500.011 | 1.745 | 1.745 | 0.000 ( +0.0% ) | 5.19 | 5.09 | +2.1% | 2.448 | 2.376 |
    | 2500.012 | 1.586 | 1.586 | 0.000 ( +0.0% ) | 7.44 | 7.40 | +0.5% | 2.351 | 2.300 |
    | 2500.1 | 2.194 | 2.194 | 0.000 ( +0.0% ) | 5.33 | 5.22 | +2.2% | 2.058 | 1.982 |
    | 2500.2 | 2.310 | 2.310 | 0.000 ( +0.0% ) | 6.07 | 5.99 | +1.4% | 1.973 | 1.890 |
    | 2500.21 | 1.186 | 1.186 | 0.000 ( +0.0% ) | 4.35 | 4.32 | +0.8% | 2.258 | 2.189 |
    | 2500.211 | 1.550 | 1.550 | 0.000 ( +0.0% ) | 3.77 | 3.59 | +5.0% | 2.335 | 2.210 |
    | 2500.3 | 2.061 | 2.061 | 0.000 ( +0.0% ) | 12.68 | 12.25 | +3.5% | 1.961 | 1.959 |
    | 2500.301 | 2.634 | 2.634 | 0.000 ( +0.0% ) | 9.69 | 9.67 | +0.3% | 1.947 | 1.823 |
    | 2500.31 | 1.264 | 1.264 | 0.000 ( +0.0% ) | 20.00 | 18.93 | +5.6% | 2.352 | 2.224 |
    | 2500.311 | 1.638 | 1.638 | 0.000 ( +0.0% ) | 12.74 | 11.36 | +12.1% | 2.404 | 2.253 |
    | 2500.312 | 7.159 | 7.159 | 0.000 ( +0.0% ) | 1.46 | 1.34 | +8.8% | 1.688 | 1.684 |
    | 2500.313 | 1.564 | 1.564 | 0.000 ( +0.0% ) | 6.72 | 6.28 | +7.1% | 1.042 | 1.034 |
    | 2500.314 | 1.161 | 1.161 | 0.000 ( +0.0% ) | 13.19 | 12.26 | +7.6% | 2.058 | 2.045 |
    | 2500.315 | 1.759 | 1.759 | 0.000 ( +0.0% ) | 12.74 | 12.14 | +4.9% | 2.307 | 2.300 |
    | 2500.4 | 2.061 | 2.061 | 0.000 ( +0.0% ) | 12.24 | 11.76 | +4.1% | 1.845 | 1.816 |
    | 2500.401 | 1.818 | 1.818 | 0.000 ( +0.0% ) | 10.69 | 9.45 | +13.2% | 1.806 | 1.691 |
    | 2500.402 | 2.634 | 2.634 | 0.000 ( +0.0% ) | 10.31 | 9.19 | +12.2% | 1.916 | 1.909 |
    | 2500.5 | 19.575 | 19.575 | 0.000 ( +0.0% ) | 1.33 | 1.16 | +14.5% | 1.352 | 1.118 |

@vlimant
Copy link
Contributor

vlimant commented Mar 4, 2024

+1

@srimanob
Copy link
Contributor

srimanob commented Mar 8, 2024

+Upgrade

@AdrianoDee
Copy link
Contributor

+pdmv

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @sextonkennedy, @antoniovilela, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)

@rappoccio
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit 29666e0 into cms-sw:master Mar 12, 2024
13 checks passed
vlimant added a commit to vlimant/cmssw that referenced this pull request Mar 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants