MTD reconstruction: introduction of mass-dependent uncertainty on track time of flight

[noepalm]

PR description:

The evaluation of the uncertainty on the time of flight of tracks from the MTD layer to the beamline has been introduced in the TrackExtenderWithMTD module. As such uncertainty depends on particle mass, it has been estimated under each of the three mass hypotheses considered (pion, kaon, proton).
Implementation and use cases were discussed in detail in the following MTD DPG meeting.

PR validation:

The PR has been tested on workflows 24834.0 TTbar14TeV and 24840.0 MinBias14TeV, producing results consistent with expectations as shown in the presentation above.

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-43918/38769

• This PR adds an extra 48KB to repository

• Found files with invalid states:

  • Validation/MtdValidation/runall-report-step123-.log:
    • Added: 1fc4a38
    • Deleted: 03d837d

• There are other open Pull requests which might conflict with changes you have proposed:

  • File Validation/MtdValidation/plugins/MtdTracksValidation.cc modified in PR(s): [MTD simulation, validation]: implementation of MTD clusters association maps #43913

[cmsbuild]

A new Pull Request was created by @noepalm (Spizor) for master.

It involves the following packages:

• RecoMTD/TrackExtender (reconstruction, upgrade)
• Validation/MtdValidation (dqm)

@antoniovagnerini, @nothingface0, @cmsbuild, @rvenditti, @jfernan2, @mandrenguyen, @tjavaid, @syuvivida, @subirsarkar, @srimanob can you please review it and eventually sign? Thanks.
@fabiocos, @missirol this is something you requested to watch as well.
@rappoccio, @antoniovilela, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

[fabiocos]

please test

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-2491ca/37307/summary.html
COMMIT: b3af544
CMSSW: CMSSW_14_1_X_2024-02-08-1100/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/43918/37307/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

• You potentially added 34 lines to the logs
• ROOTFileChecks: Some differences in event products or their sizes found
• Reco comparison results: 50 differences found in the comparisons
• DQMHistoTests: Total files compared: 48
• DQMHistoTests: Total histograms compared: 3248626
• DQMHistoTests: Total failures: 3
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3248601
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 11.363999999999999 KiB( 47 files compared)
• DQMHistoSizes: changed ( 23234.0,... ): 1.894 KiB MTD/Tracks
• Checked 200 log files, 161 edm output root files, 48 DQM output files
• TriggerResults: no differences found

[fabiocos]

@noepalm the static check output reports a warning

https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-2491ca/37307/llvm-analysis/

not caused by this PR. But as it appears simple to fix, this PR it is the opportunity to do it. Could you please take a look and update accordingly the code?

[fabiocos]

type mtd

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-43918/38807

• This PR adds an extra 144KB to repository

• Found files with invalid states:

  • Validation/MtdValidation/runall-report-step123-.log:
    • Added: 1fc4a38
    • Deleted: 03d837d

• There are other open Pull requests which might conflict with changes you have proposed:

  • File Validation/MtdValidation/plugins/MtdTracksValidation.cc modified in PR(s): [MTD simulation, validation]: implementation of MTD clusters association maps #43913, Correction of MTD ETL Validation: hits accumulation on a pixel-basis #43928

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-43918/38823

• This PR adds an extra 32KB to repository

• There are other open Pull requests which might conflict with changes you have proposed:

  • File Validation/MtdValidation/plugins/MtdTracksValidation.cc modified in PR(s): [MTD simulation, validation]: implementation of MTD clusters association maps #43913, Correction of MTD ETL Validation: hits accumulation on a pixel-basis #43928

[cmsbuild]

Pull request #43918 was updated. @rvenditti, @nothingface0, @jfernan2, @srimanob, @subirsarkar, @cmsbuild, @mandrenguyen, @antoniovagnerini, @tjavaid, @syuvivida can you please check and sign again.

[iarspider]

please test

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-2491ca/37406/summary.html
COMMIT: d9d5e83
CMSSW: CMSSW_14_1_X_2024-02-12-2300/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/43918/37406/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

• You potentially removed 26 lines from the logs
• ROOTFileChecks: Some differences in event products or their sizes found
• Reco comparison results: 35 differences found in the comparisons
• DQMHistoTests: Total files compared: 48
• DQMHistoTests: Total histograms compared: 3248554
• DQMHistoTests: Total failures: 0
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3248532
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 6.324000000000001 KiB( 47 files compared)
• DQMHistoSizes: changed ( 23234.0,... ): 1.054 KiB MTD/Tracks
• Checked 200 log files, 161 edm output root files, 48 DQM output files
• TriggerResults: no differences found

[fabiocos]

I am fine on the MTD side with this PR

[jfernan2]

+1

[fabiocos]

@cms-sw/dqm-l2 @cms-sw/upgrade-l2 any comment?

[srimanob]

+Upgrade

[tjavaid]

+1

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @sextonkennedy, @antoniovilela, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)

[rappoccio]

+1