[MTD simulation, validation]: implementation of MTD clusters association maps

[martinamalberti]

PR description:

This pull request implements association maps for MTD reco clusters to MtdSimLayerClusters and MtdSimLayerClusters to Tracking Particles. A summary was given at the last MTD DPG meeting [1].

The MTD clusters associations maps are implemented in the following packages:
SimDataFormats/Associations
SimFastTiming/MtdAssociationProducers
and used in the Validation/MtdValidation package.

Some changes were made also to the following packages:

• SimDataFormats/CaloAnalysis: addition of new members (positions_, idOffset_ ) and methods to the MtdSimCluster class. Class version updated accordingly.
• SimGeneral/CaloAnalysis/plugins/MtdTruthAccumulator.cc updated to:
  1. produce all the MTD sim clusters, not only those from direct hits in the MTD, relying on the BTL sim hits categorization implemented by F. Cossutti in https://github.com/cms-sw/cmssw/blob/master/SimG4CMS/Forward/interface/MtdSD.h;
  2. store the local position of the MTD sim cluster estimated from the true position of the sim hits.
• Geometry/MTDGeometryBuilder: added a new method to the MTDGeomUtil class to return the sensor module DetId starting from the crystal BTLDetId.

[1] https://indico.cern.ch/event/1376660/#6-mtd-clusters-association-map

PR validation:

The code was tested on the workflows:
24807.0 (SingleMuPt10)
24906.0 (SinglePiFlatPt0p7To10)
and produces the expected results.

[cmsbuild]

cms-bot internal usage

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-43913/38763

• This PR adds an extra 76KB to repository

• There are other open Pull requests which might conflict with changes you have proposed:

  • File SimDataFormats/Associations/src/classes_def.xml modified in PR(s): move dictionaries next to typedefs for TrackingParticle associations #37507
  • File SimDataFormats/CaloAnalysis/src/classes_def.xml modified in PR(s): SimTauCPLink - Adding a link between GenTaus and CaloParticles #43468

[cmsbuild]

A new Pull Request was created by @martinamalberti (Martina Malberti) for master.

It involves the following packages:

• Geometry/MTDGeometryBuilder (geometry, upgrade)
• SimDataFormats/Associations (simulation)
• SimDataFormats/CaloAnalysis (simulation)
• SimFastTiming/MtdAssociatorProducers (****)
• SimGeneral/CaloAnalysis (simulation)
• Validation/Configuration (dqm, simulation)
• Validation/MtdValidation (dqm)

The following packages do not have a category, yet:

SimFastTiming/MtdAssociatorProducers
Please create a PR for https://github.com/cms-sw/cms-bot/blob/master/categories_map.py to assign category

@bsunanda, @Dr15Jones, @rvenditti, @tjavaid, @subirsarkar, @syuvivida, @antoniovagnerini, @cmsbuild, @nothingface0, @civanch, @srimanob, @mdhildreth, @makortel can you please review it and eventually sign? Thanks.
@bsunanda, @slomeo, @apsallid, @ReyerBand, @felicepantaleo, @thomreis, @youyingli, @fabiocos, @missirol, @rovere, @wang0jin this is something you requested to watch as well.
@antoniovilela, @rappoccio, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

[fabiocos]

please test

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-c21e5b/37305/summary.html
COMMIT: 030c808
CMSSW: CMSSW_14_1_X_2024-02-08-1100/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/43913/37305/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

• You potentially added 87 lines to the logs
• Reco comparison results: 59 differences found in the comparisons
• DQMHistoTests: Total files compared: 48
• DQMHistoTests: Total histograms compared: 3248626
• DQMHistoTests: Total failures: 1210
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3247394
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 119.90400000000002 KiB( 47 files compared)
• DQMHistoSizes: changed ( 23234.0,... ): 12.777 KiB MTD/BTL
• DQMHistoSizes: changed ( 23234.0,... ): 7.207 KiB MTD/ETL
• Checked 200 log files, 161 edm output root files, 48 DQM output files
• TriggerResults: no differences found

[fabiocos]

@cms-sw/core-l2 further comments/suggestions? @cms-sw/dqm-l2 any comment?

[martinamalberti]

@cms-sw/core-l2 , @cms-sw/dqm-l2: any further comment on this PR?

[tjavaid]

Hi @martinamalberti and @fabiocos , sorry for a bit late response. However, I cannot access e.g. Comparison failed (although I can see in the Summary). Is there a need to re-trigger the tests?

[fabiocos]

please test

@tjavaid the output is no more available after one week...

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-c21e5b/37810/summary.html
COMMIT: 1cebff7
CMSSW: CMSSW_14_1_X_2024-02-29-1100/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/43913/37810/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

• You potentially added 18 lines to the logs
• Reco comparison results: 54 differences found in the comparisons
• DQMHistoTests: Total files compared: 49
• DQMHistoTests: Total histograms compared: 3338784
• DQMHistoTests: Total failures: 30
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3338732
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 120.264 KiB( 48 files compared)
• DQMHistoSizes: changed ( 23234.0,... ): 12.837 KiB MTD/BTL
• DQMHistoSizes: changed ( 23234.0,... ): 7.207 KiB MTD/ETL
• Checked 205 log files, 166 edm output root files, 49 DQM output files
• TriggerResults: no differences found

[makortel]

This struct SimDataFormats_Associations { ... }; could be removed (those have been unnecessary for a long time), but at this stage it could be left for a future PR.

[fabiocos]

@makortel do you mean the whole block lines 23 - 66? We may add small PR after this one is integrated

[makortel]

do you mean the whole block lines 23 - 66?

Yes.

We may add small PR after this one is integrated

Thanks!

[makortel]

+core

[tjavaid]

+1

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @sextonkennedy, @rappoccio, @antoniovilela (and backports should be raised in the release meeting by the corresponding L2)

[antoniovilela]

+1