MTD reconstruction: propagation of track time of flight uncertainty to vertex reconstruction #44562

noepalm · 2024-03-27T17:59:01Z

PR description:

Following up on PR #43918, the newly introduced mass-dependent uncertainty on the time of flight of tracks has been propagated to the following reconstruction steps. This additional contribution to track time uncertainty is now:

included in the calculation for the MTD hit-to-track matching $\chi^2_t$ in TrackExtenderWithMTD;
has been included in theVertexTimeAlgorithmFromTracksPID vertex time algorithm for the 3D+t step, which now uses a different track time uncertainty for each mass hypothesis;
has been added to the total track time uncertainty in TOFPIDProducer (used in the 4D vertex reconstruction step through DAClusterizerInZT and VertexTimeAlgorithmLegacy4D).

Furthermore, an improved definition of vertex time uncertainty has been introduced in both VertexTimeAlgorithmFromTracksPID and VertexTimeAlgorithmLegacy4D.
All the mentioned modifications have been discussed and presented in MTD DPG meetings (1, 2).

PR validation:

The PR has been validated on TTbar14TeV and TTbar14TeV+PU200 samples, producing results documented in the two aforementioned presentations.

… time uncertainty and vertex reconstruction + redefined vertex time uncertainty in both 3D+t and 4D step of vertex reconstruction

…lculation of hit-track compatibility timeChi2

cmsbuild · 2024-03-27T17:59:26Z

cms-bot internal usage

cmsbuild · 2024-03-27T18:05:33Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-44562/39705

This PR adds an extra 40KB to repository

cmsbuild · 2024-03-27T18:05:59Z

A new Pull Request was created by @noepalm for master.

It involves the following packages:

RecoMTD/TimingIDTools (upgrade, reconstruction)
RecoMTD/TrackExtender (upgrade, reconstruction)
RecoVertex/PrimaryVertexProducer (reconstruction)

@subirsarkar, @mandrenguyen, @cmsbuild, @srimanob, @jfernan2 can you please review it and eventually sign? Thanks.
@mtosi, @JanFSchulte, @GiacomoSguazzoni, @missirol, @rovere, @fabiocos, @mmusich, @dgulhan, @VourMa, @VinInn this is something you requested to watch as well.
@sextonkennedy, @rappoccio, @antoniovilela you are the release manager for this.

cms-bot commands are listed here

fabiocos · 2024-03-28T07:50:13Z

please test

cmsbuild · 2024-03-28T10:54:07Z

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-4a2012/38479/summary.html
COMMIT: 3d658f8
CMSSW: CMSSW_14_1_X_2024-03-27-2300/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/44562/38479/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

You potentially added 105 lines to the logs
Reco comparison results: 187 differences found in the comparisons
DQMHistoTests: Total files compared: 48
DQMHistoTests: Total histograms compared: 3297437
DQMHistoTests: Total failures: 1753
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 3295664
DQMHistoTests: Total skipped: 20
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 0.0 KiB( 47 files compared)
Checked 202 log files, 165 edm output root files, 48 DQM output files
TriggerResults: no differences found

jfernan2 · 2024-04-02T13:14:15Z

enable profiling

jfernan2 · 2024-04-02T13:15:16Z

please test
(checking if some extra time is being introduced, sorry for the duplicated test)

jfernan2 · 2024-04-03T08:40:58Z

please abort
(test seems stuck)

cmsbuild · 2024-04-09T14:20:14Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-44562/39872

This PR adds an extra 36KB to repository

cmsbuild · 2024-04-09T14:20:35Z

Pull request #44562 was updated. @subirsarkar, @srimanob, @mandrenguyen, @jfernan2, @cmsbuild can you please check and sign again.

jfernan2 · 2024-04-09T15:04:59Z

please test

cmsbuild · 2024-04-09T18:27:58Z

-1

Failed Tests: RelVals-INPUT
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-4a2012/38713/summary.html
COMMIT: d293345
CMSSW: CMSSW_14_1_X_2024-04-09-1100/el8_amd64_gcc12
Additional Tests: PROFILING
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/44562/38713/install.sh to create a dev area with all the needed externals and cmssw changes.

RelVals-INPUT

2500.3232500.323_l1DPGNANO130Xrun3/step2_l1DPGNANO130Xrun3.log

Comparison Summary

Summary:

You potentially removed 17 lines from the logs
Reco comparison results: 186 differences found in the comparisons
DQMHistoTests: Total files compared: 48
DQMHistoTests: Total histograms compared: 3308887
DQMHistoTests: Total failures: 1756
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 3307111
DQMHistoTests: Total skipped: 20
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 0.0 KiB( 47 files compared)
Checked 202 log files, 165 edm output root files, 48 DQM output files
TriggerResults: no differences found

jfernan2 · 2024-04-10T14:36:11Z

please test

cmsbuild · 2024-04-10T17:45:42Z

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-4a2012/38746/summary.html
COMMIT: d293345
CMSSW: CMSSW_14_1_X_2024-04-10-1100/el8_amd64_gcc12
Additional Tests: PROFILING
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/44562/38746/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

You potentially added 85 lines to the logs
Reco comparison results: 179 differences found in the comparisons
DQMHistoTests: Total files compared: 48
DQMHistoTests: Total histograms compared: 3316263
DQMHistoTests: Total failures: 1753
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 3314490
DQMHistoTests: Total skipped: 20
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 0.0 KiB( 47 files compared)
Checked 202 log files, 165 edm output root files, 48 DQM output files
TriggerResults: no differences found

jfernan2 · 2024-04-11T13:00:49Z

+1

Failing workflow seems related to L1T

FYI: @cms-sw/l1-l2

https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-4a2012/38713/runTheMatrixINPUT-results/2500.323_l1DPGNANO130Xrun3/step2_l1DPGNANO130Xrun3.log

srimanob · 2024-04-12T09:31:44Z

+Upgrade

cmsbuild · 2024-04-12T09:32:05Z

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @sextonkennedy, @antoniovilela, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)

rappoccio · 2024-04-12T20:20:20Z

+1

noepalm added 4 commits March 20, 2024 16:09

Propagated track sigma(TOF) on MTD hit-to-track matching, final track…

52f2b56

… time uncertainty and vertex reconstruction + redefined vertex time uncertainty in both 3D+t and 4D step of vertex reconstruction

Updated array from C-style array to std::array

c74aa70

Added kMixd calculation strategy for sigma(TOF), set as default in ca…

d69c2bd

…lculation of hit-track compatibility timeChi2

Code checks && format

3d658f8

cmsbuild added this to the CMSSW_14_1_X milestone Mar 27, 2024

cmsbuild added reconstruction-pending pending-signatures tests-pending orp-pending upgrade-pending code-checks-pending tracking labels Mar 27, 2024

cmsbuild added code-checks-approved and removed code-checks-pending labels Mar 27, 2024

cmsbuild added tests-started and removed tests-pending labels Mar 28, 2024

cmsbuild added tests-approved and removed tests-started labels Mar 28, 2024

cmsbuild added tests-started and removed tests-approved labels Apr 2, 2024

cmsbuild added tests-pending and removed tests-started labels Apr 3, 2024

cmsbuild added code-checks-approved and removed code-checks-pending labels Apr 9, 2024

cmsbuild added tests-started and removed tests-pending labels Apr 9, 2024

cmsbuild added tests-rejected and removed tests-started labels Apr 9, 2024

cmsbuild added tests-started and removed tests-rejected labels Apr 10, 2024

cmsbuild added tests-approved and removed tests-started labels Apr 10, 2024

cmsbuild added reconstruction-approved and removed reconstruction-pending labels Apr 11, 2024

cmsbuild added fully-signed upgrade-approved and removed pending-signatures upgrade-pending labels Apr 12, 2024

cmsbuild added orp-approved and removed orp-pending labels Apr 12, 2024

cmsbuild merged commit 73ba03a into cms-sw:master Apr 12, 2024
17 checks passed

fabiocos mentioned this pull request Jun 20, 2024

Use of MTD time in reconstruction: fixes and update #45279

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

MTD reconstruction: propagation of track time of flight uncertainty to vertex reconstruction #44562

MTD reconstruction: propagation of track time of flight uncertainty to vertex reconstruction #44562

noepalm commented Mar 27, 2024

cmsbuild commented Mar 27, 2024 •

edited

Loading

cmsbuild commented Mar 27, 2024

cmsbuild commented Mar 27, 2024

fabiocos commented Mar 28, 2024

cmsbuild commented Mar 28, 2024

jfernan2 commented Apr 2, 2024

jfernan2 commented Apr 2, 2024

jfernan2 commented Apr 3, 2024

cmsbuild commented Apr 9, 2024

cmsbuild commented Apr 9, 2024

jfernan2 commented Apr 9, 2024

cmsbuild commented Apr 9, 2024

jfernan2 commented Apr 10, 2024

cmsbuild commented Apr 10, 2024

jfernan2 commented Apr 11, 2024

srimanob commented Apr 12, 2024

cmsbuild commented Apr 12, 2024

rappoccio commented Apr 12, 2024

MTD reconstruction: propagation of track time of flight uncertainty to vertex reconstruction #44562

MTD reconstruction: propagation of track time of flight uncertainty to vertex reconstruction #44562

Conversation

noepalm commented Mar 27, 2024

PR description:

PR validation:

cmsbuild commented Mar 27, 2024 • edited Loading

cmsbuild commented Mar 27, 2024

cmsbuild commented Mar 27, 2024

fabiocos commented Mar 28, 2024

cmsbuild commented Mar 28, 2024

Comparison Summary

jfernan2 commented Apr 2, 2024

jfernan2 commented Apr 2, 2024

jfernan2 commented Apr 3, 2024

cmsbuild commented Apr 9, 2024

cmsbuild commented Apr 9, 2024

jfernan2 commented Apr 9, 2024

cmsbuild commented Apr 9, 2024

RelVals-INPUT

Comparison Summary

jfernan2 commented Apr 10, 2024

cmsbuild commented Apr 10, 2024

Comparison Summary

jfernan2 commented Apr 11, 2024

srimanob commented Apr 12, 2024

cmsbuild commented Apr 12, 2024

rappoccio commented Apr 12, 2024

cmsbuild commented Mar 27, 2024 •

edited

Loading