Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CepGen 1.2.1 #9033

Merged
merged 1 commit into from
Feb 26, 2024
Merged

Conversation

forthommel
Copy link
Contributor

@forthommel forthommel commented Feb 26, 2024

This PR bumps the CepGen version to 1.2.1.
It allows to fix the issue observed with the production architecture currently using ROOT version 6.26, along with introducing a few patches to simplify the BuildFile of the new GeneratorInterface/CepGenInterface introduced in cms-sw/cmssw#44072.

Changelog available at https://github.com/cepgen/cepgen/releases/tag/1.2.1.

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @forthommel for branch IB/CMSSW_14_1_X/master.

@iarspider, @aandvalenzuela, @cmsbuild, @smuzaffar can you please review it and eventually sign? Thanks.
@sextonkennedy, @antoniovilela, @rappoccio you are the release manager for this.
cms-bot commands are listed here

@cmsbuild
Copy link
Contributor

cmsbuild commented Feb 26, 2024

cms-bot internal usage

@aandvalenzuela
Copy link
Contributor

please test

@aandvalenzuela
Copy link
Contributor

please test for CMSSW_14_1_ROOT626_X

@cmsbuild
Copy link
Contributor

-1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-e4c8db/37686/summary.html
COMMIT: 6542edb
CMSSW: CMSSW_14_1_ROOT626_X_2024-02-21-2300/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmsdist/9033/37686/install.sh to create a dev area with all the needed externals and cmssw changes.

External Build

I found compilation error when building:

warning: line 37: It's not recommended to have unversioned Obsoletes: Obsoletes: lcg+root+6.26.15-8bed6ed430dfd7eef1689cbecd463247
warning: Macro expanded in comment on line 365: %{pkginstroot}/lib

warning: Macro expanded in comment on line 366: %{pkginstroot}

error: line 383: Unknown tag: <<<<<<< HEAD
error: query of specfile /data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/tmp/tmpspec-root failed, can't parse
Traceback (most recent call last):
  File "./pkgtools/cmsBuild", line 4777, in 
    build(opts, args[1:], PKGFactory)
  File "./pkgtools/cmsBuild", line 3984, in build


@forthommel
Copy link
Contributor Author

This last error on ROOT626 does not seem to be related to this PR.

@aandvalenzuela
Copy link
Contributor

test parameters:

  • full_cmssw = true

@aandvalenzuela
Copy link
Contributor

please test for CMSSW_14_1_ROOT626_X

@cmsbuild
Copy link
Contributor

-1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-e4c8db/37689/summary.html
COMMIT: 6542edb
CMSSW: CMSSW_14_1_ROOT626_X_2024-02-21-2300/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmsdist/9033/37689/install.sh to create a dev area with all the needed externals and cmssw changes.

External Build

I found compilation error when building:

warning: line 37: It's not recommended to have unversioned Obsoletes: Obsoletes: lcg+root+6.26.15-8bed6ed430dfd7eef1689cbecd463247
warning: Macro expanded in comment on line 365: %{pkginstroot}/lib

warning: Macro expanded in comment on line 366: %{pkginstroot}

error: line 383: Unknown tag: <<<<<<< HEAD
error: query of specfile /data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/tmp/tmpspec-root failed, can't parse
Traceback (most recent call last):
  File "./pkgtools/cmsBuild", line 4777, in 
    build(opts, args[1:], PKGFactory)
  File "./pkgtools/cmsBuild", line 3984, in build


@aandvalenzuela
Copy link
Contributor

please test for CMSSW_14_1_ROOT626_X

  • Let's see if the issue is solved

@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-e4c8db/37684/summary.html
COMMIT: 6542edb
CMSSW: CMSSW_14_1_X_2024-02-25-2300/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmsdist/9033/37684/install.sh to create a dev area with all the needed externals and cmssw changes.

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:

You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-e4c8db/37684/git-recent-commits.json
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-e4c8db/37684/git-merge-result

Comparison Summary

Summary:

@aandvalenzuela
Copy link
Contributor

@forthommel sorry for the back and forth, it seems ROOT626 built fine now

@forthommel
Copy link
Contributor Author

No worry, @aandvalenzuela! Glad to see this little patch was enough to fix it.

@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-e4c8db/37690/summary.html
COMMIT: 6542edb
CMSSW: CMSSW_14_1_ROOT626_X_2024-02-21-2300/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmsdist/9033/37690/install.sh to create a dev area with all the needed externals and cmssw changes.

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:

You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-e4c8db/37690/git-recent-commits.json
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-e4c8db/37690/git-merge-result

Comparison Summary

Summary:

@aandvalenzuela aandvalenzuela merged commit cea4156 into cms-sw:IB/CMSSW_14_1_X/master Feb 26, 2024
16 checks passed
@forthommel forthommel deleted the patch-1 branch February 26, 2024 20:42
@aandvalenzuela
Copy link
Contributor

Just to confirm, ROOT 6.26 IBs are working fine again! Thanks @forthommel :)

@forthommel
Copy link
Contributor Author

Fantastic! Sorry for the extra hassle, @aandvalenzuela ! And thanks for your help tracking down the issue to this nasty versioning bug!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants