Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CepGen generator interface #44072

Merged
merged 2 commits into from
Feb 29, 2024
Merged

Conversation

forthommel
Copy link
Contributor

@forthommel forthommel commented Feb 24, 2024

PR description:

This PR introduces an interface to the CepGen central exclusive processes event generator described in Comput. Phys. Commun. 271 (2022), and introduced at a CMS-PH generator meeting last October.

It is shipped with generator fragments for a LPAIR and a PPtoFF single-dissociative generation. The earlier also demonstrates the interfacing of Pythia 6 for the fragmentation of dissociative beam remnants into a hadronic shower.

Requires CepGen v1.2.0, added to cmsdist in cms-sw/cmsdist#9030.

PR validation:

Shipped in generator fragments seem to be producing something consistent :-)

cmsDriver.py Configuration/Generator/python/CepGen_pptoff_GamGamToLL_singlediss_13TeV_cfi.py --conditions auto:run2_mc -s GEN --datatier GEN -n 10 --eventcontent RAWSIM --no_exec
cmsDriver.py Configuration/Generator/python/CepGen_LPAIR_GamGamToLL_singlediss_13TeV_cfi.py --conditions auto:run2_mc -s GEN --datatier GEN -n 10 --eventcontent RAWSIM --no_exec

@cmsbuild
Copy link
Contributor

cmsbuild commented Feb 24, 2024

cms-bot internal usage

@cmsbuild
Copy link
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-44072/39033

  • This PR adds an extra 36KB to repository

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @forthommel for master.

It involves the following packages:

  • Configuration/Generator (generators)
  • GeneratorInterface/CepGenInterface (****)

The following packages do not have a category, yet:

GeneratorInterface/CepGenInterface
Please create a PR for https://github.com/cms-sw/cms-bot/blob/master/categories_map.py to assign category

@mkirsano, @SiewYan, @GurpreetSinghChahal, @cmsbuild, @menglu21, @alberto-sanchez, @bbilin can you please review it and eventually sign? Thanks.
@missirol, @fabiocos, @mkirsano, @Martin-Grunewald, @alberto-sanchez this is something you requested to watch as well.
@sextonkennedy, @rappoccio, @antoniovilela you are the release manager for this.

cms-bot commands are listed here

@bbilin
Copy link
Contributor

bbilin commented Feb 24, 2024

@cmsbuild please test

@cmsbuild
Copy link
Contributor

-1

Failed Tests: HeaderConsistency
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-d2cfa2/37658/summary.html
COMMIT: a7e3d01
CMSSW: CMSSW_14_1_X_2024-02-24-1100/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/44072/37658/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • You potentially added 4 lines to the logs
  • Reco comparison results: 49 differences found in the comparisons
  • DQMHistoTests: Total files compared: 48
  • DQMHistoTests: Total histograms compared: 3245365
  • DQMHistoTests: Total failures: 3
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3245340
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 47 files compared)
  • Checked 200 log files, 161 edm output root files, 48 DQM output files
  • TriggerResults: no differences found

@cmsbuild
Copy link
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-44072/39036

  • This PR adds an extra 32KB to repository

@cmsbuild
Copy link
Contributor

Pull request #44072 was updated. @alberto-sanchez, @mkirsano, @cmsbuild, @bbilin, @SiewYan, @GurpreetSinghChahal, @menglu21 can you please check and sign again.

@bbilin
Copy link
Contributor

bbilin commented Feb 25, 2024

@cmsbuild please test

@cmsbuild
Copy link
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-44072/39271

  • This PR adds an extra 36KB to repository

@cmsbuild
Copy link
Contributor

Pull request #44072 was updated. @mkirsano, @bbilin, @alberto-sanchez, @GurpreetSinghChahal, @cmsbuild, @SiewYan, @menglu21 can you please check and sign again.

forthommel added a commit to forthommel/cms-bot that referenced this pull request Feb 28, 2024
Added `GeneratorInterface/CepGenInterface` to the `generators` playground (in link with cms-sw/cmssw#44072)
@bbilin
Copy link
Contributor

bbilin commented Feb 28, 2024

@cmsbuild please test

@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-d2cfa2/37797/summary.html
COMMIT: 660340f
CMSSW: CMSSW_14_1_X_2024-02-28-1100/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/44072/37797/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • You potentially added 102 lines to the logs
  • Reco comparison results: 43 differences found in the comparisons
  • DQMHistoTests: Total files compared: 48
  • DQMHistoTests: Total histograms compared: 3011576
  • DQMHistoTests: Total failures: 3
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3011551
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 47 files compared)
  • Checked 200 log files, 161 edm output root files, 48 DQM output files
  • TriggerResults: no differences found

@bbilin
Copy link
Contributor

bbilin commented Feb 29, 2024

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @antoniovilela, @rappoccio, @sextonkennedy (and backports should be raised in the release meeting by the corresponding L2)

@rappoccio
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit c7d2da2 into cms-sw:master Feb 29, 2024
11 checks passed
@forthommel forthommel deleted the cepgen_integration-14_1_X branch February 29, 2024 15:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants