Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move SoA collections ROOT read rules to classes.cc #44021

Merged
merged 4 commits into from
Feb 21, 2024

Conversation

fwyzard
Copy link
Contributor

@fwyzard fwyzard commented Feb 20, 2024

PR description:

Technical, no changes expected.

Move the ROOT read rules of the SoA host collections for the ECAL digis, uncalibrated rechits, and PF rechits from classes_def.xml to classes.cc.

PR validation:

None.

Backport status

To be backported to 14.0.x for 2024 data taking.

Move the ROOT read rules for the ECAL digis SoA host collection from
classes_def.xml to classes.cc.
Move the ROOT read rules for the ECAL uncalibrated rechits SoA host collection
from classes_def.xml to classes.cc.
Move the ROOT read rules for the PF rechits SoA host collections from
classes_serial_def.xml to classes_serial.cc.
@fwyzard
Copy link
Contributor Author

fwyzard commented Feb 20, 2024

enable gpu

@fwyzard
Copy link
Contributor Author

fwyzard commented Feb 20, 2024

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Feb 20, 2024

cms-bot internal usage

@fwyzard fwyzard changed the title Move SoA collections ROOT read rules from classes_def.xml to classes.cc Move SoA collections ROOT read rules to classes.cc Feb 20, 2024
@fwyzard
Copy link
Contributor Author

fwyzard commented Feb 20, 2024

FYI @thomreis @hatakeyamak @jsamudio @waredjeb

@fwyzard
Copy link
Contributor Author

fwyzard commented Feb 20, 2024

type ecal

@fwyzard
Copy link
Contributor Author

fwyzard commented Feb 20, 2024

type pf

@cmsbuild
Copy link
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-44021/38951

  • This PR adds an extra 28KB to repository

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @fwyzard for master.

It involves the following packages:

  • DataFormats/EcalDigi (simulation)
  • DataFormats/EcalRecHit (reconstruction)
  • DataFormats/ParticleFlowReco (reconstruction)

@civanch, @jfernan2, @mandrenguyen, @mdhildreth can you please review it and eventually sign? Thanks.
@hatakeyamak, @ReyerBand, @argiro, @rovere, @missirol, @rchatter, @wang0jin, @lgray, @thomreis this is something you requested to watch as well.
@sextonkennedy, @antoniovilela, @rappoccio you are the release manager for this.

cms-bot commands are listed here

@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-8fb213/37565/summary.html
COMMIT: 23506e8
CMSSW: CMSSW_14_1_X_2024-02-19-2300/el8_amd64_gcc12
Additional Tests: GPU
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/44021/37565/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 48 differences found in the comparisons
  • DQMHistoTests: Total files compared: 48
  • DQMHistoTests: Total histograms compared: 3248389
  • DQMHistoTests: Total failures: 3
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3248364
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 47 files compared)
  • Checked 200 log files, 161 edm output root files, 48 DQM output files
  • TriggerResults: no differences found

GPU Comparison Summary

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 35 differences found in the comparisons
  • DQMHistoTests: Total files compared: 3
  • DQMHistoTests: Total histograms compared: 39740
  • DQMHistoTests: Total failures: 1064
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 38676
  • DQMHistoTests: Total skipped: 0
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 2 files compared)
  • Checked 8 log files, 10 edm output root files, 3 DQM output files
  • TriggerResults: no differences found

@jfernan2
Copy link
Contributor

+1

@civanch
Copy link
Contributor

civanch commented Feb 20, 2024

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @sextonkennedy, @rappoccio, @antoniovilela (and backports should be raised in the release meeting by the corresponding L2)

@rappoccio
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit 3de3efa into cms-sw:master Feb 21, 2024
14 checks passed
@fwyzard fwyzard deleted the update_SoA_dictionaries_141x branch March 2, 2024 22:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants