Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improved unit tests in FWCore/Framework #44034

Merged
merged 1 commit into from
Feb 21, 2024
Merged

Improved unit tests in FWCore/Framework #44034

merged 1 commit into from
Feb 21, 2024

Conversation

Dr15Jones
Copy link
Contributor

PR description:

  • moved tests to catch framework
  • removed useless test
  • consolidated tests into one executable
  • moved test code out of .cc file

PR validation:

Code compiles and tests pass.

@cmsbuild cmsbuild added this to the CMSSW_14_1_X milestone Feb 20, 2024
@cmsbuild
Copy link
Contributor

cmsbuild commented Feb 20, 2024 •
edited
Loading

cms-bot internal usage

@cmsbuild
Copy link
Contributor

-code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-44034/38969

  • This PR adds an extra 40KB to repository

Code check has found code style and quality issues which could be resolved by applying following patch(s)

@Dr15Jones
Improved unit tests in FWCore/Framework
97a27fb 
- moved tests to catch framework
- removed useless test
- consolidated tests into one executable
- moved test code out of .cc file
@Dr15Jones Dr15Jones force-pushed the unittest_cleanup_FWCoreFramework branch from fb240e5 to 97a27fb Compare February 20, 2024 19:42
@Dr15Jones
Copy link
Contributor Author

please test

@cmsbuild
Copy link
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-44034/38971

  • This PR adds an extra 44KB to repository

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @Dr15Jones for master.

It involves the following packages:

  • FWCore/Framework (core)

@makortel, @Dr15Jones, @smuzaffar can you please review it and eventually sign? Thanks.
@makortel, @wddgit, @missirol this is something you requested to watch as well.
@sextonkennedy, @rappoccio, @antoniovilela you are the release manager for this.

cms-bot commands are listed here

@makortel makortel mentioned this pull request Feb 20, 2024
Closed
@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-f2df62/37589/summary.html
COMMIT: 97a27fb
CMSSW: CMSSW_14_1_X_2024-02-20-1100/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/44034/37589/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

@makortel
Copy link
Contributor

The usual

@makortel
Copy link
Contributor

+core

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @rappoccio, @antoniovilela, @sextonkennedy (and backports should be raised in the release meeting by the corresponding L2)

@rappoccio
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit 34c2769 into cms-sw:master Feb 21, 2024
11 checks passed
@Dr15Jones Dr15Jones deleted the unittest_cleanup_FWCoreFramework branch February 21, 2024 19:02
@cmsbuild cmsbuild mentioned this pull request Feb 22, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
code-checks-approved core-approved fully-signed orp-approved tests-approved
Projects
None yet
Milestone
CMSSW_14_1_X
Development

Successfully merging this pull request may close these issues.
4 participants
@Dr15Jones @cmsbuild @makortel @rappoccio