Muon POG NanoAOD v2 #43642

rbhattacharya04 · 2024-01-01T08:49:58Z

This PR adds a list of variables to the Muon collection for the custom Muon POG NanoAOD. A set of Trigger Object filterBits has also been added in a new section in Trigger Objects called "Muon POG" with Id - 1313.

This PR is opened to start the review for the approach to add the additional Trigger Object filterBits and it is not fully complete. Variables, corresponding to displaced Muon collection, will be added in later pushes.

cmsbuild · 2024-01-01T08:50:27Z

cms-bot internal usage

cmsbuild · 2024-01-01T08:58:36Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-43642/38302

This PR adds an extra 28KB to repository

cmsbuild · 2024-01-01T08:58:59Z

A new Pull Request was created by @rbhattacharya04 for master.

It involves the following packages:

PhysicsTools/NanoAOD (xpog)

@cmsbuild, @hqucms, @vlimant can you please review it and eventually sign? Thanks.
@AnnikaStein, @gpetruc this is something you requested to watch as well.
@antoniovilela, @rappoccio, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

vlimant · 2024-01-10T07:26:45Z

as you implement new features, please remember to include this custom nano with the autoNano syntax #42238 and think about adding a test workflow in the nano matrix

cmsbuild · 2024-01-23T14:37:58Z

-code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-43642/38507

ERROR: Unable to merge PR.

See log https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-43642/38507/cms-checkout-topic.log

cmsbuild · 2024-01-23T14:47:24Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-43642/38509

This PR adds an extra 32KB to repository
There are other open Pull requests which might conflict with changes you have proposed:
- File PhysicsTools/NanoAOD/python/autoNANO.py modified in PR(s): simplify MU-DPG custom nano configuration #43753

cmsbuild · 2024-02-19T14:38:44Z

Pull request #43642 was updated. @sunilUIET, @hqucms, @AdrianoDee, @srimanob, @miquork, @cmsbuild, @vlimant, @subirsarkar can you please check and sign again.

rbhattacharya04 · 2024-02-19T14:43:00Z

I have increased the precision for the GenParticle pt, eta, phi, which are needed for the Rochester corrections. You can go forward with the merging.

vlimant · 2024-02-20T08:48:00Z

please test

cmsbuild · 2024-02-20T11:41:43Z

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-6b55f5/37566/summary.html
COMMIT: 1977a60
CMSSW: CMSSW_14_1_X_2024-02-19-2300/el8_amd64_gcc12
Additional Tests: NANO
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/43642/37566/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

You potentially removed 103 lines from the logs
Reco comparison results: 61 differences found in the comparisons
DQMHistoTests: Total files compared: 48
DQMHistoTests: Total histograms compared: 3248389
DQMHistoTests: Total failures: 1192
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 3247175
DQMHistoTests: Total skipped: 22
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 0.0 KiB( 47 files compared)
Checked 200 log files, 161 edm output root files, 48 DQM output files
TriggerResults: no differences found

NANO Comparison Summary

Summary:

You potentially added 1 lines to the logs
Reco comparison results: 0 differences found in the comparisons
DQMHistoTests: Total files compared: 15
DQMHistoTests: Total histograms compared: 16430
DQMHistoTests: Total failures: 0
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 16430
DQMHistoTests: Total skipped: 0
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 0.0 KiB( 14 files compared)
Checked 38 log files, 18 edm output root files, 15 DQM output files

Nano size comparison Summary:

Nano ERROR: Missing ref/2500.314-size.json
Nano ERROR: Missing ref/2500.314-size.json
Nano ERROR: Missing ref/2500.401-size.json
Nano ERROR: Missing ref/2500.401-size.json
| Sample | kb/ev | ref kb/ev | diff kb/ev | ev/s/thd | ref ev/s/thd | diff rate | mem/thd | ref mem/thd |
| --- | --- | --- | --- | --- | --- | --- | --- | --- |
| 2500.0 | 2.551 | 2.551 | 0.000 ( +0.0% ) | 5.24 | 5.22 | +0.4% | 2.221 | 2.216 |
| 2500.001 | 2.700 | 2.700 | 0.000 ( +0.0% ) | 4.66 | 4.69 | -0.8% | 2.650 | 2.625 |
| 2500.002 | 2.641 | 2.641 | 0.000 ( +0.0% ) | 4.88 | 4.89 | -0.2% | 2.634 | 2.626 |
| 2500.01 | 1.322 | 1.322 | 0.000 ( +0.0% ) | 9.51 | 9.69 | -1.8% | 2.338 | 2.270 |
| 2500.011 | 1.745 | 1.745 | 0.000 ( +0.0% ) | 5.25 | 5.26 | -0.3% | 2.524 | 2.530 |
| 2500.012 | 1.586 | 1.586 | 0.000 ( +0.0% ) | 7.55 | 7.51 | +0.6% | 2.441 | 2.411 |
| 2500.1 | 2.194 | 2.194 | 0.000 ( +0.0% ) | 5.25 | 5.25 | +0.0% | 2.060 | 2.059 |
| 2500.2 | 2.310 | 2.310 | 0.000 ( +0.0% ) | 6.00 | 6.04 | -0.7% | 1.972 | 1.973 |
| 2500.21 | 1.185 | 1.185 | 0.000 ( +0.0% ) | 4.33 | 4.33 | -0.1% | 2.270 | 2.250 |
| 2500.211 | 1.549 | 1.549 | 0.000 ( +0.0% ) | 3.71 | 3.76 | -1.4% | 2.357 | 2.333 |
| 2500.3 | 2.060 | 2.060 | 0.000 ( +0.0% ) | 12.44 | 12.66 | -1.7% | 1.960 | 1.951 |
| 2500.31 | 1.257 | 1.257 | 0.000 ( +0.0% ) | 19.21 | 20.16 | -4.7% | 2.364 | 2.349 |
| 2500.311 | 1.646 | 1.646 | 0.000 ( +0.0% ) | 11.95 | 12.32 | -3.0% | 2.440 | 2.412 |
| 2500.312 | 7.159 | 7.159 | 0.000 ( +0.0% ) | 1.40 | 1.39 | +1.3% | 1.684 | 1.681 |
| 2500.313 | 1.564 | 1.564 | 0.000 ( +0.0% ) | 6.73 | 6.70 | +0.5% | 1.037 | 1.032 |
| 2500.4 | 2.060 | 2.060 | 0.000 ( +0.0% ) | 12.30 | 12.66 | -2.8% | 1.957 | 1.954 |
| 2500.5 | 19.575 | 19.575 | 0.000 ( +0.0% ) | 1.12 | 1.17 | -4.2% | 1.346 | 1.343 |

vlimant · 2024-02-20T13:45:49Z

+1

subirsarkar · 2024-02-20T14:53:01Z

+Upgrade

jordan-martins · 2024-02-21T04:07:37Z

Hi @cms-sw/pdmv-l2,
please review this PR and sign this -off as we want to have this to follow up the Nano v14 (as a MUO flavour, a-lá jmenano) for the DATA-taking and also for the upcoming PAG MC (all in 14_0_X and onwards). From the PPD side, this is ready to go in.
Best,
PPD

sunilUIET · 2024-02-21T04:29:37Z

+pdmv

cmsbuild · 2024-02-21T04:30:04Z

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @rappoccio, @antoniovilela, @sextonkennedy (and backports should be raised in the release meeting by the corresponding L2)

rappoccio · 2024-02-21T17:29:04Z

+1

vlimant · 2024-03-15T14:32:00Z

PhysicsTools/NanoAOD/python/autoNANO.py

@@ -28,6 +28,8 @@ def expandNanoMapping(seqList, mapping, key):
    # L1 flavours: add tables through customize, supposed to be combined with PHYS
    'L1' : {'customize': 'nanoL1TrigObjCustomize'},
    'L1FULL' : {'customize': 'nanoL1TrigObjCustomizeFull'},
+    # Muon POG flavours : add tables through customize, supposed to be combined with PHYS
+    'MUPOG' : {'customize' : 'PhysicsTools/NanoAOD/custom_muon_cff.PrepMuonCustomNanoAOD'},


Hello, I think it would have been wiser for me to spot that @PHYS should be added by default here, if you are never going to ask --step NANO:@MUPOG alone (i.e not including the @PHYS part. we might need a quick PR for this

@vlimant we were using always --step @phys+@MUPOG even in the relval_nano.py. I can make a quick PR to change this.

done in #44425

can you please have a look at #44428 ?

Hi @vlimant , I have posted a comment in #44428. The changes look fine to me. but please wait a little bit for other muon pog colleagues to confirm.

rbhattacharya04 added 5 commits November 6, 2023 16:38

Adding latest variables

6ff2721

Small change

6a676e1

Some minor fixes

3b0bfb2

TrigObj_filterBits for the Muon POG

e9adbdd

Clean up of the code

2a76746

cmsbuild added this to the CMSSW_14_0_X milestone Jan 1, 2024

cmsbuild added pending-signatures tests-pending orp-pending code-checks-pending xpog-pending labels Jan 1, 2024

cmsbuild added code-checks-approved and removed code-checks-pending labels Jan 1, 2024

Inclusion of the Muon POG Nano in autoNano

e72a8c7

cmsbuild added pdmv-pending upgrade-pending code-checks-pending and removed code-checks-approved labels Jan 23, 2024

cmsbuild added code-checks-rejected and removed code-checks-pending labels Jan 23, 2024

Merge branch 'master' into Mu_POG_NanoAOD_v2

986fa04

cmsbuild added code-checks-pending and removed code-checks-rejected labels Jan 23, 2024

cmsbuild removed the code-checks-pending label Jan 23, 2024

cmsbuild added tests-started and removed tests-pending labels Feb 20, 2024

cmsbuild added tests-approved and removed tests-started labels Feb 20, 2024

cmsbuild added xpog-approved and removed xpog-pending labels Feb 20, 2024

cmsbuild added upgrade-approved and removed upgrade-pending labels Feb 20, 2024

cmsbuild added fully-signed pdmv-approved and removed pending-signatures pdmv-pending labels Feb 21, 2024

rbhattacharya04 mentioned this pull request Feb 21, 2024

Mu pog nano aod v2 backport #44043

Merged

cmsbuild added orp-approved and removed orp-pending labels Feb 21, 2024

cmsbuild merged commit 426442b into cms-sw:master Feb 21, 2024
13 checks passed

cmsbuild mentioned this pull request Feb 22, 2024

Update L1Scouting Data Format tests and minor code fixes #43984

Merged

vlimant mentioned this pull request Mar 2, 2024

[NanoAOD,BTVNano] Btvnano integration as customized module #43485

Merged

vlimant reviewed Mar 15, 2024

View reviewed changes

vlimant mentioned this pull request Mar 15, 2024

Custom MUON POG NANO includes default NANO #44425

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Muon POG NanoAOD v2 #43642

Muon POG NanoAOD v2 #43642

rbhattacharya04 commented Jan 1, 2024

cmsbuild commented Jan 1, 2024 •

edited

Loading

cmsbuild commented Jan 1, 2024

cmsbuild commented Jan 1, 2024

vlimant commented Jan 10, 2024

cmsbuild commented Jan 23, 2024

cmsbuild commented Jan 23, 2024

cmsbuild commented Feb 19, 2024

rbhattacharya04 commented Feb 19, 2024

vlimant commented Feb 20, 2024

cmsbuild commented Feb 20, 2024

vlimant commented Feb 20, 2024

subirsarkar commented Feb 20, 2024

jordan-martins commented Feb 21, 2024

sunilUIET commented Feb 21, 2024

cmsbuild commented Feb 21, 2024

rappoccio commented Feb 21, 2024

vlimant Mar 15, 2024

rbhattacharya04 Mar 15, 2024

vlimant Mar 15, 2024

vlimant Mar 18, 2024

rbhattacharya04 Mar 18, 2024

Muon POG NanoAOD v2 #43642

Muon POG NanoAOD v2 #43642

Conversation

rbhattacharya04 commented Jan 1, 2024

cmsbuild commented Jan 1, 2024 • edited Loading

cmsbuild commented Jan 1, 2024

cmsbuild commented Jan 1, 2024

vlimant commented Jan 10, 2024

cmsbuild commented Jan 23, 2024

cmsbuild commented Jan 23, 2024

cmsbuild commented Feb 19, 2024

rbhattacharya04 commented Feb 19, 2024

vlimant commented Feb 20, 2024

cmsbuild commented Feb 20, 2024

Comparison Summary

NANO Comparison Summary

vlimant commented Feb 20, 2024

subirsarkar commented Feb 20, 2024

jordan-martins commented Feb 21, 2024

sunilUIET commented Feb 21, 2024

cmsbuild commented Feb 21, 2024

rappoccio commented Feb 21, 2024

vlimant Mar 15, 2024

Choose a reason for hiding this comment

rbhattacharya04 Mar 15, 2024

Choose a reason for hiding this comment

vlimant Mar 15, 2024

Choose a reason for hiding this comment

vlimant Mar 18, 2024

Choose a reason for hiding this comment

rbhattacharya04 Mar 18, 2024

Choose a reason for hiding this comment

cmsbuild commented Jan 1, 2024 •

edited

Loading