Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mu pog nano aod v2 backport #44043

Merged

Conversation

rbhattacharya04
Copy link
Contributor

This is the backport of the pull request - #43642
This backport is meant for the CMSSW 14_0
We want the newly added variables at the original PR, to be included in the Muon POG custom Nano production, which will happen in CMSSW 14_0

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @rbhattacharya04 for CMSSW_14_0_X.

It involves the following packages:

  • Configuration/PyReleaseValidation (upgrade, pdmv)
  • PhysicsTools/NanoAOD (xpog)

@subirsarkar, @hqucms, @srimanob, @vlimant, @cmsbuild, @AdrianoDee, @miquork, @sunilUIET can you please review it and eventually sign? Thanks.
@fabiocos, @AnnikaStein, @makortel, @Martin-Grunewald, @missirol, @slomeo, @gpetruc this is something you requested to watch as well.
@sextonkennedy, @antoniovilela, @rappoccio you are the release manager for this.

cms-bot commands are listed here

@cmsbuild
Copy link
Contributor

cmsbuild commented Feb 21, 2024

cms-bot internal usage

@vlimant
Copy link
Contributor

vlimant commented Feb 21, 2024

enable nano

@vlimant
Copy link
Contributor

vlimant commented Feb 21, 2024

please test

@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-aadf5f/37603/summary.html
COMMIT: 3a3cf3e
CMSSW: CMSSW_14_0_X_2024-02-21-1100/el8_amd64_gcc12
Additional Tests: NANO
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/44043/37603/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

NANO Comparison Summary

Summary:

  • You potentially added 3 lines to the logs
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 15
  • DQMHistoTests: Total histograms compared: 16524
  • DQMHistoTests: Total failures: 0
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 16524
  • DQMHistoTests: Total skipped: 0
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 14 files compared)
  • Checked 38 log files, 18 edm output root files, 15 DQM output files

Nano size comparison Summary:

  • Nano ERROR: Missing ref/2500.314-size.json
  • Nano ERROR: Missing ref/2500.314-size.json
  • Nano ERROR: Missing ref/2500.401-size.json
  • Nano ERROR: Missing ref/2500.401-size.json
    | Sample | kb/ev | ref kb/ev | diff kb/ev | ev/s/thd | ref ev/s/thd | diff rate | mem/thd | ref mem/thd |
    | --- | --- | --- | --- | --- | --- | --- | --- | --- |
    | 2500.0 | 2.545 | 2.545 | 0.000 ( +0.0% ) | 5.27 | 5.28 | -0.2% | 2.240 | 2.175 |
    | 2500.001 | 2.692 | 2.692 | 0.000 ( +0.0% ) | 4.70 | 4.75 | -1.1% | 2.670 | 2.606 |
    | 2500.002 | 2.631 | 2.631 | 0.000 ( +0.0% ) | 4.91 | 4.86 | +1.0% | 2.648 | 2.590 |
    | 2500.01 | 1.315 | 1.315 | 0.000 ( +0.0% ) | 9.79 | 9.71 | +0.8% | 2.353 | 2.265 |
    | 2500.011 | 1.732 | 1.732 | 0.000 ( +0.0% ) | 5.23 | 5.26 | -0.6% | 2.546 | 2.428 |
    | 2500.012 | 1.578 | 1.578 | 0.000 ( +0.0% ) | 7.58 | 7.45 | +1.7% | 2.460 | 2.399 |
    | 2500.1 | 2.193 | 2.193 | 0.000 ( +0.0% ) | 5.33 | 5.31 | +0.3% | 2.072 | 2.073 |
    | 2500.2 | 2.307 | 2.307 | 0.000 ( +0.0% ) | 6.07 | 6.09 | -0.4% | 1.986 | 1.984 |
    | 2500.21 | 1.183 | 1.183 | 0.000 ( +0.0% ) | 4.35 | 4.32 | +0.7% | 2.282 | 2.267 |
    | 2500.211 | 1.547 | 1.547 | 0.000 ( +0.0% ) | 3.77 | 3.78 | -0.1% | 2.364 | 2.341 |
    | 2500.3 | 2.063 | 2.063 | 0.000 ( +0.0% ) | 12.58 | 12.79 | -1.6% | 1.966 | 1.973 |
    | 2500.31 | 1.259 | 1.259 | 0.000 ( +0.0% ) | 20.34 | 19.83 | +2.6% | 2.370 | 2.364 |
    | 2500.311 | 1.648 | 1.648 | 0.000 ( +0.0% ) | 12.62 | 12.11 | +4.2% | 2.447 | 2.421 |
    | 2500.312 | 7.159 | 7.159 | 0.000 ( +0.0% ) | 1.38 | 1.39 | -0.2% | 1.695 | 1.698 |
    | 2500.313 | 1.564 | 1.564 | 0.000 ( +0.0% ) | 6.54 | 6.73 | -2.9% | 1.047 | 1.050 |
    | 2500.4 | 2.063 | 2.063 | 0.000 ( +0.0% ) | 12.57 | 12.77 | -1.6% | 1.977 | 1.975 |
    | 2500.5 | 19.575 | 19.575 | 0.000 ( +0.0% ) | 1.03 | 1.12 | -8.1% | 1.359 | 1.124 |

@vlimant
Copy link
Contributor

vlimant commented Feb 22, 2024

+1

@srimanob
Copy link
Contributor

+Upgrade

@sunilUIET
Copy link
Contributor

+pdmv

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_14_0_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_14_1_X is complete. This pull request will now be reviewed by the release team before it's merged. @antoniovilela, @sextonkennedy, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)

@rappoccio
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit 85000db into cms-sw:CMSSW_14_0_X Feb 26, 2024
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants