Custom MUON POG NANO includes default NANO #44425

vlimant · 2024-03-15T14:48:48Z

PR description:

since the MUPOG custom nano will always include the standard nano, the definition in the mapping should strictly include the PHYS part, so that they never get separated. (oversight on my account in #43642 )

PR validation:

runTheMatrix.py --what nano -l 2500.314 --ibeos to success

I also verified that combining --step NANO:@EGM+@MUPOG leads to the inclusion of "only one PHYS"

cmsbuild · 2024-03-15T14:49:09Z

cms-bot internal usage

cmsbuild · 2024-03-15T14:54:15Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-44425/39497

This PR adds an extra 16KB to repository

cmsbuild · 2024-03-15T14:54:38Z

A new Pull Request was created by @vlimant for master.

It involves the following packages:

Configuration/PyReleaseValidation (upgrade, pdmv)
PhysicsTools/NanoAOD (xpog)

@vlimant, @AdrianoDee, @sunilUIET, @subirsarkar, @cmsbuild, @hqucms, @miquork, @srimanob can you please review it and eventually sign? Thanks.
@gpetruc, @Martin-Grunewald, @makortel, @missirol, @slomeo, @AnnikaStein, @fabiocos this is something you requested to watch as well.
@antoniovilela, @sextonkennedy, @rappoccio you are the release manager for this.

cms-bot commands are listed here

vlimant · 2024-03-15T14:55:22Z

enable nano

vlimant · 2024-03-15T14:56:26Z

please test

cmsbuild · 2024-03-15T17:51:06Z

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-fdcf47/38170/summary.html
COMMIT: 325d81a
CMSSW: CMSSW_14_1_X_2024-03-15-1100/el8_amd64_gcc12
Additional Tests: NANO
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/44425/38170/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

You potentially added 92 lines to the logs
Reco comparison results: 45 differences found in the comparisons
DQMHistoTests: Total files compared: 48
DQMHistoTests: Total histograms compared: 3297383
DQMHistoTests: Total failures: 3
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 3297360
DQMHistoTests: Total skipped: 20
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 0.0 KiB( 47 files compared)
Checked 202 log files, 165 edm output root files, 48 DQM output files
TriggerResults: no differences found

NANO Comparison Summary

Summary:

You potentially added 1 lines to the logs
Reco comparison results: 0 differences found in the comparisons
DQMHistoTests: Total files compared: 15
DQMHistoTests: Total histograms compared: 16402
DQMHistoTests: Total failures: 0
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 16402
DQMHistoTests: Total skipped: 0
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 0.0 KiB( 14 files compared)
Checked 45 log files, 25 edm output root files, 15 DQM output files

Nano size comparison Summary:

Sample	kb/ev	ref kb/ev	diff kb/ev	ev/s/thd	ref ev/s/thd	diff rate	mem/thd	ref mem/thd
2500.0	2.548	2.548	0.000 ( +0.0% )	5.24	5.17	+1.5%	2.168	2.063
2500.001	2.698	2.698	0.000 ( +0.0% )	4.66	4.67	-0.2%	2.561	2.078
2500.002	2.638	2.638	0.000 ( +0.0% )	4.84	4.76	+1.8%	2.559	2.091
2500.01	1.318	1.318	0.000 ( +0.0% )	9.48	9.58	-1.1%	2.275	1.918
2500.011	1.740	1.740	0.000 ( +0.0% )	5.17	5.14	+0.6%	2.398	1.927
2500.012	1.581	1.581	0.000 ( +0.0% )	7.25	7.43	-2.4%	2.302	1.954
2500.1	2.192	2.192	0.000 ( +0.0% )	5.26	5.22	+0.9%	2.003	1.884
2500.2	2.308	2.308	0.000 ( +0.0% )	6.01	5.98	+0.5%	1.892	1.754
2500.21	1.181	1.181	0.000 ( +0.0% )	4.34	4.31	+0.7%	2.230	1.764
2500.211	1.545	1.545	0.000 ( +0.0% )	3.72	3.70	+0.6%	2.250	1.856
2500.3	2.058	2.058	0.000 ( +0.0% )	12.21	12.41	-1.6%	1.890	1.831
2500.301	2.631	2.631	0.000 ( +0.0% )	10.07	9.96	+1.1%	1.831	1.785
2500.31	1.254	1.254	0.000 ( +0.0% )	19.63	18.80	+4.4%	2.330	2.186
2500.311	1.640	1.640	0.000 ( +0.0% )	13.44	12.80	+5.0%	2.313	2.260
2500.312	7.159	7.159	0.000 ( +0.0% )	1.41	1.37	+2.9%	1.703	1.647
2500.313	1.564	1.564	0.000 ( +0.0% )	7.07	6.69	+5.8%	1.048	1.050
2500.314	1.163	1.163	0.000 ( +0.0% )	13.50	14.26	-5.3%	2.209	2.018
2500.315	1.758	1.758	0.000 ( +0.0% )	13.56	13.85	-2.1%	2.321	1.826
2500.316	1.787	1.787	0.000 ( +0.0% )	13.35	12.81	+4.2%	2.180	1.919
2500.4	2.058	2.058	0.000 ( +0.0% )	12.38	12.42	-0.3%	1.853	1.625
2500.401	1.824	1.824	0.000 ( +0.0% )	9.96	9.97	-0.2%	1.828	1.350
2500.402	2.631	2.631	0.000 ( +0.0% )	9.80	10.10	-3.0%	1.882	1.775
2500.403	2.620	2.620	0.000 ( +0.0% )	9.89	10.11	-2.2%	1.948	1.758
2500.5	19.575	19.575	0.000 ( +0.0% )	1.13	1.22	-7.6%	1.143	1.254

vlimant · 2024-03-15T18:52:53Z

+1

vlimant · 2024-03-18T20:24:10Z

@cms-sw/pdmv-l2 @cms-sw/upgrade-l2 : can you please sign quickly this trivial PR so that we can get the backport going.

subirsarkar · 2024-03-19T05:57:06Z

+Upgrade

AdrianoDee · 2024-03-22T13:59:04Z

+pdmv

cmsbuild · 2024-03-22T13:59:27Z

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @rappoccio, @antoniovilela, @sextonkennedy (and backports should be raised in the release meeting by the corresponding L2)

antoniovilela · 2024-03-22T20:45:43Z

@vlimant
Please resolve conflicts.

vlimant · 2024-03-22T20:54:27Z

please test

cmsbuild · 2024-03-22T21:00:06Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-44425/39649

This PR adds an extra 20KB to repository
There are other open Pull requests which might conflict with changes you have proposed:
- File Configuration/PyReleaseValidation/python/relval_nano.py modified in PR(s): [NanoAOD,BTVNano] Btvnano integration as customized module #43485, Customized L1T NanoAOD #43957, l1nano import location #44391, Scouting NANO in autonano #44399, Hcalnano autonano #44492
- File PhysicsTools/NanoAOD/python/autoNANO.py modified in PR(s): [NanoAOD,BTVNano] Btvnano integration as customized module #43485, Customized L1T NanoAOD #43957, l1nano import location #44391, Scouting NANO in autonano #44399, Hcalnano autonano #44492

cmsbuild · 2024-03-22T21:00:50Z

Pull request #44425 was updated. can you please check and sign again.

cmsbuild · 2024-03-23T02:02:03Z

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-fdcf47/38356/summary.html
COMMIT: f759a91
CMSSW: CMSSW_14_1_X_2024-03-22-1100/el8_amd64_gcc12
Additional Tests: NANO
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/44425/38356/install.sh to create a dev area with all the needed externals and cmssw changes.

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:

You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-fdcf47/38356/git-recent-commits.json
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-fdcf47/38356/git-merge-result

Comparison Summary

Summary:

You potentially removed 69 lines from the logs
Reco comparison results: 3633 differences found in the comparisons
DQMHistoTests: Total files compared: 48
DQMHistoTests: Total histograms compared: 3297369
DQMHistoTests: Total failures: 4502
DQMHistoTests: Total nulls: 82
DQMHistoTests: Total successes: 3292765
DQMHistoTests: Total skipped: 20
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 30.714 KiB( 47 files compared)
DQMHistoSizes: changed ( 23234.0,... ): 5.119 KiB MTD/Vertices
Checked 202 log files, 165 edm output root files, 48 DQM output files
TriggerResults: found differences in 1 / 46 workflows

NANO Comparison Summary

Summary:

You potentially added 1 lines to the logs
Reco comparison results: 0 differences found in the comparisons
DQMHistoTests: Total files compared: 15
DQMHistoTests: Total histograms compared: 16402
DQMHistoTests: Total failures: 0
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 16402
DQMHistoTests: Total skipped: 0
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 0.0 KiB( 14 files compared)
Checked 47 log files, 27 edm output root files, 15 DQM output files

Nano size comparison Summary:

Sample	kb/ev	ref kb/ev	diff kb/ev	ev/s/thd	ref ev/s/thd	diff rate	mem/thd	ref mem/thd
2500.0	2.548	2.548	0.000 ( +0.0% )	5.25	5.18	+1.3%	2.149	2.084
2500.001	2.698	2.698	0.000 ( +0.0% )	4.70	4.64	+1.3%	2.568	2.078
2500.002	2.638	2.638	0.000 ( +0.0% )	4.88	4.81	+1.3%	2.574	2.081
2500.01	1.318	1.318	0.000 ( +0.0% )	9.63	9.33	+3.2%	2.276	1.777
2500.011	1.740	1.740	0.000 ( +0.0% )	5.18	5.13	+1.0%	2.418	1.943
2500.012	1.581	1.581	0.000 ( +0.0% )	7.43	7.23	+2.7%	2.307	1.900
2500.1	2.192	2.192	0.000 ( +0.0% )	5.28	5.22	+1.1%	1.984	1.920
2500.2	2.308	2.308	0.000 ( +0.0% )	6.03	6.00	+0.5%	1.878	1.793
2500.21	1.181	1.181	0.000 ( +0.0% )	4.31	4.26	+1.3%	2.167	1.780
2500.211	1.545	1.545	0.000 ( +0.0% )	3.72	3.65	+2.0%	2.187	1.878
2500.3	2.058	2.058	0.000 ( +0.0% )	12.47	11.62	+7.4%	1.880	1.823
2500.301	2.630	2.631	-0.001 ( -0.0% )	10.33	9.28	+11.4%	1.832	1.817
2500.31	1.254	1.254	0.000 ( +0.0% )	19.69	18.96	+3.8%	2.217	1.827
2500.311	1.640	1.640	0.000 ( +0.0% )	13.53	12.90	+4.9%	2.296	1.928
2500.312	7.159	7.159	0.000 ( +0.0% )	1.43	1.42	+0.5%	1.706	1.701
2500.313	1.564	1.564	0.000 ( +0.0% )	6.31	6.63	-4.9%	1.055	1.051
2500.314	1.163	1.163	0.000 ( +0.0% )	13.56	13.08	+3.7%	2.212	1.623
2500.315	1.756	1.758	-0.003 ( -0.1% )	14.40	13.48	+6.9%	2.327	2.307
2500.316	3.091	3.091	0.000 ( +0.0% )	2.20	2.16	+2.2%	2.117	1.779
2500.317	1.787	1.787	0.000 ( +0.0% )	13.77	13.08	+5.2%	2.154	2.127
2500.4	2.058	2.058	0.000 ( +0.0% )	12.46	11.97	+4.0%	1.924	1.813
2500.401	1.824	1.824	0.000 ( +0.0% )	10.39	10.07	+3.2%	1.708	1.698
2500.402	2.630	2.631	-0.001 ( -0.0% )	10.30	9.83	+4.7%	1.915	1.661
2500.403	5.188	5.188	0.000 ( +0.0% )	1.55	1.55	+0.4%	1.804	1.832
2500.404	2.620	2.620	0.000 ( +0.0% )	10.04	9.50	+5.7%	1.874	1.750
2500.5	19.575	19.575	0.000 ( +0.0% )	1.08	1.25	-13.8%	1.142	1.367

antoniovilela · 2024-03-25T10:21:20Z

+1

MUPOG includes PHYS by default. i.e. is never separated

325d81a

cmsbuild added this to the CMSSW_14_1_X milestone Mar 15, 2024

cmsbuild added pending-signatures tests-pending orp-pending pdmv-pending upgrade-pending code-checks-pending xpog-pending labels Mar 15, 2024

cmsbuild added code-checks-approved and removed code-checks-pending labels Mar 15, 2024

vlimant mentioned this pull request Mar 15, 2024

Muon POG NanoAOD v2 #43642

Merged

cmsbuild added tests-started and removed tests-pending labels Mar 15, 2024

vlimant added a commit to vlimant/cmssw that referenced this pull request Mar 15, 2024

backport of cms-sw#44425 cms-sw#44399 cms-sw#44087

529cc08

vlimant mentioned this pull request Mar 15, 2024

custom nano configuration and test [Backport] #44428

Merged

cmsbuild added tests-approved and removed tests-started labels Mar 15, 2024

cmsbuild added xpog-approved and removed xpog-pending labels Mar 15, 2024

cmsbuild mentioned this pull request Mar 18, 2024

Customized L1T NanoAOD #43957

Merged

cmsbuild added fully-signed pdmv-approved and removed pending-signatures pdmv-pending labels Mar 22, 2024

Merge branch 'master' into mupog_include_phys

f759a91

cmsbuild added tests-pending code-checks-pending and removed tests-approved code-checks-approved labels Mar 22, 2024

cmsbuild added tests-started and removed tests-pending labels Mar 22, 2024

cmsbuild added code-checks-approved and removed code-checks-pending labels Mar 22, 2024

cmsbuild mentioned this pull request Mar 22, 2024

Scouting NANO in autonano #44399

Merged

cmsbuild added tests-approved and removed tests-started labels Mar 23, 2024

cmsbuild added orp-approved and removed orp-pending labels Mar 25, 2024

cmsbuild merged commit 7660272 into cms-sw:master Mar 25, 2024
13 checks passed

This was referenced Mar 25, 2024

[CPP20] Cleanup BuildFile.xml for Alignment/OfflineValidation #44538

Merged

AXOL1TL emulator update for L1 Menu parsing with UTMv12 #44510

Merged

vlimant deleted the mupog_include_phys branch April 2, 2024 12:18

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Custom MUON POG NANO includes default NANO #44425

Custom MUON POG NANO includes default NANO #44425

vlimant commented Mar 15, 2024 •

edited

Loading

cmsbuild commented Mar 15, 2024 •

edited

Loading

cmsbuild commented Mar 15, 2024

cmsbuild commented Mar 15, 2024

vlimant commented Mar 15, 2024

vlimant commented Mar 15, 2024

cmsbuild commented Mar 15, 2024

vlimant commented Mar 15, 2024

vlimant commented Mar 18, 2024

subirsarkar commented Mar 19, 2024

AdrianoDee commented Mar 22, 2024

cmsbuild commented Mar 22, 2024

antoniovilela commented Mar 22, 2024

vlimant commented Mar 22, 2024

cmsbuild commented Mar 22, 2024

cmsbuild commented Mar 22, 2024

cmsbuild commented Mar 23, 2024

antoniovilela commented Mar 25, 2024

Custom MUON POG NANO includes default NANO #44425

Custom MUON POG NANO includes default NANO #44425

Conversation

vlimant commented Mar 15, 2024 • edited Loading

PR description:

PR validation:

cmsbuild commented Mar 15, 2024 • edited Loading

cmsbuild commented Mar 15, 2024

cmsbuild commented Mar 15, 2024

vlimant commented Mar 15, 2024

vlimant commented Mar 15, 2024

cmsbuild commented Mar 15, 2024

Comparison Summary

NANO Comparison Summary

vlimant commented Mar 15, 2024

vlimant commented Mar 18, 2024

subirsarkar commented Mar 19, 2024

AdrianoDee commented Mar 22, 2024

cmsbuild commented Mar 22, 2024

antoniovilela commented Mar 22, 2024

vlimant commented Mar 22, 2024

cmsbuild commented Mar 22, 2024

cmsbuild commented Mar 22, 2024

cmsbuild commented Mar 23, 2024

Comparison Summary

NANO Comparison Summary

antoniovilela commented Mar 25, 2024

vlimant commented Mar 15, 2024 •

edited

Loading

cmsbuild commented Mar 15, 2024 •

edited

Loading