AXOL1TL emulator update for L1 Menu parsing with UTMv12 #44510

artlbv · 2024-03-22T10:35:54Z

PR description:

This PR is an amendment of the AXOL1TL emulator PRs: #44054 (original backport: #44397).
Essentially reverting and extending the AXO-only part of this revert: #44466

The main changes are:

As the original PR, this introduces compatibility with the new UTM "grammar" (v12) for the AXO seed, i.e. what is used in the L1Menu_Collisions2024_v1_1_0 (see the AXO seeds in that menu here.
New: Added backward compatibility with the previous UTM "grammar" (pre v12) for the AXO seed, i.e. what is used in the L1Menu_Collisions2024_v1_0_0 (see the AXO seeds in that menu here). Note that UTM v12 supports the old and new AXO condition type.
For this kind of seeds the AXO model is hard-coded to the v3 version as this is currently the baseline.
New: cleaned up the AXO model setting in the L1GlobalProducer/Board code as the model version is not defined globally anymore, but on the seed level.

No additional PRs are needed to test this PR.

PR validation:

I tested this PR in 14_1 (and 14_0) with the following command with the default 1_0_0 L1 menu (old UTM), but also with 1_1_0 (new UTM for AXO) and a menu where I mix both old and new AXO conditions. Note this is inspired by the workflow 141.044_RunJetMET2023D but faster for testing.

Rerunning L1 and HLT with the default L1 Menu 1_0_0:

cmsDriver.py repackuGT_reHLT -s L1REPACK:Full,HLT:@relval2024 --process reHLT --datatier NANOAOD --eventcontent NANOAOD \
-n 100 --era=Run3 \            
--data --conditions=auto:run3_hlt_relval  \
--filein=/store/data/Run2023D/JetMET0/RAW/v1/000/369/978/00000/00b9eba7-c847-465b-a6de-98bceae93613.root

Rerunning L1 and HLT with the 1_0_1 L1 Menu by specifying it via:

--customise=L1Trigger/Configuration/customiseUtils.L1TGlobalMenuXML

In all cases L1 and HLT properly ran. Note though that given the current HLS4ML issues (see #44435), the AXO seeds fire in all events in the current master.
This can be circumvented by adding this to the config (removing the CICADA emulator from the L1 chain):

process.SimL1Emulator.remove(process.simCaloStage2Layer1Summary)

The results are in line with what is expected:

../repackuGT_reHLT_L1_101_L1REPACK_HLT.root
Trigs for 100 events:
DST_PFScouting_AXONominal    100
DST_PFScouting_AXOTight      100
HLT_L1AXOVTight              100
dtype: int64
../repackuGT_reHLT_L1_101_L1REPACK_HLT_noCICADA.root
Trigs for 100 events:
DST_PFScouting_AXONominal    0
DST_PFScouting_AXOTight      0
HLT_L1AXOVTight              0
dtype: int64
../repackuGT_reHLT_def_L1REPACK_HLT.root
Trigs for 100 events:
DST_PFScouting_AXONominal    100
DST_PFScouting_AXOTight      100
HLT_L1AXOVTight              100
dtype: int64
../repackuGT_reHLT_def_L1REPACK_HLT_noCICADA.root
Trigs for 100 events:
DST_PFScouting_AXONominal    2
DST_PFScouting_AXOTight      1
HLT_L1AXOVTight              0

The results for L1 were checked with the L1 menu ntuples and show agreement for using different UTM grammar within the same XML:

141 L1ReEmu
seed                	unp	emu	mism
L1_AXO_Nominal      	0	2	2
L1_AXO_Tight        	0	1	1
L1_AXO_VLoose       	0	11	11
L1_AXO_VLooseNewUTMv3	0	11	11
L1_AXO_VTight       	0	0	0

If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:

Not a backport, but will be backported immediately for the next 14_0_X release.
Backport: #44511

cmsbuild · 2024-03-22T10:36:18Z

cms-bot internal usage

artlbv · 2024-03-22T10:39:13Z

FYI @quinnanm @thesps @eyigitba @aloeliger @jmduarte

cmsbuild · 2024-03-22T10:42:19Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-44510/39630

This PR adds an extra 64KB to repository
There are other open Pull requests which might conflict with changes you have proposed:
- File HLTrigger/Configuration/python/customizeHLTforCMSSW.py modified in PR(s): Alpaka vs CUDA DQM compare modules for pixel tracks objects #43964
- File L1Trigger/L1TGlobal/plugins/L1TGlobalProducer.cc modified in PR(s): CICADA-uGT emulator additions #44222
- File L1Trigger/L1TGlobal/plugins/L1TGlobalProducer.h modified in PR(s): CICADA-uGT emulator additions #44222
- File L1Trigger/L1TGlobal/plugins/TriggerMenuParser.cc modified in PR(s): CICADA-uGT emulator additions #44222
- File L1Trigger/L1TGlobal/plugins/TriggerMenuParser.h modified in PR(s): CICADA-uGT emulator additions #44222
- File L1Trigger/L1TGlobal/python/simGtStage2Digis_cfi.py modified in PR(s): CICADA-uGT emulator additions #44222
- File L1Trigger/L1TGlobal/src/GlobalBoard.cc modified in PR(s): CICADA-uGT emulator additions #44222

cmsbuild · 2024-03-22T10:42:45Z

A new Pull Request was created by @artlbv for master.

It involves the following packages:

HLTrigger/Configuration (hlt)
L1Trigger/L1TGlobal (l1)

@aloeliger, @cmsbuild, @Martin-Grunewald, @mmusich, @epalencia can you please review it and eventually sign? Thanks.
@Martin-Grunewald, @missirol, @silviodonato this is something you requested to watch as well.
@rappoccio, @sextonkennedy, @antoniovilela you are the release manager for this.

cms-bot commands are listed here

mmusich

cosmetics changes...

L1Trigger/L1TGlobal/plugins/L1TGlobalProducer.cc

HLTrigger/Configuration/python/customizeHLTforCMSSW.py

mmusich · 2024-03-22T11:21:57Z

allow @artlbv test rights

cmsbuild · 2024-03-22T11:40:29Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-44510/39635

This PR adds an extra 64KB to repository
There are other open Pull requests which might conflict with changes you have proposed:
- File HLTrigger/Configuration/python/customizeHLTforCMSSW.py modified in PR(s): Alpaka vs CUDA DQM compare modules for pixel tracks objects #43964
- File L1Trigger/L1TGlobal/plugins/L1TGlobalProducer.cc modified in PR(s): CICADA-uGT emulator additions #44222
- File L1Trigger/L1TGlobal/plugins/L1TGlobalProducer.h modified in PR(s): CICADA-uGT emulator additions #44222
- File L1Trigger/L1TGlobal/plugins/TriggerMenuParser.cc modified in PR(s): CICADA-uGT emulator additions #44222
- File L1Trigger/L1TGlobal/plugins/TriggerMenuParser.h modified in PR(s): CICADA-uGT emulator additions #44222
- File L1Trigger/L1TGlobal/python/simGtStage2Digis_cfi.py modified in PR(s): CICADA-uGT emulator additions #44222
- File L1Trigger/L1TGlobal/src/GlobalBoard.cc modified in PR(s): CICADA-uGT emulator additions #44222

cmsbuild · 2024-03-22T11:40:52Z

Pull request #44510 was updated. @cmsbuild, @aloeliger, @epalencia, @Martin-Grunewald, @mmusich can you please check and sign again.

artlbv · 2024-03-22T11:41:01Z

@cmsbuild please test

cmsbuild · 2024-03-22T14:21:48Z

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-fd6953/38343/summary.html
COMMIT: ccb11e8
CMSSW: CMSSW_14_1_X_2024-03-21-2300/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/44510/38343/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

You potentially removed 56 lines from the logs
Reco comparison results: 48 differences found in the comparisons
DQMHistoTests: Total files compared: 48
DQMHistoTests: Total histograms compared: 3297369
DQMHistoTests: Total failures: 6
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 3297343
DQMHistoTests: Total skipped: 20
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 0.0 KiB( 47 files compared)
Checked 202 log files, 165 edm output root files, 48 DQM output files
TriggerResults: no differences found

aloeliger · 2024-03-22T14:42:53Z

@cms-sw/hlt-l2 I want to make sure that I'm on the same page as everyone else, because I think there's been a pretty extended game of message passing.

As far as I have discussed this PR with @artlbv this PR will run AXO on UTM 11 and 12 effectively (i.e. it is backwards compatible), and will read the AXO model from the menu (superseding @quinnanm's PR). So this should be the whole thing and everything necessary to put AXO online, correct?

I don't think immediate ALCA changes as were necessary last time are necessary now due to the compatibility fix, right?

This PR doesn't fix the model collision, put PRs open to the Externals will. I know the CICADA and AXO PRs are open now (and backports). Would you like tests with those?

I think there's been discussion with TSG about having this PR available ASAP (monday was the day I heard), any major blocks to that that you can see?

cmsbuild · 2024-03-26T11:35:00Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-44510/39683

This PR adds an extra 40KB to repository
There are other open Pull requests which might conflict with changes you have proposed:
- File HLTrigger/Configuration/python/customizeHLTforCMSSW.py modified in PR(s): Alpaka vs CUDA DQM compare modules for pixel tracks objects #43964
- File L1Trigger/L1TGlobal/interface/GlobalBoard.h modified in PR(s): CICADA-uGT emulator additions #44222
- File L1Trigger/L1TGlobal/plugins/L1TGlobalProducer.cc modified in PR(s): CICADA-uGT emulator additions #44222
- File L1Trigger/L1TGlobal/plugins/L1TGlobalProducer.h modified in PR(s): CICADA-uGT emulator additions #44222
- File L1Trigger/L1TGlobal/plugins/TriggerMenuParser.cc modified in PR(s): CICADA-uGT emulator additions #44222
- File L1Trigger/L1TGlobal/python/simGtStage2Digis_cfi.py modified in PR(s): CICADA-uGT emulator additions #44222
- File L1Trigger/L1TGlobal/src/GlobalBoard.cc modified in PR(s): CICADA-uGT emulator additions #44222

cmsbuild · 2024-03-26T11:35:26Z

Pull request #44510 was updated. @Martin-Grunewald, @mmusich, @epalencia, @cmsbuild, @aloeliger can you please check and sign again.

mmusich · 2024-03-26T11:50:01Z

@cmsbuild, please test

cmsbuild · 2024-03-26T18:11:21Z

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-fd6953/38423/summary.html
COMMIT: 43e9b00
CMSSW: CMSSW_14_1_X_2024-03-26-1100/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/44510/38423/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

You potentially added 65 lines to the logs
Reco comparison results: 39 differences found in the comparisons
DQMHistoTests: Total files compared: 48
DQMHistoTests: Total histograms compared: 3297857
DQMHistoTests: Total failures: 0
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 3297837
DQMHistoTests: Total skipped: 20
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 0.0 KiB( 47 files compared)
Checked 202 log files, 165 edm output root files, 48 DQM output files
TriggerResults: no differences found

mmusich · 2024-03-26T18:19:01Z

+hlt

PR according to description and follow-up review;
change in core HLTrigger packages is trivial;
achieves desired backward compatibility of the L1T emulator s/w with L1T-2024_v1_0_0 (and earlier)

aloeliger · 2024-03-26T18:25:12Z

+l1
-@cms-sw/hlt-l2 any final comments?

cmsbuild · 2024-03-26T18:25:38Z

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @sextonkennedy, @antoniovilela, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)

antoniovilela · 2024-03-27T15:34:22Z

+1

[14_0_0] Backport of #44510 AXOL1TL emulator update for L1 Menu parsing with UTMv12

cmsbuild added this to the CMSSW_14_1_X milestone Mar 22, 2024

cmsbuild added l1-pending hlt-pending pending-signatures tests-pending orp-pending code-checks-pending labels Mar 22, 2024

cmsbuild added code-checks-approved and removed code-checks-pending labels Mar 22, 2024

mmusich reviewed Mar 22, 2024

View reviewed changes

cmsbuild added the allow-artlbv label Mar 22, 2024

artlbv mentioned this pull request Mar 22, 2024

[14_0_0] Backport of #44510 AXOL1TL emulator update for L1 Menu parsing with UTMv12 #44511

Merged

cmsbuild added code-checks-pending and removed code-checks-approved labels Mar 22, 2024

cmsbuild added code-checks-approved and removed code-checks-pending labels Mar 22, 2024

cmsbuild added tests-started and removed tests-pending labels Mar 22, 2024

cmsbuild added tests-approved and removed tests-started labels Mar 22, 2024

cmsbuild added code-checks-approved and removed code-checks-pending labels Mar 26, 2024

cmsbuild added tests-started and removed tests-pending labels Mar 26, 2024

cmsbuild added tests-approved and removed tests-started labels Mar 26, 2024

cmsbuild added hlt-approved and removed hlt-pending labels Mar 26, 2024

cmsbuild added l1-approved fully-signed and removed l1-pending pending-signatures labels Mar 26, 2024

cmsbuild added orp-approved and removed orp-pending labels Mar 27, 2024

cmsbuild merged commit e261384 into cms-sw:master Mar 27, 2024
12 checks passed

artlbv mentioned this pull request Apr 3, 2024

Update L1TUtmTriggerMenu tag in 2024 MC GTs and for Run3 data RelVals #44594

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

AXOL1TL emulator update for L1 Menu parsing with UTMv12 #44510

AXOL1TL emulator update for L1 Menu parsing with UTMv12 #44510

artlbv commented Mar 22, 2024 •

edited

Loading

cmsbuild commented Mar 22, 2024 •

edited

Loading

artlbv commented Mar 22, 2024

cmsbuild commented Mar 22, 2024

cmsbuild commented Mar 22, 2024

mmusich left a comment

mmusich commented Mar 22, 2024 •

edited

Loading

cmsbuild commented Mar 22, 2024

cmsbuild commented Mar 22, 2024

artlbv commented Mar 22, 2024

cmsbuild commented Mar 22, 2024

aloeliger commented Mar 22, 2024

cmsbuild commented Mar 26, 2024

cmsbuild commented Mar 26, 2024

mmusich commented Mar 26, 2024

cmsbuild commented Mar 26, 2024

mmusich commented Mar 26, 2024

aloeliger commented Mar 26, 2024

cmsbuild commented Mar 26, 2024

antoniovilela commented Mar 27, 2024

AXOL1TL emulator update for L1 Menu parsing with UTMv12 #44510

AXOL1TL emulator update for L1 Menu parsing with UTMv12 #44510

Conversation

artlbv commented Mar 22, 2024 • edited Loading

PR description:

PR validation:

If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:

cmsbuild commented Mar 22, 2024 • edited Loading

artlbv commented Mar 22, 2024

cmsbuild commented Mar 22, 2024

cmsbuild commented Mar 22, 2024

mmusich left a comment

Choose a reason for hiding this comment

mmusich commented Mar 22, 2024 • edited Loading

cmsbuild commented Mar 22, 2024

cmsbuild commented Mar 22, 2024

artlbv commented Mar 22, 2024

cmsbuild commented Mar 22, 2024

Comparison Summary

aloeliger commented Mar 22, 2024

cmsbuild commented Mar 26, 2024

cmsbuild commented Mar 26, 2024

mmusich commented Mar 26, 2024

cmsbuild commented Mar 26, 2024

Comparison Summary

mmusich commented Mar 26, 2024

aloeliger commented Mar 26, 2024

cmsbuild commented Mar 26, 2024

antoniovilela commented Mar 27, 2024

artlbv commented Mar 22, 2024 •

edited

Loading

cmsbuild commented Mar 22, 2024 •

edited

Loading

mmusich commented Mar 22, 2024 •

edited

Loading