CICADA-uGT emulator additions #44222

aloeliger · 2024-02-27T15:33:27Z

PR description:

This PR adds the uGT half of the CICADA -> uGT emulator chain. It adds all the pieces needed to parse and compare the new CICADA condition added in uTM v 0.12.0. This is being opened in draft because no unpacker/packer combo is available yet, but will be added after I have had the chance to speak to experts about reading the CICADA record.

Depends on utm version 0.12.0

@elfontan You should likely take a look at my work on this, this is more working with uGT than I am used to.

@cms-sw/hlt-l2 Just in case you aren't automatically pinged on this, FYI. There is no unpacker/packer, but I will keep this in draft while I develop them. I will be speak to experts about it ASAP.

EDIT 06/03/24: Draft unpacker (not non-trivially tested) added.

PR validation:

All code compiles and has had code formatting applied.

In addition, I have tested the emulator on a new proto-type menu including a CICADA seed:
https://cernbox.cern.ch/files/link/public/LeBbgndwFDjWoI5?tiles-size=1&items-per-page=100&view-mode=resource-table

The emulator runs all the way through. The following are debug statements (now removed) from various components of the global board, CICADA conditions, and trigger menu parser showing that the emulator receives the score, compares to the menu, and in this case, decides it is below threshold and doesn't pass the menu cut:

Begin processing the 2nd record. Run 368566, Event 2615907242, LumiSection 1195 on stream 0 at 27-Feb-2024 08:34:54.517 CST
GlobalBoard::receiveCaloObjectData receive cicada
Valid CICADA
2.73438
GlobalBoard::runGTL CondCICADA
CICADACondition::evaluationCondition begin
cicada score is: 2.73438
min threshold is: 42
passCondition? 0

If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:

This PR is not a backport however, is likely to be needed for data-taking so a backport is probable to CMSSW_14_0.

cmsbuild · 2024-02-27T15:33:54Z

cms-bot internal usage

cmsbuild · 2024-02-27T15:39:20Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-44222/39227

This PR adds an extra 68KB to repository
There are other open Pull requests which might conflict with changes you have proposed:
- File L1Trigger/L1TGlobal/plugins/L1TGlobalProducer.cc modified in PR(s): Get AXOL1TL model version from menu as of utm v0.12.0 #44054
- File L1Trigger/L1TGlobal/plugins/TriggerMenuParser.cc modified in PR(s): Get AXOL1TL model version from menu as of utm v0.12.0 #44054
- File L1Trigger/L1TGlobal/plugins/TriggerMenuParser.h modified in PR(s): Get AXOL1TL model version from menu as of utm v0.12.0 #44054
- File L1Trigger/L1TGlobal/python/simGtStage2Digis_cfi.py modified in PR(s): Get AXOL1TL model version from menu as of utm v0.12.0 #44054
- File L1Trigger/L1TGlobal/src/GlobalBoard.cc modified in PR(s): Get AXOL1TL model version from menu as of utm v0.12.0 #44054

aloeliger · 2024-03-06T15:03:12Z

I'm marking this pull request ready after adding the unpacker commit. However, I should stress that the unpacker has not been tested in realistic conditions with actual CICADA input data present, and therefore has not been tested to be working. It does compile, and it does seem to properly fail-safe to a 0.0 score in the case of nothing to unpack/nothing unpacked.

cmsbuild · 2024-03-06T15:08:08Z

-code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-44222/39361

This PR adds an extra 80KB to repository
There are other open Pull requests which might conflict with changes you have proposed:
- File EventFilter/L1TRawToDigi/plugins/implementations_stage2/GTSetup.cc modified in PR(s): Adding ZDC packer #44019
- File L1Trigger/L1TGlobal/plugins/L1TGlobalProducer.cc modified in PR(s): Get AXOL1TL model version from menu as of utm v0.12.0 #44054
- File L1Trigger/L1TGlobal/plugins/TriggerMenuParser.cc modified in PR(s): Get AXOL1TL model version from menu as of utm v0.12.0 #44054
- File L1Trigger/L1TGlobal/plugins/TriggerMenuParser.h modified in PR(s): Get AXOL1TL model version from menu as of utm v0.12.0 #44054
- File L1Trigger/L1TGlobal/python/simGtStage2Digis_cfi.py modified in PR(s): Get AXOL1TL model version from menu as of utm v0.12.0 #44054
- File L1Trigger/L1TGlobal/src/GlobalBoard.cc modified in PR(s): Get AXOL1TL model version from menu as of utm v0.12.0 #44054

Code check has found code style and quality issues which could be resolved by applying following patch(s)

code-format:
https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-44222/39361/code-format.patch
e.g. curl -k https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-44222/39361/code-format.patch | patch -p1
You can also run scram build code-format to apply code format directly

cmsbuild · 2024-03-06T15:23:47Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-44222/39362

This PR adds an extra 80KB to repository
There are other open Pull requests which might conflict with changes you have proposed:
- File EventFilter/L1TRawToDigi/plugins/implementations_stage2/GTSetup.cc modified in PR(s): Adding ZDC packer #44019
- File L1Trigger/L1TGlobal/plugins/L1TGlobalProducer.cc modified in PR(s): Get AXOL1TL model version from menu as of utm v0.12.0 #44054
- File L1Trigger/L1TGlobal/plugins/TriggerMenuParser.cc modified in PR(s): Get AXOL1TL model version from menu as of utm v0.12.0 #44054
- File L1Trigger/L1TGlobal/plugins/TriggerMenuParser.h modified in PR(s): Get AXOL1TL model version from menu as of utm v0.12.0 #44054
- File L1Trigger/L1TGlobal/python/simGtStage2Digis_cfi.py modified in PR(s): Get AXOL1TL model version from menu as of utm v0.12.0 #44054
- File L1Trigger/L1TGlobal/src/GlobalBoard.cc modified in PR(s): Get AXOL1TL model version from menu as of utm v0.12.0 #44054

cmsbuild · 2024-03-06T15:24:07Z

A new Pull Request was created by @aloeliger for master.

It involves the following packages:

EventFilter/L1TRawToDigi (l1)
L1Trigger/L1TGlobal (l1)

@aloeliger, @epalencia, @cmsbuild can you please review it and eventually sign? Thanks.
@Martin-Grunewald, @thomreis, @missirol, @dinyar, @eyigitba this is something you requested to watch as well.
@sextonkennedy, @antoniovilela, @rappoccio you are the release manager for this.

cms-bot commands are listed here

aloeliger · 2024-03-06T16:29:02Z

assign hlt

I think HLT wants to sign off on changes to the uGT emulator?

cmsbuild · 2024-03-06T16:29:24Z

New categories assigned: hlt

@Martin-Grunewald,@mmusich you have been requested to review this Pull request/Issue and eventually sign? Thanks

EventFilter/L1TRawToDigi/plugins/implementations_stage2/CaloSummaryUnpacker.cc

Martin-Grunewald · 2024-03-06T16:53:48Z

It is not clear to me how/where the unpacker is called. Within existing (unpacking) code or a new module, which needs to be added to some python unpacking sequence? What about the packer?

aloeliger · 2024-03-06T16:55:30Z

It is not clear to me how/where the unpacker is called. Within existing (unpacking) code or a new module, which needs to be added to some python unpacking sequence? What about the packer?

@Martin-Grunewald It's defined as part of the GT unpacking setup here:

cmssw/EventFilter/L1TRawToDigi/plugins/implementations_stage2/GTSetup.cc

Line 131 in c0b5b26

res[22] = caloSummary_unp;

I need to wait until I have test crate records before I can test this non-trivially however. (Seems like it wont unpack empty/unused records?).

EventFilter/L1TRawToDigi/plugins/implementations_stage2/GTCollections.h

cmsbuild · 2024-06-26T18:12:04Z

-1

Failed Tests: RelVals
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-547e2e/40102/summary.html
COMMIT: 3d72abe
CMSSW: CMSSW_14_1_X_2024-06-26-1200/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/44222/40102/install.sh to create a dev area with all the needed externals and cmssw changes.

DAS Queries: The DAS query tests failed, see the summary page for details.

RelVals

29634.911

----- Begin Fatal Exception 26-Jun-2024 19:58:31 CEST-----------------------
An exception of category 'OutOfBound' occurred while
   [0] Processing  Event run: 1 lumi: 1 event: 1 stream: 0
   [1] Running path 'HLTriggerFinalPath'
   [2] Prefetching for module TriggerSummaryProducerAOD/'hltTriggerSummaryAOD'
   [3] Prefetching for module L1HPSPFTauProducer/'l1tHPSPFTauProducer'
   [4] Prefetching for module L1TPFCandMultiMerger/'l1tLayer1'
   [5] Prefetching for module L1TCorrelatorLayer1Producer/'l1tLayer1HGCal'
   [6] Prefetching for module PFClusterProducerFromHGC3DClusters/'l1tPFClustersFromHGC3DClusters'
   [7] Calling method for module HGCalBackendLayer2Producer/'l1tHGCalBackEndLayer2Producer'
Exception Message:
TC X1 = 10295.1 out of the seeding histogram bounds 0.076 - 0.58
----- End Fatal Exception -------------------------------------------------

aloeliger · 2024-06-26T19:55:32Z

That's a phase 2 issue, which should be impossible for this to affect

aloeliger · 2024-06-26T19:56:12Z

+l1

aloeliger · 2024-06-26T19:57:13Z

Wrong PR. But whatever.

aloeliger · 2024-06-26T20:06:15Z

please test

Hoping this is temporary

iarspider · 2024-06-26T20:18:59Z

TC X1 = 10295.1 out of the seeding histogram bounds 0.076 - 0.58

Known issue: #41451 .

cmsbuild · 2024-06-26T23:09:50Z

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-547e2e/40106/summary.html
COMMIT: 3d72abe
CMSSW: CMSSW_14_1_X_2024-06-26-1200/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/44222/40106/install.sh to create a dev area with all the needed externals and cmssw changes.

DAS Queries: The DAS query tests failed, see the summary page for details.

Comparison Summary

Summary:

You potentially removed 1 lines from the logs
ROOTFileChecks: Some differences in event products or their sizes found
Reco comparison results: 10 differences found in the comparisons
DQMHistoTests: Total files compared: 48
DQMHistoTests: Total histograms compared: 3345088
DQMHistoTests: Total failures: 6
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 3345062
DQMHistoTests: Total skipped: 20
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 0.0 KiB( 47 files compared)
Checked 202 log files, 165 edm output root files, 48 DQM output files
TriggerResults: no differences found

Martin-Grunewald · 2024-06-27T12:01:17Z

+1

cmsbuild · 2024-06-27T12:01:45Z

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @sextonkennedy, @rappoccio, @antoniovilela (and backports should be raised in the release meeting by the corresponding L2)

antoniovilela · 2024-06-27T18:11:20Z

@aloeliger @cms-sw/l1-l2
Just confirming that this includes the re-revert of #45037?

antoniovilela · 2024-06-27T18:12:26Z

+1

aloeliger · 2024-06-27T19:01:08Z

@aloeliger @cms-sw/l1-l2
Just confirming that this includes the re-revert of #45037?

@antoniovilela That is correct. bcb0dab should rerevert #45037 (I.e. it is included again)

antoniovilela · 2024-06-27T20:02:41Z

@aloeliger @cms-sw/l1-l2
Just confirming that this includes the re-revert of #45037?

@antoniovilela That is correct. bcb0dab should rerevert #45037 (I.e. it is included again)

Thanks.

Martin-Grunewald · 2024-07-08T11:48:15Z

L1Trigger/L1TGlobal/plugins/L1TGlobalProducer.cc

@@ -51,6 +51,8 @@ void L1TGlobalProducer::fillDescriptions(edm::ConfigurationDescriptions& descrip
      ->setComment("InputTag for Calo Trigger EtSum (required parameter:  default value is invalid)");
  desc.add<edm::InputTag>("EtSumZdcInputTag", edm::InputTag(""))
      ->setComment("InputTag for ZDC EtSums Plus and Minus (required parameter:  default value is invalid)");
+  desc.add<edm::InputTag>("CICADAInputTag", edm::InputTag(""))
+      ->setComment("InputTag for CICADA Anomaly Detection (required parameter: default value is invalid)");


So now that this PR and its backport are in 14_1 / 14_0, what value for this new parameter should be used at HLT level running the L1TGlobalProducer? hltGtStage2ObjectMap = cms.EDProducer( "L1TGlobalProducer",...

@Martin-Grunewald Do you want emulator or DAQ values?

For emulator it should be this guy:

https://github.com/cms-sw/cmssw/blob/master/L1Trigger/L1TCaloLayer1/python/simCaloStage2Layer1Summary_cfi.py

For unpacked, here:

https://github.com/cms-sw/cmssw/blob/master/EventFilter/L1TRawToDigi/python/caloLayer1Digis_cfi.py

we don't show up in the production uGT record though, so I wouldn't expect that to be valid yet.

So in HLT where we run hltGtStage2Digis = cms.EDProducer( "L1TRawToDigi",...
it would be hltGtStage2ObjectMap.CICADAInputTag = cms.InputTag("hltGtStage2Digis","CICADAScore"),, correct?

Can this discussion be documented in a CMSHLT Jira ticket please @aloeliger ?

https://its.cern.ch/jira/browse/CMSHLT-3280

cmsbuild added this to the CMSSW_14_1_X milestone Feb 27, 2024

cmsbuild added l1-pending pending-signatures tests-pending orp-pending code-checks-pending labels Feb 27, 2024

cmsbuild mentioned this pull request Feb 28, 2024

Get AXOL1TL model version from menu as of utm v0.12.0 #44054

Merged

aloeliger marked this pull request as ready for review March 6, 2024 15:02

cmsbuild added code-checks-rejected code-checks-pending and removed code-checks-pending code-checks-rejected labels Mar 6, 2024

cmsbuild added code-checks-approved and removed code-checks-pending labels Mar 6, 2024

cmsbuild added the hlt-pending label Mar 6, 2024

Martin-Grunewald reviewed Mar 6, 2024

View reviewed changes

EventFilter/L1TRawToDigi/plugins/implementations_stage2/CaloSummaryUnpacker.cc Outdated Show resolved Hide resolved

Martin-Grunewald reviewed Mar 6, 2024

View reviewed changes

EventFilter/L1TRawToDigi/plugins/implementations_stage2/GTCollections.h Outdated Show resolved Hide resolved

aloeliger force-pushed the CICADA_uGT_Emulator branch from c0b5b26 to d7cb22a Compare March 7, 2024 10:13

cmsbuild added code-checks-pending and removed code-checks-approved labels Mar 7, 2024

cmsbuild added the tests-started label Jun 26, 2024

cmsbuild added tests-rejected and removed tests-started labels Jun 26, 2024

cmsbuild added l1-approved and removed l1-pending labels Jun 26, 2024

cmsbuild added tests-started and removed tests-rejected labels Jun 26, 2024

cmsbuild added tests-approved and removed tests-started labels Jun 26, 2024

cmsbuild added hlt-approved fully-signed and removed hlt-pending pending-signatures labels Jun 27, 2024

cmsbuild added orp-approved and removed orp-pending labels Jun 27, 2024

cmsbuild merged commit 307f456 into cms-sw:master Jun 27, 2024
11 checks passed

Martin-Grunewald reviewed Jul 8, 2024

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

CICADA-uGT emulator additions #44222

CICADA-uGT emulator additions #44222

aloeliger commented Feb 27, 2024 •

edited

Loading

cmsbuild commented Feb 27, 2024 •

edited

Loading

cmsbuild commented Feb 27, 2024

aloeliger commented Mar 6, 2024

cmsbuild commented Mar 6, 2024

cmsbuild commented Mar 6, 2024

cmsbuild commented Mar 6, 2024

aloeliger commented Mar 6, 2024

cmsbuild commented Mar 6, 2024

Martin-Grunewald commented Mar 6, 2024

aloeliger commented Mar 6, 2024

cmsbuild commented Jun 26, 2024

aloeliger commented Jun 26, 2024

aloeliger commented Jun 26, 2024

aloeliger commented Jun 26, 2024

aloeliger commented Jun 26, 2024

iarspider commented Jun 26, 2024

cmsbuild commented Jun 26, 2024

Martin-Grunewald commented Jun 27, 2024

cmsbuild commented Jun 27, 2024

antoniovilela commented Jun 27, 2024

antoniovilela commented Jun 27, 2024

aloeliger commented Jun 27, 2024 •

edited

Loading

antoniovilela commented Jun 27, 2024

Martin-Grunewald Jul 8, 2024

aloeliger Jul 8, 2024

aloeliger Jul 8, 2024

Martin-Grunewald Jul 8, 2024

mmusich Jul 8, 2024

Martin-Grunewald Jul 8, 2024

CICADA-uGT emulator additions #44222

CICADA-uGT emulator additions #44222

Conversation

aloeliger commented Feb 27, 2024 • edited Loading

PR description:

PR validation:

If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:

cmsbuild commented Feb 27, 2024 • edited Loading

cmsbuild commented Feb 27, 2024

aloeliger commented Mar 6, 2024

cmsbuild commented Mar 6, 2024

cmsbuild commented Mar 6, 2024

cmsbuild commented Mar 6, 2024

aloeliger commented Mar 6, 2024

cmsbuild commented Mar 6, 2024

Martin-Grunewald commented Mar 6, 2024

aloeliger commented Mar 6, 2024

cmsbuild commented Jun 26, 2024

RelVals

aloeliger commented Jun 26, 2024

aloeliger commented Jun 26, 2024

aloeliger commented Jun 26, 2024

aloeliger commented Jun 26, 2024

iarspider commented Jun 26, 2024

cmsbuild commented Jun 26, 2024

Comparison Summary

Martin-Grunewald commented Jun 27, 2024

cmsbuild commented Jun 27, 2024

antoniovilela commented Jun 27, 2024

antoniovilela commented Jun 27, 2024

aloeliger commented Jun 27, 2024 • edited Loading

antoniovilela commented Jun 27, 2024

Martin-Grunewald Jul 8, 2024

Choose a reason for hiding this comment

aloeliger Jul 8, 2024

Choose a reason for hiding this comment

aloeliger Jul 8, 2024

Choose a reason for hiding this comment

Martin-Grunewald Jul 8, 2024

Choose a reason for hiding this comment

mmusich Jul 8, 2024

Choose a reason for hiding this comment

Martin-Grunewald Jul 8, 2024

Choose a reason for hiding this comment

aloeliger commented Feb 27, 2024 •

edited

Loading

cmsbuild commented Feb 27, 2024 •

edited

Loading

aloeliger commented Jun 27, 2024 •

edited

Loading