Add Unpacker for L1T Calo Layer 1 to unpack CICADA #45037

aloeliger · 2024-05-24T09:45:09Z

PR description:

This PR adds an unpacker to the L1T Calo Layer 1 Unpacking Setup to explicitly unpack CICADA (found in FED 1356, AMC slot 7). This PR relies on data-types introduced in it's companion PR #44222. #44222 Unpacks the uGT received CICADA scores, while this PR unpacks the Calo sent CICADA scores.

PR validation:

All code compiles and has had code formatting applied. This Unpacker has also been tested against events with the CaloSummary/CICADA cards in DAQ. A screenshot of some debugging output of the development of the unpacker is attached. On the left side you can see the unpacked data from FED 1356, which matches the dumped FED output seen on the right (CICADA/CaloSummary highlighted)

Also shown is a demonstration that the correct CICADA bits are received in the correct order, and the resulting constructed score, matched to the expected hex number (when transformed into a 16 bit fixed-point number, with 8 integer bits, and 8 bits after the decimal point, to within machine epsilon, or display precision).

If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:

This PR is not a backport, and is not expected to need a backport. It is however, a feature of an upcoming data-taking tool, so it is not impossible that a backport will be requested for it.

@eyigitba @slaurila FYI, this is one of the DPG requested pieces for CICADA that we have made for our own commissioning purposes now. Packers will be made when we are satisfied with commissioning progress using these unpackers.

…CICADA score from AMC Slot 7

cmsbuild · 2024-05-24T09:45:33Z

cms-bot internal usage

cmsbuild · 2024-05-24T09:50:30Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-45037/40336

This PR adds an extra 24KB to repository

cmsbuild · 2024-05-24T09:50:53Z

A new Pull Request was created by @aloeliger for master.

It involves the following packages:

EventFilter/L1TRawToDigi (l1)

@epalencia, @cmsbuild, @aloeliger can you please review it and eventually sign? Thanks.
@eyigitba, @thomreis, @Martin-Grunewald, @missirol, @dinyar this is something you requested to watch as well.
@antoniovilela, @sextonkennedy, @rappoccio you are the release manager for this.

cms-bot commands are listed here

aloeliger · 2024-05-24T09:51:26Z

test parameters:
pull_requests = #44222

aloeliger · 2024-05-24T09:52:14Z

please test

cmsbuild · 2024-05-24T12:53:17Z

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-a1eda2/39510/summary.html
COMMIT: 077e16d
CMSSW: CMSSW_14_1_X_2024-05-23-2300/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/45037/39510/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

You potentially removed 2 lines from the logs
ROOTFileChecks: Some differences in event products or their sizes found
Reco comparison results: 16 differences found in the comparisons
DQMHistoTests: Total files compared: 48
DQMHistoTests: Total histograms compared: 3338862
DQMHistoTests: Total failures: 9
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 3338833
DQMHistoTests: Total skipped: 20
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 0.0 KiB( 47 files compared)
Checked 202 log files, 165 edm output root files, 48 DQM output files
TriggerResults: no differences found

cmsbuild · 2024-06-21T15:24:33Z

-code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-45037/40671

This PR adds an extra 24KB to repository

Code check has found code style and quality issues which could be resolved by applying following patch(s)

code-format:
https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-45037/40671/code-format.patch
e.g. curl -k https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-45037/40671/code-format.patch | patch -p1
You can also run scram build code-format to apply code format directly

cmsbuild · 2024-06-21T15:40:00Z

Pull request #45037 was updated. @cmsbuild, @aloeliger, @epalencia can you please check and sign again.

aloeliger · 2024-06-21T15:40:31Z

please test

cmsbuild · 2024-06-21T19:34:10Z

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-a1eda2/40014/summary.html
COMMIT: bf7e838
CMSSW: CMSSW_14_1_X_2024-06-20-2300/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/45037/40014/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

You potentially added 5 lines to the logs
ROOTFileChecks: Some differences in event products or their sizes found
Reco comparison results: 4 differences found in the comparisons
DQMHistoTests: Total files compared: 48
DQMHistoTests: Total histograms compared: 3345018
DQMHistoTests: Total failures: 3
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 3344995
DQMHistoTests: Total skipped: 20
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 0.0 KiB( 47 files compared)
Checked 202 log files, 165 edm output root files, 48 DQM output files
TriggerResults: no differences found

aloeliger · 2024-06-24T21:23:42Z

+l1

uGT unpacker is now ready

cmsbuild · 2024-06-24T21:24:04Z

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @sextonkennedy, @rappoccio, @antoniovilela (and backports should be raised in the release meeting by the corresponding L2)
Notice This PR was tested with additional Pull Request(s), please also merge them if necessary: #44222

rappoccio · 2024-06-25T15:40:04Z

+1

mmusich · 2024-06-26T05:21:59Z

Congratulations. Merging this PR alone completely obliterated the IB CMSSW_14_1_X_2024-06-25-2300, https://cmssdt.cern.ch/SDT/html/cmssdt-ib/#/ib/CMSSW_14_1_X

fwyzard · 2024-06-26T05:34:07Z

I guess that's because:

Notice This PR was tested with additional Pull Request(s), please also merge them if necessary: #44222

which is not yet ready to be merged ?

fwyzard · 2024-06-26T05:36:48Z

EventFilter/L1TRawToDigi/plugins/implementations_stage2/CICADAUnpacker.cc

+        std::vector<uint32_t> cicadaWords = {0, 0, 0, 0};
+        //the last 4 words are CICADA words
+        for (uint32_t i = 2; i < 6; ++i) {
+          cicadaWords.at(i - 2) = ((block.payload().at(i)) >> 28);
+        }
+
+        float cicadaScore = convertCICADABitsToFloat(cicadaWords);
+        res->push_back(0, cicadaScore);
+        return true;
+      }
+    }
+
+    //convert the 4 CICADA bits/words into a proper number
+    float CICADAUnpacker::convertCICADABitsToFloat(const std::vector<uint32_t>& cicadaBits) {
+      uint32_t tempResult = 0;
+      tempResult |= cicadaBits.at(0) << 12;
+      tempResult |= cicadaBits.at(1) << 8;
+      tempResult |= cicadaBits.at(2) << 4;
+      tempResult |= cicadaBits.at(3);
+      float result = 0.0;
+      result = (float)tempResult * pow(2.0, -8);
+      return result;


This can be replaced by a simpler implementation, see https://github.com/cms-sw/cmssw/pull/44222/files#r1653052470 .

In fact, it would be better to share the duplicate code between EventFilter/L1TRawToDigi/plugins/implementations_stage2/CICADAUnpacker.cc and EventFilter/L1TRawToDigi/plugins/implementations_stage2/CaloSummaryUnpacker.cc.

I am working on this this morning, however just for posterity's sake, I will note that the exact bits grabbed are ever so slightly different, being the first 4 bits of the last 4 words for FED 1356, instead of the first 4 bits of the first 4 words for FEDs 1404 & 1405.

In any case, you are entirely correct that this could be simplified down from the ad-hoc first drafts. I can do that for the uGT one while the HLT experts review. I am not sure what happens for this one now.

smuzaffar · 2024-06-26T07:40:05Z

@cms-sw/orp-l2 , we might not be able to converge on #44222 before 11h00 IB. I would suggest to revert this PR for 11h00 ? Any objections @cms-sw/l1-l2 ?

smuzaffar · 2024-06-26T07:41:26Z

I have opened #45308 ( which is revert of this PR)

aloeliger · 2024-06-26T07:50:39Z

No objections here. I can sign the revert quickly.

My apologies for this, I thought this was tested and tagged with the uGT unpacker as external.

mmusich · 2024-06-26T07:56:23Z

My apologies for this, I thought this was tested and tagged with the uGT unpacker as external.

I think everything was done correctly on your side, but the requires-external flag was neglected when merging as pointed out at #45037 (comment) (see cms-sw/cms-bot#2147 for a discussion of this general problem).

Add unpacker for L1T Calo Layer 1 to unpack FED 1356 to retrieve the …

077e16d

…CICADA score from AMC Slot 7

cmsbuild added this to the CMSSW_14_1_X milestone May 24, 2024

cmsbuild added l1-pending pending-signatures tests-pending orp-pending code-checks-pending labels May 24, 2024

cmsbuild added code-checks-approved and removed code-checks-pending labels May 24, 2024

cmsbuild added the requires-external label May 24, 2024

cmsbuild added tests-started and removed tests-pending labels May 24, 2024

cmsbuild added tests-approved and removed tests-started labels May 24, 2024

mmusich mentioned this pull request Jun 11, 2024

CICADA-uGT emulator additions #44222

Merged

Change CICADA unpacker to read the last 4 words instead of first 4

92c99c1

cmsbuild added tests-pending code-checks-pending and removed tests-approved code-checks-approved labels Jun 21, 2024

cmsbuild added code-checks-rejected and removed code-checks-pending labels Jun 21, 2024

apply formatting

bf7e838

cmsbuild added code-checks-approved and removed code-checks-pending labels Jun 21, 2024

cmsbuild added tests-started and removed tests-pending labels Jun 21, 2024

cmsbuild added tests-approved and removed tests-started labels Jun 21, 2024

cmsbuild added l1-approved fully-signed and removed l1-pending pending-signatures labels Jun 24, 2024

aloeliger mentioned this pull request Jun 24, 2024

[14_0] Add Unpacker for L1T Calo Layer 1 to unpack CICADA #45294

Closed

cmsbuild added orp-approved and removed orp-pending labels Jun 25, 2024

cmsbuild merged commit c0b1550 into cms-sw:master Jun 25, 2024
12 checks passed

mmusich mentioned this pull request Jun 26, 2024

Updates to include HTMHF triggers in GT emulator #45295

Merged

fwyzard reviewed Jun 26, 2024

View reviewed changes

smuzaffar mentioned this pull request Jun 26, 2024

Revert "Add Unpacker for L1T Calo Layer 1 to unpack CICADA" #45308

Merged

mmusich mentioned this pull request Jun 26, 2024

Update heavy-ion eras for 2024 + add MC RelVal workflows #45307

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add Unpacker for L1T Calo Layer 1 to unpack CICADA #45037

Add Unpacker for L1T Calo Layer 1 to unpack CICADA #45037

aloeliger commented May 24, 2024

cmsbuild commented May 24, 2024 •

edited

Loading

cmsbuild commented May 24, 2024

cmsbuild commented May 24, 2024

aloeliger commented May 24, 2024

aloeliger commented May 24, 2024

cmsbuild commented May 24, 2024

cmsbuild commented Jun 21, 2024

cmsbuild commented Jun 21, 2024

aloeliger commented Jun 21, 2024

cmsbuild commented Jun 21, 2024

aloeliger commented Jun 24, 2024

cmsbuild commented Jun 24, 2024

rappoccio commented Jun 25, 2024

mmusich commented Jun 26, 2024 •

edited

Loading

fwyzard commented Jun 26, 2024

fwyzard Jun 26, 2024

aloeliger Jun 26, 2024 •

edited

Loading

smuzaffar commented Jun 26, 2024

smuzaffar commented Jun 26, 2024

aloeliger commented Jun 26, 2024

mmusich commented Jun 26, 2024

Add Unpacker for L1T Calo Layer 1 to unpack CICADA #45037

Add Unpacker for L1T Calo Layer 1 to unpack CICADA #45037

Conversation

aloeliger commented May 24, 2024

PR description:

PR validation:

If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:

cmsbuild commented May 24, 2024 • edited Loading

cmsbuild commented May 24, 2024

cmsbuild commented May 24, 2024

aloeliger commented May 24, 2024

aloeliger commented May 24, 2024

cmsbuild commented May 24, 2024

Comparison Summary

cmsbuild commented Jun 21, 2024

cmsbuild commented Jun 21, 2024

aloeliger commented Jun 21, 2024

cmsbuild commented Jun 21, 2024

Comparison Summary

aloeliger commented Jun 24, 2024

cmsbuild commented Jun 24, 2024

rappoccio commented Jun 25, 2024

mmusich commented Jun 26, 2024 • edited Loading

fwyzard commented Jun 26, 2024

fwyzard Jun 26, 2024

Choose a reason for hiding this comment

aloeliger Jun 26, 2024 • edited Loading

Choose a reason for hiding this comment

smuzaffar commented Jun 26, 2024

smuzaffar commented Jun 26, 2024

aloeliger commented Jun 26, 2024

mmusich commented Jun 26, 2024

cmsbuild commented May 24, 2024 •

edited

Loading

mmusich commented Jun 26, 2024 •

edited

Loading

aloeliger Jun 26, 2024 •

edited

Loading