[CPP20] Cleanup BuildFile.xml for Alignment/OfflineValidation #44538
Conversation
|
Please test for CMSSW_14_1_CPP20_X |
|
cms-bot internal usage |
|
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-44538/39671
|
|
A new Pull Request was created by @iarspider for master. It involves the following packages:
@consuegs, @perrotta, @saumyaphor4252 can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
|
-1 Failed Tests: Build The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:
You can see more details here: BuildI found compilation error when building: Copying tmp/el8_amd64_gcc12/src/Alignment/OfflineValidation/bin/GCPtrends/GCPtrends to productstore area:
>> Compiling src/Alignment/OfflineValidation/bin/MTSmerge.cc
>> Compiling src/Alignment/OfflineValidation/bin/Options.cc
In file included from src/Alignment/OfflineValidation/bin/MTSmerge.cc:20:
/data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_14_1_CPP20_X_2024-03-22-1100/src/Alignment/OfflineValidation/macros/trackSplitPlot.C: In function 'TCanvas* trackSplitPlot(Int_t, TString*, TString*, TString, TString, Bool_t, Bool_t, Bool_t, TString, std::ostream&)':
/data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_14_1_CPP20_X_2024-03-22-1100/src/Alignment/OfflineValidation/macros/trackSplitPlot.C:390:68: error: reference to 'identity' is ambiguous
390 | if (type == Histogram && !pull && any_of(begin(used), end(used), identity)) {
| ^~~~~~~~
In file included from /cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02829/el8_amd64_gcc12/external/gcc/12.3.1-40d504be6370b5a30e3947a6e575ca28/include/c++/12.3.1/bits/iterator_concepts.h:38,
from /cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02829/el8_amd64_gcc12/external/gcc/12.3.1-40d504be6370b5a30e3947a6e575ca28/include/c++/12.3.1/bits/stl_iterator_base_types.h:71,
from /cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02829/el8_amd64_gcc12/external/gcc/12.3.1-40d504be6370b5a30e3947a6e575ca28/include/c++/12.3.1/bits/stl_construct.h:61,
|
|
Please test for CMSSW_14_1_CPP20_X |
cmsbuild
added
tests-started
code-checks-pending
and removed
tests-rejected
code-checks-approved
labels
|
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-44538/39675
|
|
Pull request #44538 was updated. @saumyaphor4252, @consuegs, @perrotta can you please check and sign again. |
Well, the duplicated -Wall flag was not removed, actually: @iarspider do you plan to profit of this PR and do it? And, just for my understanding: is it the -o3 flag that disables the debug symbols? |
| @@ -1,4 +1,4 @@ | |||
| <flags CXXFLAGS="-g -Wall -O3 -Wall -std=c++17 -lASImage -lMultiProc" /> | |||
| <flags CXXFLAGS="-Wall -O3 -Wall -lASImage -lMultiProc" /> | |||
There was a problem hiding this comment.
please keep the the debug symbols (and remove the duplicated -Wall).
|
Please test for CMSSW_14_1_CPP20_X |
cmsbuild
added
tests-started
code-checks-pending
and removed
tests-approved
code-checks-approved
labels
|
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-44538/39678
|
|
Pull request #44538 was updated. @saumyaphor4252, @consuegs, @perrotta can you please check and sign again. |
|
+alca |
cmsbuild
added
alca-approved
fully-signed
and removed
alca-pending
pending-signatures
labels
|
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @sextonkennedy, @antoniovilela, @rappoccio (and backports should be raised in the release meeting by the corresponding L2) |
|
+1 |
PR description:
In CPP20 IBs, the following warning is emitted:
This PR removes explicit setting of C++ standard (as well as disabled debug symbols and duplicate
-Wallflag)PR validation:
Bot tests