Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ROOT6] RPageSinkFile is now in ROOT::Experimental::Internal namespace #44032

Merged
merged 2 commits into from
Feb 21, 2024

Conversation

iarspider
Copy link
Contributor

PR description:

RPageSinkFile was moved to a different namespace in root-project/root#14646 .

PR validation:

Bot tests

@cmsbuild
Copy link
Contributor

cmsbuild commented Feb 20, 2024

cms-bot internal usage

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-44032/38966

  • This PR adds an extra 20KB to repository

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @iarspider for master.

It involves the following packages:

  • PhysicsTools/NanoAOD (xpog)

@hqucms, @vlimant, @cmsbuild can you please review it and eventually sign? Thanks.
@gpetruc, @AnnikaStein this is something you requested to watch as well.
@rappoccio, @antoniovilela, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

@makortel
Copy link
Contributor

FYI @dan131riley @Dr15Jones @nsmith-

@iarspider
Copy link
Contributor Author

Testing here: cms-sw/cmsdist#9025

@iarspider
Copy link
Contributor Author

please test for CMSSW_14_1_X

@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-51e7ba/37590/summary.html
COMMIT: d16de7f
CMSSW: CMSSW_14_1_X_2024-02-20-1100/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/44032/37590/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

@vlimant
Copy link
Contributor

vlimant commented Feb 21, 2024

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @rappoccio, @sextonkennedy, @antoniovilela (and backports should be raised in the release meeting by the corresponding L2)

@rappoccio
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit 6ef2ab4 into cms-sw:master Feb 21, 2024
11 checks passed
@aandvalenzuela
Copy link
Contributor

Hello @iarspider, it seems this PR broke ROOT6 IBs CMSSW_14_1_ROOT6_X_2024-02-21-2300

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants