Remove unpackLayer1 option from L1REPACK:Full

[eyigitba]

PR description:

This PR removes the unpackLayer1 from L1REPACK:Full. This was brought into our attention by TSG colleagues and it was causing unrealistic rates when re-emulating data after 2023A.

There might be an underlying reason to why this problem started happening, but for the time being we prefer to remove this option and use unpackHcal directly. This is more in line with how ECAL TPs are used. The unpackLayer1 step was probably an artifact from Run 2, which is not needed anymore.

PR validation:

Validated that the L1REPACK:Full workflows still work after the change and the rates obtained are as expected.

FYI @missirol @savarghe @caruta @aloeliger @epalencia

[cmsbuild]

cms-bot internal usage

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-43981/38894

• This PR adds an extra 16KB to repository

[cmsbuild]

A new Pull Request was created by @eyigitba for master.

It involves the following packages:

• Configuration/StandardSequences (operations)

@cmsbuild, @rappoccio, @davidlange6, @fabiocos, @antoniovilela can you please review it and eventually sign? Thanks.
@Martin-Grunewald, @sameasy, @rovere, @dgulhan, @mmusich, @felicepantaleo, @missirol, @VinInn, @VourMa, @GiacomoSguazzoni, @makortel, @fabiocos, @JanFSchulte, @slomeo, @mtosi this is something you requested to watch as well.
@sextonkennedy, @antoniovilela, @rappoccio you are the release manager for this.

cms-bot commands are listed here

[Martin-Grunewald]

Please make a backport PR to 14_0.

[Martin-Grunewald]

please test

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-ed49cd/37500/summary.html
COMMIT: bd80de9
CMSSW: CMSSW_14_1_X_2024-02-15-1100/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/43981/37500/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

• You potentially removed 104 lines from the logs
• Reco comparison results: 64 differences found in the comparisons
• DQMHistoTests: Total files compared: 48
• DQMHistoTests: Total histograms compared: 3248554
• DQMHistoTests: Total failures: 10377
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3238155
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 47 files compared)
• Checked 200 log files, 161 edm output root files, 48 DQM output files
• TriggerResults: found differences in 3 / 46 workflows

[missirol]

@cms-sw/operations-l2 , this fix (esp. its backport, #43985) is needed for offline trigger studies. Could you please have a look ? Thanks !

[antoniovilela]

+1

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will be automatically merged.