Also remove use of CRM_Utils_Array call since we're sure it's set

…t_id only

…error if the price fields are disabled.

This is a partial of #12065 which is a very simple extraction - only one additional change of moving a variable to a class property

Despite seeming like a lot of change this is mostly just extraction to run via the tests. I can break out into a couple of refactor commits for reviewablility.

I have tested this on mysql 5.6 with full group by mode enabled.

When a custom table is removed from logged tables by hook (e.g a calculated table like a summary table) the logging report
still tries to include it but fails with a fatal error.

This patch excludes it from the list of customDataEnabled logging tables

…r than primary throw DB error

…i version and CMS name

… after searching

CRM-20459: Actively deprecate CRM_Core_OptionGroup::getValue[Sub PR 2]

(dev/core/98) FGB Searching by any Address fields with location type other than primary throw DB error

5.1.0 release notes: updated synopsis

… return a value.

"Payflo" is a different payment processor.

Payflow Pro not payflo

… on getMock in phpunit5

(dev/core/99) Search builder doesn't retain selected (boolean) option after searching

(NFC) Update karma conf for more recent karma

5.2 to master

(NFC) Change use createMock in tests otherwise stick with getMock to fix deprecated warning…

CRM-20922 fix support for passing custom date values via url

CRM-20459: Actively deprecate CRM_Core_OptionGroup::getValue

…ew (#11920)

* CRM-40: Show List of Contributions On Recurring Contribution View

Altered ContributionRecur page so that the list of contributions related to a
recurring contribution are shown when viewing said recurring contribution.

Implemented by running CRM_Contribute_Form_Search ebedded within the page and
including CRM/Contribute/Form/Selector.tpl template within the page's
template. Also included ContributionTotals.tpl to show, which I though could
be cool.

* CRM-40: Don't Use CRM_Contribute_Form_Search to Show Contributions

CRM_Contribute_Form_Search class is very hard to read and maintain, which is
why it was found better to look for related contributions manually and show
them using an ajax datatable.

* CRM-40: Fix Failing Test

* CRM-40: Show Contribution List Using Ajax Call

Added new Page that shows related payments for a given relted contribution in
a data table and included the table on recurring contribution's detail view
using an ajax call.

Notice is visible on add payment processor page

Fix e-notice

…itched to using CRM_Core_Form_Task

…w tokens to work properly (eg. PDF letter)

Add in check of rows

CRM-20459: Actively deprecate CRM_Core_OptionGroup::getValue

Re-Fix Case form task  (export/print not working) (replace quick fix with proper fix)

…ore/#100

Fix Fatal error on membership detail report (with ACLs enabled) dev/core/#100

…rdpress

white space issue

more white space issue

another white space

another white space

…_GROUP_BY_MODE is enabled

…on to support custom data.

Now that we have custom-data-on-any forms that use the api to save can potentially support custom data. This is a
preparatory tidy-up commit. It switches to the api & does minor tidy ups, including using metadata and addField to
add fields. This last part does slightly alter the wording on the form. I think that is OK?

… forms)

Function extraction (Move towards generic custom data support for all entities)

5.2 to master

Run master tests using phpunit5

Fix Relationship Type form to use the metadata for fields & api in postProcess

…auncher

Upgrade Karma phantomjs launcher to latest version

Fix fatal error on logging tab when hook alters logging tables.

It's useful to have two ways of running the Karma test suite:

* For continuous integration, run once and report back with a file.
  (This has been `karma start --browsers PhantomJS --single-run --reporters dots,junit`.)
* For local dev, run in a watch/live/monitoring mode which auto-executes any time you edit the JS code.
  (This has been `karma start`)

This partially reverts a recent change so that the second one works the same
way as before.

(NFC) Fix use of undefined constant USD in MoneyTest

karma.conf.js - Switch singleRun back to `false` default

dev/core#108 reset address array when setting new event location

Currently, when viewing a membership from contact's detailed view (on
memberships tab), it is hard to tell if a membership has any recurring
contributions associated to it, even though you can see all payments done for
the membership.

Added a recurring contributions section below the contributions table
currently being shown, by loading recurring contributions using ajax call to
load list of recurring contributions.

Added recurring contributionslist to membership edit view using ajax call.

ApiExplorer - Output short array syntax

…ibutions-on-membership-modal

dev/core#38 Show Recurring Contributions on Membership Modal View

(dev/core/68) Fix DB Error on 'Find Participant' page when MySQL FULL_GROUP_BY_MODE is enabled

The function has traditionally been in the global namespace, and it
should stay there for backward compatibility.

This patch looks big, but it's really just wrapping code inside new
`namespace ...  { ...  }` blocks.

…namespace

The new helper functions in this file shouldn't be used externally; this
file is just an adapter for backward-compatibility.  External callers should
still use `CRM_Utils_System::version()`, `civicrmVersion()`, or
`version.xml`.

In a typical environment, this is just an unnecessary file-load, and it
makes it harder to (someday) remove/deprecate `civicrm-version.php`.

Ex 1: Running `drush` commands
Ex 2: Running `cv` with `--level=cms-only`

Ex 1: Running `wp-cli` commands
Ex 2: Running `cv` with `--level=cms-only`

Ex 1: Running `drush` commands
Ex 2: Running `cv` with `--level=cms-only`

…sion.php

(NFC) Add unit test of submitting the Pledge Search Form

…updated

Additional fixes

Additional fixes

5.2

…port

Support hooks for MembershipType entity

tpl extraction of shared code for customDataBlock

Preliminary tidy up of  MembershipType form (towards custom data support)

[NFC] Fix leakage of Form entity

Follow up to #12095

Preliminary cleanup for Custom data support for MembershipType form