Use getter function for entity id as on some forms is protected. #12127
Conversation
|
@seamuslee001 @colemanw any chance one of your can merge this - it's a follow up from something v recently merged (per above) |
|
@eileenmcnaughton what if a form doesn't define |
|
@seamuslee001 it is a newly added function currently only called from one form - which is fixed to have that function in this PR |
|
I'm satisfied that this is only affecting the only form that this function uses, however do you think we should do a if function_exists check at all and throw an exception if not to make sure no one adds to the form without adding the relevant function? |
|
@seamuslee001 I think anyone adding it to a form & testing it would see the error pretty clearly! |
|
(ie. a hard fail would be better than a soft fail if they don't add the function) |
Overview
Use a getter function to access $this-_id as on some forms it is protected. Follow up to Follow up to #12095
Before
No change
After
no change
Technical Details
The affected function was extracted in #12095 & is only called from one place. This is a trivial tweak to it
Comments
@mattwire