Preliminary tidy up of MembershipType form (towards custom data support) #12123
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eileenmcnaughton
force-pushed
the
membership_type
branch
from
6929ebe
to
572ff85
Compare
eileenmcnaughton
force-pushed
the
membership_type
branch
from
572ff85
to
1322dc5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Code tidy up (toward work to make custom data available on more forms, if enabled via an extension). Note this is a partial reviewers commit of #12118 - there are still some issues I want to work through but this reduces some 'noise' from those issues
Before
no change
After
no change
Technical Details
This is a reviewers commit on the portion of #12118 that I have reviewed & found straightforward. Adding merge-on-pass.
Changes are
Comments
These changes are preliminary to switching to using the api rather than the BAO function, which is necessary to support custom data on entities that are not enabled in core (we are not anticipating new ones would be enabled in core but extensions can now enable custom data on 'almost' any entity by adding a value to the cg_extends option group'