Add field metadata to MembershipType schema info (xml) #12124
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eileenmcnaughton
force-pushed
the
membership_metadata
branch
from
930b0a3
to
6f85d05
Compare
|
Yes we could add a new key to the xml. I think this would make sense: OTOH I see no problem with just updating the title attribute here. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Per our general code approach - add information as to how to render fields to the MembershipType.xml file for that entity
Before
No change
After
No change
Technical Details
@seamuslee001 @colemanw @tschuettler @mattwire @monishdeb
But, if I start to add these fields to the form using 'addField' instead we get a change of the field labels from
To
The issue is the 'title' fields are defined with quite a bit of context as they might be displayed in a list of 'cross-entity' fields in another context (like api explorer). I wonder if we should add another key - e.g
is_active
Enabled?</in context title>
description
<title>Membership Type Description</title> DescriptionComments
I think this PR is mergeable as it as it does not actually touch the form. The above is a discussion arising from it.