Fix e-notice #12090
Merged
Fix e-notice #12090
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Notice is visible on add payment processor page
|
Change is very straight foward giving it merge on pass |
|
Thanks @seamuslee001 |
|
Agree with this one liner change and safe. Merging as per tag |
|
This patch didn't made into 5.2.2 release |
|
Hmm - we could port to 5.3 rc I guess. Looks like it was merged after that was cut |
|
I just checked & it is already in the 5.3 rc https://github.com/civicrm/civicrm-core/commits/5.3/CRM/Core/Form.php so a fix will be in next Wed release |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Fix e-notice
Before
After
Fixed
Technical Details
@monishdeb
Comments
This is a trivial unreleased regression