Fix Fatal error on membership detail report (with ACLs enabled) dev/core/#100 #12094
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
(CiviCRM Review Template WORD-1.1)
Adding merge on pass |
|
merging per tag |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Fix fatal error on membership detail report when acls enabled
Before
Fatal error
After
no error
Technical Details
Alternative to #12077 and #11948 - from my analysis this is the right fix because the ONLY thing the postProcess hook does is add a line that breaks stuff. If we merge one of the others then once someone finally goes 'lets remove this function that is an unnecessary override' the ACLs will break
Comments