(dev/core/100) Membership Detail report throw DB error

[yashodha]

Overview

Membership Detail report throw DB error

Before

DB error appears as aclFrom clause is applied again in setFromBase function here https://github.com/civicrm/civicrm-core/blob/master/CRM/Report/Form.php#L5071

After

Results appear as expected.

[eileenmcnaughton]

@yashodha I worked on this earlier & reviewed another patch - from my testing simply removing the entire postProcess function worked & seemed like the best fix - can you see what you think of that approach?

[eileenmcnaughton]

This is the original PR on this issue #11948 - you can see it stalled because I wasn't there with the decision in that PR to move a line around.

I'd love to get this merged & am even happy to write the required unit test - but I want to look at removing that postProcess first because from what I can see it's an override that only serves to double-add the permission - which makes it the best candidate fix I think

[eileenmcnaughton]

Closing as Seamus reviewed alternate fix & now merged