core/issues/74 - 'Price Set Details for Event Participants' gives DB …

[yashodha]

…error if the price fields are disabled.

Overview

Steps to replicate:

1. Create a price set and associate with an event.
2. Register a participant with the event.
3. Disable the price fields.
4. Go to Custom Searches > Price Set Details for Event Participants, search with the said event.

It throws DB error

Before

After

https://lab.civicrm.org/dev/core/issues/74

[seamuslee001]

Jenkins re test this please

[jitendrapurohit]

I was able to replicate the error but it wasn't fixed for me after the applying the patch. I disabled the price field and the screenshot pasted above is shown as below -

[eileenmcnaughton]

I'm going to merge this - it's not clear it fixes the problem but it does make sense NOT to do that query if $values is empty.

I've let this change squeak through due to it only adding an 'if' that I believe would never be a problem. However, it really should have had
a) a unit test
b) a timely response to the reviewer

I won't close the issue because it's not clear it's fixed

@yashodha @nganivet - you can mark one off your list of PRs to work through review or close