Payflow Pro not payflo

[xurizaemon]

Overview

Honestly, I just wanted to correct the typing of "payflo" in one error message (because it refers to a different payment processor). Using the right words / terms ▶️ less confusion for users.

Before

Error message refers to "payflo"

After

Error message refers to "Payflow Pro", the payment processor in question.

Technical Details

• This changes some error messages to the consistent naming (may be implications for translation).
• Also some comment cleanups.
• Also notes that there's a getFoo() function which doesn't seem to return a value, printing instead.

[seamuslee001]

Jenkins re test this please

[seamuslee001]

@xurizaemon are you able to squish this into 1 commit and fix the style issue reported by Jenkins?

[xurizaemon]

Three commits for clarity IMO @seamuslee001 - wanted to separate the docs changes from the functional change. Happy for you to squash on merge if that's your jam, but putting all that docs cleanup in the same commit is less useful history to me.

I don't mind dropping out the "PayFlowPro" => "Payflow Pro" change if you want? Depends if we think it'll really affect people to break translation ... I don't know if the processor is well used and I know we're hoping to remove core processors "one day".

[xurizaemon]

Updated with fixes for the two remaining "You must use "/**" style comments for a function comment" warnings.

[xurizaemon]

What do you make of that getRecurringTransactionStatus() that doesn't return anything @seamuslee001 @eileenmcnaughton ? Is that potentially something to care about or is it a special use of the get prefix?

Feels like Payflow Pro has been in chat / SE a bit since some recent release. It's not one I've heard mentioned much?

[seamuslee001]

Giving this merge on pass, all the changes relate to either comment blocks or correcting typos in error messages

[seamuslee001]

@xurizaemon I believe its a very small payment processor, i believe there was an issue with a recent DB upgrade that stuffed up the formatting of amount passed to the processor. In regards to this particular piece of code it is an oddball however it doesn't appear to be used at all doing a grep in the core code there are only 1 other reference apart from the function it's self and its commented out

seamus@civicrmdevelopment:~/buildkit/build/47-test/sites/all/modules/civicrm$ grep -ir 'getRecurringTransactionStatus' *
CRM/Core/Payment/PayflowPro.php:  public function getRecurringTransactionStatus($recurringProfileID, $processorID) {
CRM/Core/Payment/PayflowPro.php:    //     c  $trythis =        $this->getRecurringTransactionStatus($recurringProfileID,17);

I'm going to merge this as the changes are straight forward and i don't think the issue of getRecurringTransactionStatus should hold up this PR