fix(vehicle velocity converter): suppress warnings #295

h-ohta · 2022-01-25T06:53:31Z

Related Issue(required)

Description(required)

This PR has below changes.

suppess warnings -Wdeprecated-declarations
fix compile options

Review Procedure(required)

Related PR(optional)

Pre-Review Checklist for the PR Author

PR Author should check the checkboxes below when creating the PR.

Read commit-guidelines
Assign PR to reviewer

If you are adding new package following items are required:

Documentation with description of the package is available
A sample launch file and parameter file are available if the package contains executable nodes

Checklist for the PR Reviewer

Reviewers should check the checkboxes below before approval.

Commits are properly organized and messages are according to the guideline
PR title describes the changes

Post-Review Checklist for the PR Author

PR Author should check the checkboxes below before merging.

All open points are addressed and tracked via issues or tickets

CI Checks

Build and test for PR / build-and-test-pr: Required to pass before the merge.
Build and test for PR / clang-tidy-pr: NOT required to pass before the merge. It is up to the reviewer(s). Found false positives? See the [guidelines][clang-tidy-guidelines].
Check spelling: NOT required to pass before the merge. It is up to the reviewer(s). See here if you want to add some words to the spell check dictionary.

Signed-off-by: h-ohta <hiroki.ota@tier4.jp>

Signed-off-by: Takamasa Horibe <horibe.takamasa@gmail.com>

* rename gnss package (autowarefoundation#714) Signed-off-by: Yamato Ando <yamato.ando@gmail.com> * Avoid setting CMAKE_BUILD_TYPE=Release in each CMakeLists.txt (autowarefoundation#720) * remove set CMAKE_BUILD_TYPE Release in each CMakeLists.txt * remove set CMAKE_BUILD_TYPE Release in ndt_pcl_modified * set compile options for debug in ndt_omp * Fix indent * add warning if -DCMAKE_BUILD_TYPE=Release is not set in ndt_omp Co-authored-by: Kenji Miyake <31987104+kenji-miyake@users.noreply.github.com> * remove ROS1 packages temporarily Signed-off-by: mitsudome-r <ryohsuke.mitsudome@tier4.jp> * Revert "remove ROS1 packages temporarily" This reverts commit bc523d679e6737ec37be4fdcbdedca141411bd9d. Signed-off-by: mitsudome-r <ryohsuke.mitsudome@tier4.jp> * add COLCON_IGNORE to ros1 packages Signed-off-by: mitsudome-r <ryohsuke.mitsudome@tier4.jp> * ROS2 Porting: geo_pos_conv (#8) * Convert to ROS2 package - Update changelog -> 2.0.0 - Update package xml to use the ROS2 xml schema - Update CMakelist with ament cmake commands - Add ROS2 compile options * Convert CMakelist for foxy * Clean up - Remove comments * Remove colcon ignore * Rename launch files to launch.xml (autowarefoundation#28) * ROS2 Porting: gnss_poser (autowarefoundation#18) * Fix CMakelist - Add ublox_msgs package dependency - Rename header files to use the .hpp extention - Remove colcon ignore - Fix Cmake ref to ublox in dependency * Fix compilation issues with convert.hpp - Add sensor_msgs::NavSatFix header which was missing before (?) - Remove logging for now - Contains warnings - geographic lib error polymorphous error - Fix geographic lib -Wcatch-value warnings - Add ifndef guard in gnss_stat.hpp * First pass - successful compilation - Fix CMakelist geographic library - Remove references to main ROS functions - Convert msg references - Add ifndef guards - Convert tf2 methods - Add functionality back - Fix type errors * Add publishers and subscribers - Add parameters * Convert launch files to ROS2 format * Add logging * Convert to component * Fix define guards to follow ROS2/Google style * Add -Werror compile flag * Clean up * Fix CMakelist to allow for the node to be found via ros2 launch - Revert filenames so it is easier to review * Address PR Comments: - Fix CMakelist and package.xml - Remove redundant depend/exec_depend calls - Remove redundant find_package calls - Explicitly add headers to the library * Address PR comments: - Revert removal of GNSSPoser namespace - Use std::make_shared in place of new - Reorder includes to conform with standard * Address PR Comments: - Rename variable to conform with the google style guide - Use the node clock in logging method calls * Address PR Comment: - Convert transform broadcaster to shared pointer * Address PR comment: - Remove -Werror compile flag post discussion * fix duration unit for RCLCPP_*_THROTTLE (autowarefoundation#75) Signed-off-by: Takamasa Horibe <horibe.takamasa@gmail.com> * [gnss_poser] switch broadcaster to full member... (autowarefoundation#136) instead of `shared_ptr` to avoid undefined behavior when executing the node because it used `shared_from_this()` in the constructor * Adjust copyright notice on 532 out of 699 source files (autowarefoundation#143) * Use quotes for includes where appropriate (autowarefoundation#144) * Use quotes for includes where appropriate * Fix lint tests * Make tests pass hopefully * Run uncrustify on the entire Pilot.Auto codebase (autowarefoundation#151) * Run uncrustify on the entire Pilot.Auto codebase * Exclude open PRs * ROS2 Linting: geo_pos_conv (autowarefoundation#165) * Add linters and fix linter issues - convert Cmake to use ament_cmake_auto * Address PR comments: - Remove unneeded cast - Throw error instead of setting default values to zero * ROS2 Linting: gnss_poser (autowarefoundation#166) * Add linting and fix litner errors * Address PR comment: - Use author name instead of user - Remove ROS2 maintainer (remnants of older porting) * apply env_var to use_sim_time (autowarefoundation#222) * [gnss_poser] fix namespace for component (autowarefoundation#295) Signed-off-by: Takamasa Horibe <horibe.takamasa@gmail.com> * [gnss_poser] fix link to Geographiclib (autowarefoundation#296) * [gnss_poser] fix link to Geographiclib * Fix mismatching spaces inside () after command Signed-off-by: wep21 <border_goldenmarket@yahoo.co.jp> Co-authored-by: Autoware <autoware@tier4.jp> Co-authored-by: wep21 <border_goldenmarket@yahoo.co.jp> * Ros2 v0.8.0 gnss poser (autowarefoundation#287) * [gnss poser]: Remove std_msgs (autowarefoundation#341) Signed-off-by: wep21 <border_goldenmarket@yahoo.co.jp> * add use_sim-time option (autowarefoundation#454) * Format launch files (autowarefoundation#1219) Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp> * Fix for rolling (autowarefoundation#1226) * Replace doc by description Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp> * Replace ns by push-ros-namespace Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp> * Remove use_sim_time for set_parameter (autowarefoundation#1260) Signed-off-by: wep21 <border_goldenmarket@yahoo.co.jp> * Add pre-commit (autowarefoundation#1560) * add pre-commit * add pre-commit-config * add additional settings for private repository * use default pre-commit-config * update pre-commit setting * Ignore whitespace for line breaks in markdown * Update .github/workflows/pre-commit.yml Co-authored-by: Kazuki Miyahara <kmiya@outlook.com> * exclude svg * remove pretty-format-json * add double-quote-string-fixer * consider COLCON_IGNORE file when seaching modified package * format file * pre-commit fixes * Update pre-commit.yml * Update .pre-commit-config.yaml Co-authored-by: Kazuki Miyahara <kmiya@outlook.com> Co-authored-by: pre-commit <pre-commit@example.com> Co-authored-by: Kenji Miyake <31987104+kenji-miyake@users.noreply.github.com> * Add markdownlint and prettier (autowarefoundation#1661) * Add markdownlint and prettier Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp> * Ignore .param.yaml Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp> * Apply format Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp> * suppress warnings for sensing packages (autowarefoundation#1729) * add Werror for tier4_pcl_extensions * use std::type instead of pcl::type * use std::isfinite instead of pcl_isfinite * fix getFieldIndex * add Werror * fix uninitialized * add Werror * fix string to char* * Fix -Wunused-parameter (autowarefoundation#1836) * Fix -Wunused-parameter Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp> * Fix mistake Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp> * fix spell * Fix lint issues Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp> * Ignore flake8 warnings Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp> Co-authored-by: Hiroki OTA <hiroki.ota@tier4.jp> * Fix clang warnings (autowarefoundation#1859) * Fix -Wreturn-std-move Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp> * Fix -Wunused-private-field Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp> * Ignore -Wnonportable-include-path for mussp Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp> * Fix -Wunused-const-variable Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp> * Fix "can not be used when making a shared object" Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp> * add sort-package-xml hook in pre-commit (autowarefoundation#1881) * add sort xml hook in pre-commit * change retval to exit_status * rename * add prettier plugin-xml * use early return * add license note * add tier4 license * restore prettier * change license order * move local hooks to public repo * move prettier-xml to pre-commit-hooks-ros * update version for bug-fix * apply pre-commit * fix gnss_poser transform (autowarefoundation#1493) (autowarefoundation#1623) * fix gnss_poser transform (autowarefoundation#1493) * fix gnss_poser transform * change transformation method from doTransform to tf2::Transform multiplication * rename tf variables * correct variable spelling Signed-off-by: wep21 <border_goldenmarket@yahoo.co.jp> * Fix lint Signed-off-by: wep21 <border_goldenmarket@yahoo.co.jp> Co-authored-by: hiro-ya-iv <30652835+hiro-ya-iv@users.noreply.github.com> * Change formatter to clang-format and black (autowarefoundation#2332) * Revert "Temporarily comment out pre-commit hooks" This reverts commit 748e9cdb145ce12f8b520bcbd97f5ff899fc28a3. * Replace ament_lint_common with autoware_lint_common Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp> * Remove ament_cmake_uncrustify and ament_clang_format Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp> * Apply Black Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp> * Apply clang-format Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp> * Fix build errors Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp> * Fix for cpplint * Fix include double quotes to angle brackets Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp> * Apply clang-format Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp> * Fix build errors Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp> * Add COLCON_IGNORE (autowarefoundation#500) Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp> * remove COLCON_IGNORE (autowarefoundation#515) * doc gnss poser (autowarefoundation#580) * add minimal doc * fix document title * doc geo conv pos (autowarefoundation#573) * add minimal doc * fix document title * Remove template comments from node documents (autowarefoundation#608) * rename document file * remove template comment Co-authored-by: YamatoAndo <yamato.ando@gmail.com> Co-authored-by: Daichi Murakami <harihitode@gmail.com> Co-authored-by: Kenji Miyake <31987104+kenji-miyake@users.noreply.github.com> Co-authored-by: mitsudome-r <ryohsuke.mitsudome@tier4.jp> Co-authored-by: Jilada Eccleston <jilada.eccleston@gmail.com> Co-authored-by: Nikolai Morin <nnmmgit@gmail.com> Co-authored-by: Takamasa Horibe <horibe.takamasa@gmail.com> Co-authored-by: Frederik Beaujean <72439809+fred-apex-ai@users.noreply.github.com> Co-authored-by: Kosuke Murakami <kosuke.murakami@tier4.jp> Co-authored-by: Ryohsuke Mitsudome <43976834+mitsudome-r@users.noreply.github.com> Co-authored-by: Autoware <autoware@tier4.jp> Co-authored-by: wep21 <border_goldenmarket@yahoo.co.jp> Co-authored-by: Daisuke Nishimatsu <42202095+wep21@users.noreply.github.com> Co-authored-by: tkimura4 <tomoya.kimura@tier4.jp> Co-authored-by: Keisuke Shima <19993104+KeisukeShima@users.noreply.github.com> Co-authored-by: Kazuki Miyahara <kmiya@outlook.com> Co-authored-by: pre-commit <pre-commit@example.com> Co-authored-by: Hiroki OTA <hiroki.ota@tier4.jp> Co-authored-by: hiro-ya-iv <30652835+hiro-ya-iv@users.noreply.github.com> Co-authored-by: Satoshi OTA <44889564+satoshi-ota@users.noreply.github.com> Co-authored-by: taikitanaka3 <65527974+taikitanaka3@users.noreply.github.com>

* release v0.4.0 * removed ROS1 package Signed-off-by: mitsudome-r <ryohsuke.mitsudome@tier4.jp> * Revert "removed ROS1 package" This reverts commit efeb029d17c4fb14de1542512574742a4cb05de8. * add COLCON_IGNORE file to all ROS1 packages Signed-off-by: mitsudome-r <ryohsuke.mitsudome@tier4.jp> * rename *.launch files to *.launch.xml Signed-off-by: mitsudome-r <ryohsuke.mitsudome@tier4.jp> * Port localization_launch to ros2 * fix syntax (autowarefoundation#33) Signed-off-by: Takamasa Horibe <horibe.takamasa@gmail.com> * ROS2 Linting: localization_launch (autowarefoundation#39) * Add linters to localization_launch package * Add new line * Fix indentation * Ros2 v0.8.0 localization launch (autowarefoundation#54) * restore file name for v0.8.0 update in localization launch Signed-off-by: Takamasa Horibe <horibe.takamasa@gmail.com> * add random sample (autowarefoundation#84) Signed-off-by: Yamato Ando <yamato.ando@gmail.com> * Add ndt_scan_matcher.yaml (autowarefoundation#162) Signed-off-by: Yuma Nihei <yuma.nihei@tier4.jp> * ]Revert "restore file name for v0.8.0 update in localization launch" This reverts commit f589733f7dad05989bde323baeb5c43a62cd26e1. * fix param type Signed-off-by: Takamasa Horibe <horibe.takamasa@gmail.com> * fix exec name Signed-off-by: Takamasa Horibe <horibe.takamasa@gmail.com> Co-authored-by: YamatoAndo <yamato.ando@gmail.com> Co-authored-by: Yuma Nihei <yuma.nihei@tier4.jp> * Rename ROS-related .yaml to .param.yaml (autowarefoundation#65) * Rename ROS-related .yaml to .param.yaml Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp> * Add missing '--' Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp> * Rename vehicle_info.yaml to vehicle_info.param.yaml Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp> * Fix livox param name Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp> * add localization_error_monitor launch (autowarefoundation#75) * Fix various typos in launch files (autowarefoundation#97) * add use_sim-time option (autowarefoundation#99) * Replace doc by description (autowarefoundation#182) Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp> * Ros2 lsim test (autowarefoundation#186) * Add group to launch file for var scope Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp> * Remove pointcloud relay for localization Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp> * Add use_sim_time Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp> * Remove pointcloud relay for localization Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp> Co-authored-by: Takagi, Isamu <isamu.takagi@tier4.jp> * Fix invalid attribute in twist estimator launch (autowarefoundation#192) Signed-off-by: wep21 <border_goldenmarket@yahoo.co.jp> * Localization util preprocessor component (autowarefoundation#188) Signed-off-by: wep21 <border_goldenmarket@yahoo.co.jp> * Use set_parameter for use_sim_time (autowarefoundation#198) * Use set_parameter for use_sim_time Signed-off-by: wep21 <border_goldenmarket@yahoo.co.jp> * Add default parameter for scenario simulator Signed-off-by: wep21 <border_goldenmarket@yahoo.co.jp> * Fix depends in localization_launch to exec_depend (autowarefoundation#223) Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp> * Fix typos in launch files (autowarefoundation#231) * Fix typos in launch files Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp> * Fix lint Signed-off-by: wep21 <border_goldenmarket@yahoo.co.jp> Co-authored-by: wep21 <border_goldenmarket@yahoo.co.jp> * Format launch files (autowarefoundation#228) * Format launch files Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp> * Format launch.py Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp> * Fix lint Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp> * Enable intra process and mt (autowarefoundation#204) Signed-off-by: wep21 <border_goldenmarket@yahoo.co.jp> * Load output_measurement_range_sensor_points_topic param (autowarefoundation#271) Signed-off-by: kosuke55 <kosuke.tnp@gmail.com> * use_twist_with_covariance is false (autowarefoundation#295) * add description for localization_launch (autowarefoundation#332) * add description * fix sentence * add README.md and svg files (autowarefoundation#328) * add md and svg * fix typo * fix typo * fix word * fix typo * add lack of things * Update README * fix depending packages * fix word * Feature/expand footprint launcher (autowarefoundation#318) * Add autoware api (autowarefoundation#376) * Add external api adaptor (autowarefoundation#267) * Add external api adaptor * Add api adaptor to logging simulator Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp> * Add engage status output Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp> * Add internal api adaptor (autowarefoundation#273) Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp> * Add map hash generator (autowarefoundation#319) Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp> * Add autoware api launch (autowarefoundation#326) * Add autoware api launch Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp> * Apply autoware api launch Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp> * Add deprecated comment Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp> * Remove unused parameter (autowarefoundation#325) Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp> * Add api parameter (autowarefoundation#341) Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp> * Add start request API (autowarefoundation#321) * Add use start request option Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp> * Fix lint Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp> * Feature external cmd selector heartbeat (autowarefoundation#356) * Rename external command topic Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp> * Modify command topic name Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp> * Fix topic name Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp> * Rename remote_cmd_converter Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp> * Remove gate mode from external command Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp> * Fix latest external command name (autowarefoundation#361) Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp> * Fix merge conflict Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp> * change external traffic light topic name in behavior velocity planner (autowarefoundation#310) * fix topic * change internal topic name Co-authored-by: yabuta <makoto.yabuta@tier4.jp> * added stop filter launch in localization_launch (autowarefoundation#270) * Fix pre-commit (autowarefoundation#407) * Fix pre-commit errors Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp> * Fix package.xml Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp> * modify util.launch in localization_launch autowarefoundation#396 * add localization error monitor param (autowarefoundation#431) * add environment_name parameter into localization launch (autowarefoundation#175) (autowarefoundation#293) * add environment_name parameter into localization launch (autowarefoundation#175) * add environment_name parameter into localization launch change launcher parameters of crop_box_filter_mesurement_range and voxel_grid_filter to yaml file Signed-off-by: Azumi Suzuki <azumi.suzuki@tier4.jp> * change param file directory name Signed-off-by: Azumi Suzuki <azumi.suzuki@tier4.jp> * Remove redundant comments Signed-off-by: wep21 <border_goldenmarket@yahoo.co.jp> Co-authored-by: s-azumi <38061530+s-azumi@users.noreply.github.com> * delete environment name (autowarefoundation#428) * Change formatter to black (autowarefoundation#488) * Update pre-commit settings * Apply Black * Replace ament_lint_common with autoware_lint_common * Update build_depends.repos * Fix build_depends * porting localization (autowarefoundation#121) * porting localization * fixed odometry in ekf * fixed vehicle twist topic name Co-authored-by: mitsudome-r <ryohsuke.mitsudome@tier4.jp> Co-authored-by: Yunus Emre Caliskan <yunus.ec@gmail.com> Co-authored-by: Takamasa Horibe <horibe.takamasa@gmail.com> Co-authored-by: Jilada Eccleston <jilada.eccleston@tier4.jp> Co-authored-by: YamatoAndo <yamato.ando@gmail.com> Co-authored-by: Yuma Nihei <yuma.nihei@tier4.jp> Co-authored-by: Kenji Miyake <31987104+kenji-miyake@users.noreply.github.com> Co-authored-by: Taichi Higashide <taichi.higashide@tier4.jp> Co-authored-by: Kazuki Miyahara <kmiya@outlook.com> Co-authored-by: Daisuke Nishimatsu <42202095+wep21@users.noreply.github.com> Co-authored-by: Takagi, Isamu <isamu.takagi@tier4.jp> Co-authored-by: wep21 <border_goldenmarket@yahoo.co.jp> Co-authored-by: Kosuke Takeuchi <kosuke.tnp@gmail.com> Co-authored-by: Hiroki OTA <hiroki.ota@tier4.jp> Co-authored-by: Kosuke Murakami <kosuke.murakami@tier4.jp> Co-authored-by: Takagi, Isamu <43976882+isamu-takagi@users.noreply.github.com> Co-authored-by: yabuta <makoto.yabuta@tier4.jp> Co-authored-by: kminoda <44218668+kminoda@users.noreply.github.com> Co-authored-by: s-azumi <38061530+s-azumi@users.noreply.github.com> Co-authored-by: Kenji Miyake <kenji.miyake@tier4.jp> Co-authored-by: RyuYamamoto <ryu.yamamoto@tier4.jp> Co-authored-by: Takeshi Miura <57553950+1222-takeshi@users.noreply.github.com>

…n#295) * feat: add Werror Signed-off-by: h-ohta <hiroki.ota@tier4.jp> * fix: fix deprecated-declarations Signed-off-by: h-ohta <hiroki.ota@tier4.jp>

* rename gnss package (autowarefoundation#714) Signed-off-by: Yamato Ando <yamato.ando@gmail.com> * Avoid setting CMAKE_BUILD_TYPE=Release in each CMakeLists.txt (autowarefoundation#720) * remove set CMAKE_BUILD_TYPE Release in each CMakeLists.txt * remove set CMAKE_BUILD_TYPE Release in ndt_pcl_modified * set compile options for debug in ndt_omp * Fix indent * add warning if -DCMAKE_BUILD_TYPE=Release is not set in ndt_omp Co-authored-by: Kenji Miyake <31987104+kenji-miyake@users.noreply.github.com> * remove ROS1 packages temporarily Signed-off-by: mitsudome-r <ryohsuke.mitsudome@tier4.jp> * Revert "remove ROS1 packages temporarily" This reverts commit bc523d679e6737ec37be4fdcbdedca141411bd9d. Signed-off-by: mitsudome-r <ryohsuke.mitsudome@tier4.jp> * add COLCON_IGNORE to ros1 packages Signed-off-by: mitsudome-r <ryohsuke.mitsudome@tier4.jp> * ROS2 Porting: geo_pos_conv (#8) * Convert to ROS2 package - Update changelog -> 2.0.0 - Update package xml to use the ROS2 xml schema - Update CMakelist with ament cmake commands - Add ROS2 compile options * Convert CMakelist for foxy * Clean up - Remove comments * Remove colcon ignore * Rename launch files to launch.xml (autowarefoundation#28) * ROS2 Porting: gnss_poser (autowarefoundation#18) * Fix CMakelist - Add ublox_msgs package dependency - Rename header files to use the .hpp extention - Remove colcon ignore - Fix Cmake ref to ublox in dependency * Fix compilation issues with convert.hpp - Add sensor_msgs::NavSatFix header which was missing before (?) - Remove logging for now - Contains warnings - geographic lib error polymorphous error - Fix geographic lib -Wcatch-value warnings - Add ifndef guard in gnss_stat.hpp * First pass - successful compilation - Fix CMakelist geographic library - Remove references to main ROS functions - Convert msg references - Add ifndef guards - Convert tf2 methods - Add functionality back - Fix type errors * Add publishers and subscribers - Add parameters * Convert launch files to ROS2 format * Add logging * Convert to component * Fix define guards to follow ROS2/Google style * Add -Werror compile flag * Clean up * Fix CMakelist to allow for the node to be found via ros2 launch - Revert filenames so it is easier to review * Address PR Comments: - Fix CMakelist and package.xml - Remove redundant depend/exec_depend calls - Remove redundant find_package calls - Explicitly add headers to the library * Address PR comments: - Revert removal of GNSSPoser namespace - Use std::make_shared in place of new - Reorder includes to conform with standard * Address PR Comments: - Rename variable to conform with the google style guide - Use the node clock in logging method calls * Address PR Comment: - Convert transform broadcaster to shared pointer * Address PR comment: - Remove -Werror compile flag post discussion * fix duration unit for RCLCPP_*_THROTTLE (autowarefoundation#75) Signed-off-by: Takamasa Horibe <horibe.takamasa@gmail.com> * [gnss_poser] switch broadcaster to full member... (autowarefoundation#136) instead of `shared_ptr` to avoid undefined behavior when executing the node because it used `shared_from_this()` in the constructor * Adjust copyright notice on 532 out of 699 source files (autowarefoundation#143) * Use quotes for includes where appropriate (autowarefoundation#144) * Use quotes for includes where appropriate * Fix lint tests * Make tests pass hopefully * Run uncrustify on the entire Pilot.Auto codebase (autowarefoundation#151) * Run uncrustify on the entire Pilot.Auto codebase * Exclude open PRs * ROS2 Linting: geo_pos_conv (autowarefoundation#165) * Add linters and fix linter issues - convert Cmake to use ament_cmake_auto * Address PR comments: - Remove unneeded cast - Throw error instead of setting default values to zero * ROS2 Linting: gnss_poser (autowarefoundation#166) * Add linting and fix litner errors * Address PR comment: - Use author name instead of user - Remove ROS2 maintainer (remnants of older porting) * apply env_var to use_sim_time (autowarefoundation#222) * [gnss_poser] fix namespace for component (autowarefoundation#295) Signed-off-by: Takamasa Horibe <horibe.takamasa@gmail.com> * [gnss_poser] fix link to Geographiclib (autowarefoundation#296) * [gnss_poser] fix link to Geographiclib * Fix mismatching spaces inside () after command Signed-off-by: wep21 <border_goldenmarket@yahoo.co.jp> Co-authored-by: Autoware <autoware@tier4.jp> Co-authored-by: wep21 <border_goldenmarket@yahoo.co.jp> * Ros2 v0.8.0 gnss poser (autowarefoundation#287) * [gnss poser]: Remove std_msgs (autowarefoundation#341) Signed-off-by: wep21 <border_goldenmarket@yahoo.co.jp> * add use_sim-time option (autowarefoundation#454) * Format launch files (autowarefoundation#1219) Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp> * Fix for rolling (autowarefoundation#1226) * Replace doc by description Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp> * Replace ns by push-ros-namespace Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp> * Remove use_sim_time for set_parameter (autowarefoundation#1260) Signed-off-by: wep21 <border_goldenmarket@yahoo.co.jp> * Add pre-commit (autowarefoundation#1560) * add pre-commit * add pre-commit-config * add additional settings for private repository * use default pre-commit-config * update pre-commit setting * Ignore whitespace for line breaks in markdown * Update .github/workflows/pre-commit.yml Co-authored-by: Kazuki Miyahara <kmiya@outlook.com> * exclude svg * remove pretty-format-json * add double-quote-string-fixer * consider COLCON_IGNORE file when seaching modified package * format file * pre-commit fixes * Update pre-commit.yml * Update .pre-commit-config.yaml Co-authored-by: Kazuki Miyahara <kmiya@outlook.com> Co-authored-by: pre-commit <pre-commit@example.com> Co-authored-by: Kenji Miyake <31987104+kenji-miyake@users.noreply.github.com> * Add markdownlint and prettier (autowarefoundation#1661) * Add markdownlint and prettier Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp> * Ignore .param.yaml Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp> * Apply format Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp> * suppress warnings for sensing packages (autowarefoundation#1729) * add Werror for tier4_pcl_extensions * use std::type instead of pcl::type * use std::isfinite instead of pcl_isfinite * fix getFieldIndex * add Werror * fix uninitialized * add Werror * fix string to char* * Fix -Wunused-parameter (autowarefoundation#1836) * Fix -Wunused-parameter Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp> * Fix mistake Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp> * fix spell * Fix lint issues Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp> * Ignore flake8 warnings Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp> Co-authored-by: Hiroki OTA <hiroki.ota@tier4.jp> * Fix clang warnings (autowarefoundation#1859) * Fix -Wreturn-std-move Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp> * Fix -Wunused-private-field Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp> * Ignore -Wnonportable-include-path for mussp Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp> * Fix -Wunused-const-variable Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp> * Fix "can not be used when making a shared object" Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp> * add sort-package-xml hook in pre-commit (autowarefoundation#1881) * add sort xml hook in pre-commit * change retval to exit_status * rename * add prettier plugin-xml * use early return * add license note * add tier4 license * restore prettier * change license order * move local hooks to public repo * move prettier-xml to pre-commit-hooks-ros * update version for bug-fix * apply pre-commit * fix gnss_poser transform (autowarefoundation#1493) (autowarefoundation#1623) * fix gnss_poser transform (autowarefoundation#1493) * fix gnss_poser transform * change transformation method from doTransform to tf2::Transform multiplication * rename tf variables * correct variable spelling Signed-off-by: wep21 <border_goldenmarket@yahoo.co.jp> * Fix lint Signed-off-by: wep21 <border_goldenmarket@yahoo.co.jp> Co-authored-by: hiro-ya-iv <30652835+hiro-ya-iv@users.noreply.github.com> * Change formatter to clang-format and black (autowarefoundation#2332) * Revert "Temporarily comment out pre-commit hooks" This reverts commit 748e9cdb145ce12f8b520bcbd97f5ff899fc28a3. * Replace ament_lint_common with autoware_lint_common Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp> * Remove ament_cmake_uncrustify and ament_clang_format Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp> * Apply Black Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp> * Apply clang-format Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp> * Fix build errors Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp> * Fix for cpplint * Fix include double quotes to angle brackets Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp> * Apply clang-format Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp> * Fix build errors Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp> * Add COLCON_IGNORE (autowarefoundation#500) Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp> * remove COLCON_IGNORE (autowarefoundation#515) * doc gnss poser (autowarefoundation#580) * add minimal doc * fix document title * doc geo conv pos (autowarefoundation#573) * add minimal doc * fix document title * Remove template comments from node documents (autowarefoundation#608) * rename document file * remove template comment Co-authored-by: YamatoAndo <yamato.ando@gmail.com> Co-authored-by: Daichi Murakami <harihitode@gmail.com> Co-authored-by: Kenji Miyake <31987104+kenji-miyake@users.noreply.github.com> Co-authored-by: mitsudome-r <ryohsuke.mitsudome@tier4.jp> Co-authored-by: Jilada Eccleston <jilada.eccleston@gmail.com> Co-authored-by: Nikolai Morin <nnmmgit@gmail.com> Co-authored-by: Takamasa Horibe <horibe.takamasa@gmail.com> Co-authored-by: Frederik Beaujean <72439809+fred-apex-ai@users.noreply.github.com> Co-authored-by: Kosuke Murakami <kosuke.murakami@tier4.jp> Co-authored-by: Ryohsuke Mitsudome <43976834+mitsudome-r@users.noreply.github.com> Co-authored-by: Autoware <autoware@tier4.jp> Co-authored-by: wep21 <border_goldenmarket@yahoo.co.jp> Co-authored-by: Daisuke Nishimatsu <42202095+wep21@users.noreply.github.com> Co-authored-by: tkimura4 <tomoya.kimura@tier4.jp> Co-authored-by: Keisuke Shima <19993104+KeisukeShima@users.noreply.github.com> Co-authored-by: Kazuki Miyahara <kmiya@outlook.com> Co-authored-by: pre-commit <pre-commit@example.com> Co-authored-by: Hiroki OTA <hiroki.ota@tier4.jp> Co-authored-by: hiro-ya-iv <30652835+hiro-ya-iv@users.noreply.github.com> Co-authored-by: Satoshi OTA <44889564+satoshi-ota@users.noreply.github.com> Co-authored-by: taikitanaka3 <65527974+taikitanaka3@users.noreply.github.com>

* release v0.4.0 * removed ROS1 package Signed-off-by: mitsudome-r <ryohsuke.mitsudome@tier4.jp> * Revert "removed ROS1 package" This reverts commit efeb029d17c4fb14de1542512574742a4cb05de8. * add COLCON_IGNORE file to all ROS1 packages Signed-off-by: mitsudome-r <ryohsuke.mitsudome@tier4.jp> * rename *.launch files to *.launch.xml Signed-off-by: mitsudome-r <ryohsuke.mitsudome@tier4.jp> * Port localization_launch to ros2 * fix syntax (autowarefoundation#33) Signed-off-by: Takamasa Horibe <horibe.takamasa@gmail.com> * ROS2 Linting: localization_launch (autowarefoundation#39) * Add linters to localization_launch package * Add new line * Fix indentation * Ros2 v0.8.0 localization launch (autowarefoundation#54) * restore file name for v0.8.0 update in localization launch Signed-off-by: Takamasa Horibe <horibe.takamasa@gmail.com> * add random sample (autowarefoundation#84) Signed-off-by: Yamato Ando <yamato.ando@gmail.com> * Add ndt_scan_matcher.yaml (autowarefoundation#162) Signed-off-by: Yuma Nihei <yuma.nihei@tier4.jp> * ]Revert "restore file name for v0.8.0 update in localization launch" This reverts commit f589733f7dad05989bde323baeb5c43a62cd26e1. * fix param type Signed-off-by: Takamasa Horibe <horibe.takamasa@gmail.com> * fix exec name Signed-off-by: Takamasa Horibe <horibe.takamasa@gmail.com> Co-authored-by: YamatoAndo <yamato.ando@gmail.com> Co-authored-by: Yuma Nihei <yuma.nihei@tier4.jp> * Rename ROS-related .yaml to .param.yaml (autowarefoundation#65) * Rename ROS-related .yaml to .param.yaml Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp> * Add missing '--' Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp> * Rename vehicle_info.yaml to vehicle_info.param.yaml Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp> * Fix livox param name Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp> * add localization_error_monitor launch (autowarefoundation#75) * Fix various typos in launch files (autowarefoundation#97) * add use_sim-time option (autowarefoundation#99) * Replace doc by description (autowarefoundation#182) Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp> * Ros2 lsim test (autowarefoundation#186) * Add group to launch file for var scope Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp> * Remove pointcloud relay for localization Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp> * Add use_sim_time Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp> * Remove pointcloud relay for localization Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp> Co-authored-by: Takagi, Isamu <isamu.takagi@tier4.jp> * Fix invalid attribute in twist estimator launch (autowarefoundation#192) Signed-off-by: wep21 <border_goldenmarket@yahoo.co.jp> * Localization util preprocessor component (autowarefoundation#188) Signed-off-by: wep21 <border_goldenmarket@yahoo.co.jp> * Use set_parameter for use_sim_time (autowarefoundation#198) * Use set_parameter for use_sim_time Signed-off-by: wep21 <border_goldenmarket@yahoo.co.jp> * Add default parameter for scenario simulator Signed-off-by: wep21 <border_goldenmarket@yahoo.co.jp> * Fix depends in localization_launch to exec_depend (autowarefoundation#223) Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp> * Fix typos in launch files (autowarefoundation#231) * Fix typos in launch files Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp> * Fix lint Signed-off-by: wep21 <border_goldenmarket@yahoo.co.jp> Co-authored-by: wep21 <border_goldenmarket@yahoo.co.jp> * Format launch files (autowarefoundation#228) * Format launch files Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp> * Format launch.py Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp> * Fix lint Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp> * Enable intra process and mt (autowarefoundation#204) Signed-off-by: wep21 <border_goldenmarket@yahoo.co.jp> * Load output_measurement_range_sensor_points_topic param (autowarefoundation#271) Signed-off-by: kosuke55 <kosuke.tnp@gmail.com> * use_twist_with_covariance is false (autowarefoundation#295) * add description for localization_launch (autowarefoundation#332) * add description * fix sentence * add README.md and svg files (autowarefoundation#328) * add md and svg * fix typo * fix typo * fix word * fix typo * add lack of things * Update README * fix depending packages * fix word * Feature/expand footprint launcher (autowarefoundation#318) * Add autoware api (autowarefoundation#376) * Add external api adaptor (autowarefoundation#267) * Add external api adaptor * Add api adaptor to logging simulator Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp> * Add engage status output Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp> * Add internal api adaptor (autowarefoundation#273) Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp> * Add map hash generator (autowarefoundation#319) Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp> * Add autoware api launch (autowarefoundation#326) * Add autoware api launch Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp> * Apply autoware api launch Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp> * Add deprecated comment Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp> * Remove unused parameter (autowarefoundation#325) Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp> * Add api parameter (autowarefoundation#341) Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp> * Add start request API (autowarefoundation#321) * Add use start request option Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp> * Fix lint Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp> * Feature external cmd selector heartbeat (autowarefoundation#356) * Rename external command topic Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp> * Modify command topic name Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp> * Fix topic name Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp> * Rename remote_cmd_converter Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp> * Remove gate mode from external command Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp> * Fix latest external command name (autowarefoundation#361) Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp> * Fix merge conflict Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp> * change external traffic light topic name in behavior velocity planner (autowarefoundation#310) * fix topic * change internal topic name Co-authored-by: yabuta <makoto.yabuta@tier4.jp> * added stop filter launch in localization_launch (autowarefoundation#270) * Fix pre-commit (autowarefoundation#407) * Fix pre-commit errors Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp> * Fix package.xml Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp> * modify util.launch in localization_launch autowarefoundation#396 * add localization error monitor param (autowarefoundation#431) * add environment_name parameter into localization launch (autowarefoundation#175) (autowarefoundation#293) * add environment_name parameter into localization launch (autowarefoundation#175) * add environment_name parameter into localization launch change launcher parameters of crop_box_filter_mesurement_range and voxel_grid_filter to yaml file Signed-off-by: Azumi Suzuki <azumi.suzuki@tier4.jp> * change param file directory name Signed-off-by: Azumi Suzuki <azumi.suzuki@tier4.jp> * Remove redundant comments Signed-off-by: wep21 <border_goldenmarket@yahoo.co.jp> Co-authored-by: s-azumi <38061530+s-azumi@users.noreply.github.com> * delete environment name (autowarefoundation#428) * Change formatter to black (autowarefoundation#488) * Update pre-commit settings * Apply Black * Replace ament_lint_common with autoware_lint_common * Update build_depends.repos * Fix build_depends * porting localization (autowarefoundation#121) * porting localization * fixed odometry in ekf * fixed vehicle twist topic name Co-authored-by: mitsudome-r <ryohsuke.mitsudome@tier4.jp> Co-authored-by: Yunus Emre Caliskan <yunus.ec@gmail.com> Co-authored-by: Takamasa Horibe <horibe.takamasa@gmail.com> Co-authored-by: Jilada Eccleston <jilada.eccleston@tier4.jp> Co-authored-by: YamatoAndo <yamato.ando@gmail.com> Co-authored-by: Yuma Nihei <yuma.nihei@tier4.jp> Co-authored-by: Kenji Miyake <31987104+kenji-miyake@users.noreply.github.com> Co-authored-by: Taichi Higashide <taichi.higashide@tier4.jp> Co-authored-by: Kazuki Miyahara <kmiya@outlook.com> Co-authored-by: Daisuke Nishimatsu <42202095+wep21@users.noreply.github.com> Co-authored-by: Takagi, Isamu <isamu.takagi@tier4.jp> Co-authored-by: wep21 <border_goldenmarket@yahoo.co.jp> Co-authored-by: Kosuke Takeuchi <kosuke.tnp@gmail.com> Co-authored-by: Hiroki OTA <hiroki.ota@tier4.jp> Co-authored-by: Kosuke Murakami <kosuke.murakami@tier4.jp> Co-authored-by: Takagi, Isamu <43976882+isamu-takagi@users.noreply.github.com> Co-authored-by: yabuta <makoto.yabuta@tier4.jp> Co-authored-by: kminoda <44218668+kminoda@users.noreply.github.com> Co-authored-by: s-azumi <38061530+s-azumi@users.noreply.github.com> Co-authored-by: Kenji Miyake <kenji.miyake@tier4.jp> Co-authored-by: RyuYamamoto <ryu.yamamoto@tier4.jp> Co-authored-by: Takeshi Miura <57553950+1222-takeshi@users.noreply.github.com>

…n#295) * feat: add Werror Signed-off-by: h-ohta <hiroki.ota@tier4.jp> * fix: fix deprecated-declarations Signed-off-by: h-ohta <hiroki.ota@tier4.jp>

* rename gnss package (autowarefoundation#714) Signed-off-by: Yamato Ando <yamato.ando@gmail.com> * Avoid setting CMAKE_BUILD_TYPE=Release in each CMakeLists.txt (autowarefoundation#720) * remove set CMAKE_BUILD_TYPE Release in each CMakeLists.txt * remove set CMAKE_BUILD_TYPE Release in ndt_pcl_modified * set compile options for debug in ndt_omp * Fix indent * add warning if -DCMAKE_BUILD_TYPE=Release is not set in ndt_omp Co-authored-by: Kenji Miyake <31987104+kenji-miyake@users.noreply.github.com> * remove ROS1 packages temporarily Signed-off-by: mitsudome-r <ryohsuke.mitsudome@tier4.jp> * Revert "remove ROS1 packages temporarily" This reverts commit bc523d679e6737ec37be4fdcbdedca141411bd9d. Signed-off-by: mitsudome-r <ryohsuke.mitsudome@tier4.jp> * add COLCON_IGNORE to ros1 packages Signed-off-by: mitsudome-r <ryohsuke.mitsudome@tier4.jp> * ROS2 Porting: geo_pos_conv (#8) * Convert to ROS2 package - Update changelog -> 2.0.0 - Update package xml to use the ROS2 xml schema - Update CMakelist with ament cmake commands - Add ROS2 compile options * Convert CMakelist for foxy * Clean up - Remove comments * Remove colcon ignore * Rename launch files to launch.xml (autowarefoundation#28) * ROS2 Porting: gnss_poser (autowarefoundation#18) * Fix CMakelist - Add ublox_msgs package dependency - Rename header files to use the .hpp extention - Remove colcon ignore - Fix Cmake ref to ublox in dependency * Fix compilation issues with convert.hpp - Add sensor_msgs::NavSatFix header which was missing before (?) - Remove logging for now - Contains warnings - geographic lib error polymorphous error - Fix geographic lib -Wcatch-value warnings - Add ifndef guard in gnss_stat.hpp * First pass - successful compilation - Fix CMakelist geographic library - Remove references to main ROS functions - Convert msg references - Add ifndef guards - Convert tf2 methods - Add functionality back - Fix type errors * Add publishers and subscribers - Add parameters * Convert launch files to ROS2 format * Add logging * Convert to component * Fix define guards to follow ROS2/Google style * Add -Werror compile flag * Clean up * Fix CMakelist to allow for the node to be found via ros2 launch - Revert filenames so it is easier to review * Address PR Comments: - Fix CMakelist and package.xml - Remove redundant depend/exec_depend calls - Remove redundant find_package calls - Explicitly add headers to the library * Address PR comments: - Revert removal of GNSSPoser namespace - Use std::make_shared in place of new - Reorder includes to conform with standard * Address PR Comments: - Rename variable to conform with the google style guide - Use the node clock in logging method calls * Address PR Comment: - Convert transform broadcaster to shared pointer * Address PR comment: - Remove -Werror compile flag post discussion * fix duration unit for RCLCPP_*_THROTTLE (autowarefoundation#75) Signed-off-by: Takamasa Horibe <horibe.takamasa@gmail.com> * [gnss_poser] switch broadcaster to full member... (autowarefoundation#136) instead of `shared_ptr` to avoid undefined behavior when executing the node because it used `shared_from_this()` in the constructor * Adjust copyright notice on 532 out of 699 source files (autowarefoundation#143) * Use quotes for includes where appropriate (autowarefoundation#144) * Use quotes for includes where appropriate * Fix lint tests * Make tests pass hopefully * Run uncrustify on the entire Pilot.Auto codebase (autowarefoundation#151) * Run uncrustify on the entire Pilot.Auto codebase * Exclude open PRs * ROS2 Linting: geo_pos_conv (autowarefoundation#165) * Add linters and fix linter issues - convert Cmake to use ament_cmake_auto * Address PR comments: - Remove unneeded cast - Throw error instead of setting default values to zero * ROS2 Linting: gnss_poser (autowarefoundation#166) * Add linting and fix litner errors * Address PR comment: - Use author name instead of user - Remove ROS2 maintainer (remnants of older porting) * apply env_var to use_sim_time (autowarefoundation#222) * [gnss_poser] fix namespace for component (autowarefoundation#295) Signed-off-by: Takamasa Horibe <horibe.takamasa@gmail.com> * [gnss_poser] fix link to Geographiclib (autowarefoundation#296) * [gnss_poser] fix link to Geographiclib * Fix mismatching spaces inside () after command Signed-off-by: wep21 <border_goldenmarket@yahoo.co.jp> Co-authored-by: Autoware <autoware@tier4.jp> Co-authored-by: wep21 <border_goldenmarket@yahoo.co.jp> * Ros2 v0.8.0 gnss poser (autowarefoundation#287) * [gnss poser]: Remove std_msgs (autowarefoundation#341) Signed-off-by: wep21 <border_goldenmarket@yahoo.co.jp> * add use_sim-time option (autowarefoundation#454) * Format launch files (autowarefoundation#1219) Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp> * Fix for rolling (autowarefoundation#1226) * Replace doc by description Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp> * Replace ns by push-ros-namespace Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp> * Remove use_sim_time for set_parameter (autowarefoundation#1260) Signed-off-by: wep21 <border_goldenmarket@yahoo.co.jp> * Add pre-commit (autowarefoundation#1560) * add pre-commit * add pre-commit-config * add additional settings for private repository * use default pre-commit-config * update pre-commit setting * Ignore whitespace for line breaks in markdown * Update .github/workflows/pre-commit.yml Co-authored-by: Kazuki Miyahara <kmiya@outlook.com> * exclude svg * remove pretty-format-json * add double-quote-string-fixer * consider COLCON_IGNORE file when seaching modified package * format file * pre-commit fixes * Update pre-commit.yml * Update .pre-commit-config.yaml Co-authored-by: Kazuki Miyahara <kmiya@outlook.com> Co-authored-by: pre-commit <pre-commit@example.com> Co-authored-by: Kenji Miyake <31987104+kenji-miyake@users.noreply.github.com> * Add markdownlint and prettier (autowarefoundation#1661) * Add markdownlint and prettier Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp> * Ignore .param.yaml Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp> * Apply format Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp> * suppress warnings for sensing packages (autowarefoundation#1729) * add Werror for tier4_pcl_extensions * use std::type instead of pcl::type * use std::isfinite instead of pcl_isfinite * fix getFieldIndex * add Werror * fix uninitialized * add Werror * fix string to char* * Fix -Wunused-parameter (autowarefoundation#1836) * Fix -Wunused-parameter Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp> * Fix mistake Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp> * fix spell * Fix lint issues Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp> * Ignore flake8 warnings Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp> Co-authored-by: Hiroki OTA <hiroki.ota@tier4.jp> * Fix clang warnings (autowarefoundation#1859) * Fix -Wreturn-std-move Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp> * Fix -Wunused-private-field Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp> * Ignore -Wnonportable-include-path for mussp Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp> * Fix -Wunused-const-variable Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp> * Fix "can not be used when making a shared object" Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp> * add sort-package-xml hook in pre-commit (autowarefoundation#1881) * add sort xml hook in pre-commit * change retval to exit_status * rename * add prettier plugin-xml * use early return * add license note * add tier4 license * restore prettier * change license order * move local hooks to public repo * move prettier-xml to pre-commit-hooks-ros * update version for bug-fix * apply pre-commit * fix gnss_poser transform (autowarefoundation#1493) (autowarefoundation#1623) * fix gnss_poser transform (autowarefoundation#1493) * fix gnss_poser transform * change transformation method from doTransform to tf2::Transform multiplication * rename tf variables * correct variable spelling Signed-off-by: wep21 <border_goldenmarket@yahoo.co.jp> * Fix lint Signed-off-by: wep21 <border_goldenmarket@yahoo.co.jp> Co-authored-by: hiro-ya-iv <30652835+hiro-ya-iv@users.noreply.github.com> * Change formatter to clang-format and black (autowarefoundation#2332) * Revert "Temporarily comment out pre-commit hooks" This reverts commit 748e9cdb145ce12f8b520bcbd97f5ff899fc28a3. * Replace ament_lint_common with autoware_lint_common Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp> * Remove ament_cmake_uncrustify and ament_clang_format Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp> * Apply Black Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp> * Apply clang-format Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp> * Fix build errors Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp> * Fix for cpplint * Fix include double quotes to angle brackets Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp> * Apply clang-format Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp> * Fix build errors Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp> * Add COLCON_IGNORE (autowarefoundation#500) Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp> * remove COLCON_IGNORE (autowarefoundation#515) * doc gnss poser (autowarefoundation#580) * add minimal doc * fix document title * doc geo conv pos (autowarefoundation#573) * add minimal doc * fix document title * Remove template comments from node documents (autowarefoundation#608) * rename document file * remove template comment Co-authored-by: YamatoAndo <yamato.ando@gmail.com> Co-authored-by: Daichi Murakami <harihitode@gmail.com> Co-authored-by: Kenji Miyake <31987104+kenji-miyake@users.noreply.github.com> Co-authored-by: mitsudome-r <ryohsuke.mitsudome@tier4.jp> Co-authored-by: Jilada Eccleston <jilada.eccleston@gmail.com> Co-authored-by: Nikolai Morin <nnmmgit@gmail.com> Co-authored-by: Takamasa Horibe <horibe.takamasa@gmail.com> Co-authored-by: Frederik Beaujean <72439809+fred-apex-ai@users.noreply.github.com> Co-authored-by: Kosuke Murakami <kosuke.murakami@tier4.jp> Co-authored-by: Ryohsuke Mitsudome <43976834+mitsudome-r@users.noreply.github.com> Co-authored-by: Autoware <autoware@tier4.jp> Co-authored-by: wep21 <border_goldenmarket@yahoo.co.jp> Co-authored-by: Daisuke Nishimatsu <42202095+wep21@users.noreply.github.com> Co-authored-by: tkimura4 <tomoya.kimura@tier4.jp> Co-authored-by: Keisuke Shima <19993104+KeisukeShima@users.noreply.github.com> Co-authored-by: Kazuki Miyahara <kmiya@outlook.com> Co-authored-by: pre-commit <pre-commit@example.com> Co-authored-by: Hiroki OTA <hiroki.ota@tier4.jp> Co-authored-by: hiro-ya-iv <30652835+hiro-ya-iv@users.noreply.github.com> Co-authored-by: Satoshi OTA <44889564+satoshi-ota@users.noreply.github.com> Co-authored-by: taikitanaka3 <65527974+taikitanaka3@users.noreply.github.com>

Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>

chore: sync upstream

Signed-off-by: kosuke55 <kosuke.tnp@gmail.com>

Signed-off-by: GitHub <noreply@github.com> Co-authored-by: tier4-autoware-private-bot <tier4-autoware-private-bot@users.noreply.github.com> Co-authored-by: Yuma Nihei <yuma.nihei@tier4.jp>

h-ohta added 2 commits January 25, 2022 15:50

feat: add Werror

3bfeead

Signed-off-by: h-ohta <hiroki.ota@tier4.jp>

fix: fix deprecated-declarations

dc03a8a

Signed-off-by: h-ohta <hiroki.ota@tier4.jp>

kenji-miyake approved these changes Jan 25, 2022

View reviewed changes

kosuke55 pushed a commit to kosuke55/autoware.universe that referenced this pull request Jan 27, 2022

[gnss_poser] fix namespace for component (autowarefoundation#295)

2508e19

Signed-off-by: Takamasa Horibe <horibe.takamasa@gmail.com>

kenji-miyake merged commit e792ed6 into autowarefoundation:tier4/proposal Feb 2, 2022

kenji-miyake deleted the fix/suppress_warnings_vehicle_velocity_converter branch February 2, 2022 01:36

wep21 mentioned this pull request Feb 8, 2022

chore: sync upstream tier4/autoware.universe#5

Merged

TomohitoAndo pushed a commit to TomohitoAndo/autoware.universe that referenced this pull request Oct 5, 2022

use_twist_with_covariance is false (autowarefoundation#295)

4b2a90a

TomohitoAndo pushed a commit to TomohitoAndo/autoware.universe that referenced this pull request Oct 5, 2022

feat(planning_launch): add bounds_search_widths (autowarefoundation#295)

e95e243

Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>

TomohitoAndo pushed a commit to TomohitoAndo/autoware.universe that referenced this pull request Oct 5, 2022

feat(planning_launch): add bounds_search_widths (autowarefoundation#295)

fc58b9e

Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>

shmpwk pushed a commit to shmpwk/autoware.universe that referenced this pull request Mar 10, 2023

Merge pull request autowarefoundation#295 from tier4/sync-upstream

29fe9c6

chore: sync upstream

keiota pushed a commit to keiota/autoware.universe that referenced this pull request Aug 17, 2023

feat(rviz): add rough goal (autowarefoundation#295)

6b97c8c

Signed-off-by: kosuke55 <kosuke.tnp@gmail.com>

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix(vehicle velocity converter): suppress warnings #295

fix(vehicle velocity converter): suppress warnings #295

h-ohta commented Jan 25, 2022 •

edited

Loading

fix(vehicle velocity converter): suppress warnings #295

fix(vehicle velocity converter): suppress warnings #295

Conversation

h-ohta commented Jan 25, 2022 • edited Loading

Related Issue(required)

Description(required)

Review Procedure(required)

Related PR(optional)

Pre-Review Checklist for the PR Author

Checklist for the PR Reviewer

Post-Review Checklist for the PR Author

CI Checks

h-ohta commented Jan 25, 2022 •

edited

Loading