Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(map based prediction): suppress warnings #296

Conversation

h-ohta
Copy link
Contributor

@h-ohta h-ohta commented Jan 25, 2022

Related Issue(required)

Description(required)

This PR has below changes.

  • suppess warnings -Wunused-parameter and -Wformat-security
  • add Werror
  • fix clang-tidy error
    error: method 'getPredictedPath' can be made const [readability-make-member-function-const,-warnings-as-errors]
    error: method 'getLinearPredictedPath' can be made const [readability-make-member-function-const,-warnings-as-errors]
    

Review Procedure(required)

Related PR(optional)

Pre-Review Checklist for the PR Author

PR Author should check the checkboxes below when creating the PR.

If you are adding new package following items are required:

  • Documentation with description of the package is available
  • A sample launch file and parameter file are available if the package contains executable nodes

Checklist for the PR Reviewer

Reviewers should check the checkboxes below before approval.

  • Commits are properly organized and messages are according to the guideline
  • PR title describes the changes

Post-Review Checklist for the PR Author

PR Author should check the checkboxes below before merging.

  • All open points are addressed and tracked via issues or tickets

CI Checks

  • Build and test for PR / build-and-test-pr: Required to pass before the merge.
  • Build and test for PR / clang-tidy-pr: NOT required to pass before the merge. It is up to the reviewer(s). Found false positives? See the [guidelines][clang-tidy-guidelines].
  • Check spelling: NOT required to pass before the merge. It is up to the reviewer(s). See here if you want to add some words to the spell check dictionary.

Signed-off-by: h-ohta <hiroki.ota@tier4.jp>
Signed-off-by: h-ohta <hiroki.ota@tier4.jp>
Signed-off-by: h-ohta <hiroki.ota@tier4.jp>
kenji-miyake
kenji-miyake previously approved these changes Jan 25, 2022
Signed-off-by: h-ohta <hiroki.ota@tier4.jp>
kosuke55 pushed a commit to kosuke55/autoware.universe that referenced this pull request Jan 27, 2022
* [gnss_poser] fix link to Geographiclib

* Fix mismatching spaces inside () after command

Signed-off-by: wep21 <border_goldenmarket@yahoo.co.jp>

Co-authored-by: Autoware <autoware@tier4.jp>
Co-authored-by: wep21 <border_goldenmarket@yahoo.co.jp>
@h-ohta h-ohta requested a review from kenji-miyake February 2, 2022 00:37
@kenji-miyake kenji-miyake merged commit 9018820 into autowarefoundation:tier4/proposal Feb 2, 2022
@kenji-miyake kenji-miyake deleted the fix/suppress_warnings_map_based_prediction branch February 2, 2022 01:17
badai-nguyen pushed a commit to badai-nguyen/autoware.universe that referenced this pull request Feb 4, 2022
* rename gnss package (autowarefoundation#714)

Signed-off-by: Yamato Ando <yamato.ando@gmail.com>

* Avoid setting CMAKE_BUILD_TYPE=Release in each CMakeLists.txt (autowarefoundation#720)

* remove set CMAKE_BUILD_TYPE Release in each CMakeLists.txt

* remove set CMAKE_BUILD_TYPE Release in ndt_pcl_modified

* set compile options for debug in ndt_omp

* Fix indent

* add warning if -DCMAKE_BUILD_TYPE=Release is not set in ndt_omp

Co-authored-by: Kenji Miyake <31987104+kenji-miyake@users.noreply.github.com>

* remove ROS1 packages temporarily

Signed-off-by: mitsudome-r <ryohsuke.mitsudome@tier4.jp>

* Revert "remove ROS1 packages temporarily"

This reverts commit bc523d679e6737ec37be4fdcbdedca141411bd9d.

Signed-off-by: mitsudome-r <ryohsuke.mitsudome@tier4.jp>

* add COLCON_IGNORE to ros1 packages

Signed-off-by: mitsudome-r <ryohsuke.mitsudome@tier4.jp>

* ROS2 Porting: geo_pos_conv (#8)

* Convert to ROS2 package
 - Update changelog -> 2.0.0
 - Update package xml to use the ROS2 xml schema
 - Update CMakelist with ament cmake commands
 - Add ROS2 compile options

* Convert CMakelist for foxy

* Clean up
 - Remove comments

* Remove colcon ignore

* Rename launch files to launch.xml (autowarefoundation#28)

* ROS2 Porting: gnss_poser (autowarefoundation#18)

* Fix CMakelist
 - Add ublox_msgs package dependency
 - Rename header files to use the .hpp extention
 - Remove colcon ignore
 - Fix Cmake ref to ublox in dependency

* Fix compilation issues with convert.hpp
 - Add sensor_msgs::NavSatFix header which was missing before (?)
 - Remove logging for now
 - Contains warnings - geographic lib error polymorphous error
 - Fix geographic lib -Wcatch-value warnings
 - Add ifndef guard in gnss_stat.hpp

* First pass - successful compilation
 - Fix CMakelist geographic library
 - Remove references to main ROS functions
 - Convert msg references
 - Add ifndef guards
 - Convert tf2 methods
 - Add functionality back
 - Fix type errors

* Add publishers and subscribers
 - Add parameters

* Convert launch files to ROS2 format

* Add logging

* Convert to component

* Fix define guards to follow ROS2/Google style

* Add -Werror compile flag

* Clean up

* Fix CMakelist to allow for the node to be found via ros2 launch
 - Revert filenames so it is easier to review

* Address PR Comments:
 - Fix CMakelist and package.xml
 - Remove redundant depend/exec_depend calls
 - Remove redundant find_package calls
 - Explicitly add headers to the library

* Address PR comments:
 - Revert removal of GNSSPoser namespace
 - Use std::make_shared in place of new
 - Reorder includes to conform with standard

* Address PR Comments:
 - Rename variable to conform with the google style guide
 - Use the node clock in logging method calls

* Address PR Comment:
 - Convert transform broadcaster to shared pointer

* Address PR comment:
 - Remove -Werror compile flag post discussion

* fix duration unit for RCLCPP_*_THROTTLE (autowarefoundation#75)

Signed-off-by: Takamasa Horibe <horibe.takamasa@gmail.com>

* [gnss_poser] switch broadcaster to full member... (autowarefoundation#136)

instead of `shared_ptr` to avoid undefined behavior when executing the node because it used `shared_from_this()` in the constructor

* Adjust copyright notice on 532 out of 699 source files (autowarefoundation#143)

* Use quotes for includes where appropriate (autowarefoundation#144)

* Use quotes for includes where appropriate

* Fix lint tests

* Make tests pass hopefully

* Run uncrustify on the entire Pilot.Auto codebase (autowarefoundation#151)

* Run uncrustify on the entire Pilot.Auto codebase

* Exclude open PRs

* ROS2 Linting: geo_pos_conv (autowarefoundation#165)

* Add linters and fix linter issues
 - convert Cmake to use ament_cmake_auto

* Address PR comments:
 - Remove unneeded cast
 - Throw error instead of setting default values to zero

* ROS2 Linting: gnss_poser (autowarefoundation#166)

* Add linting and fix litner errors

* Address PR comment:
 - Use author name instead of user
 - Remove ROS2 maintainer (remnants of older porting)

* apply env_var to  use_sim_time (autowarefoundation#222)

* [gnss_poser] fix namespace for component (autowarefoundation#295)

Signed-off-by: Takamasa Horibe <horibe.takamasa@gmail.com>

* [gnss_poser] fix link to Geographiclib (autowarefoundation#296)

* [gnss_poser] fix link to Geographiclib

* Fix mismatching spaces inside () after command

Signed-off-by: wep21 <border_goldenmarket@yahoo.co.jp>

Co-authored-by: Autoware <autoware@tier4.jp>
Co-authored-by: wep21 <border_goldenmarket@yahoo.co.jp>

* Ros2 v0.8.0 gnss poser (autowarefoundation#287)

* [gnss poser]: Remove std_msgs (autowarefoundation#341)

Signed-off-by: wep21 <border_goldenmarket@yahoo.co.jp>

* add use_sim-time option (autowarefoundation#454)

* Format launch files (autowarefoundation#1219)

Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>

* Fix for rolling (autowarefoundation#1226)

* Replace doc by description

Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>

* Replace ns by push-ros-namespace

Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>

* Remove use_sim_time for set_parameter (autowarefoundation#1260)

Signed-off-by: wep21 <border_goldenmarket@yahoo.co.jp>

* Add pre-commit (autowarefoundation#1560)

* add pre-commit

* add pre-commit-config

* add additional settings for private repository

* use default pre-commit-config

* update pre-commit setting

* Ignore whitespace for line breaks in markdown

* Update .github/workflows/pre-commit.yml

Co-authored-by: Kazuki Miyahara <kmiya@outlook.com>

* exclude svg

* remove pretty-format-json

* add double-quote-string-fixer

* consider COLCON_IGNORE file when seaching modified package

* format file

* pre-commit fixes

* Update pre-commit.yml

* Update .pre-commit-config.yaml

Co-authored-by: Kazuki Miyahara <kmiya@outlook.com>
Co-authored-by: pre-commit <pre-commit@example.com>
Co-authored-by: Kenji Miyake <31987104+kenji-miyake@users.noreply.github.com>

* Add markdownlint and prettier (autowarefoundation#1661)

* Add markdownlint and prettier

Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>

* Ignore .param.yaml

Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>

* Apply format

Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>

* suppress warnings for sensing packages (autowarefoundation#1729)

* add Werror for tier4_pcl_extensions

* use std::type  instead of pcl::type

* use std::isfinite instead of pcl_isfinite

* fix getFieldIndex

* add Werror

* fix uninitialized

* add Werror

* fix string to char*

* Fix -Wunused-parameter (autowarefoundation#1836)

* Fix -Wunused-parameter

Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>

* Fix mistake

Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>

* fix spell

* Fix lint issues

Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>

* Ignore flake8 warnings

Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>

Co-authored-by: Hiroki OTA <hiroki.ota@tier4.jp>

* Fix clang warnings (autowarefoundation#1859)

* Fix -Wreturn-std-move

Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>

* Fix -Wunused-private-field

Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>

* Ignore -Wnonportable-include-path for mussp

Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>

* Fix -Wunused-const-variable

Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>

* Fix "can not be used when making a shared object"

Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>

* add sort-package-xml hook in pre-commit (autowarefoundation#1881)

* add sort xml hook in pre-commit

* change retval to exit_status

* rename

* add prettier plugin-xml

* use early return

* add license note

* add tier4 license

* restore prettier

* change license order

* move local hooks to public repo

* move prettier-xml to pre-commit-hooks-ros

* update version for bug-fix

* apply pre-commit

* fix gnss_poser transform (autowarefoundation#1493) (autowarefoundation#1623)

* fix gnss_poser transform (autowarefoundation#1493)

* fix gnss_poser transform

* change transformation method from doTransform to tf2::Transform multiplication

* rename tf variables

* correct variable spelling

Signed-off-by: wep21 <border_goldenmarket@yahoo.co.jp>

* Fix lint

Signed-off-by: wep21 <border_goldenmarket@yahoo.co.jp>

Co-authored-by: hiro-ya-iv <30652835+hiro-ya-iv@users.noreply.github.com>

* Change formatter to clang-format and black (autowarefoundation#2332)

* Revert "Temporarily comment out pre-commit hooks"

This reverts commit 748e9cdb145ce12f8b520bcbd97f5ff899fc28a3.

* Replace ament_lint_common with autoware_lint_common

Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>

* Remove ament_cmake_uncrustify and ament_clang_format

Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>

* Apply Black

Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>

* Apply clang-format

Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>

* Fix build errors

Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>

* Fix for cpplint

* Fix include double quotes to angle brackets

Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>

* Apply clang-format

Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>

* Fix build errors

Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>

* Add COLCON_IGNORE (autowarefoundation#500)

Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>

* remove COLCON_IGNORE (autowarefoundation#515)

* doc gnss poser (autowarefoundation#580)

* add minimal doc

* fix document title

* doc geo conv pos (autowarefoundation#573)

* add minimal doc

* fix document title

* Remove template comments from node documents (autowarefoundation#608)

* rename document file

* remove template comment

Co-authored-by: YamatoAndo <yamato.ando@gmail.com>
Co-authored-by: Daichi Murakami <harihitode@gmail.com>
Co-authored-by: Kenji Miyake <31987104+kenji-miyake@users.noreply.github.com>
Co-authored-by: mitsudome-r <ryohsuke.mitsudome@tier4.jp>
Co-authored-by: Jilada Eccleston <jilada.eccleston@gmail.com>
Co-authored-by: Nikolai Morin <nnmmgit@gmail.com>
Co-authored-by: Takamasa Horibe <horibe.takamasa@gmail.com>
Co-authored-by: Frederik Beaujean <72439809+fred-apex-ai@users.noreply.github.com>
Co-authored-by: Kosuke Murakami <kosuke.murakami@tier4.jp>
Co-authored-by: Ryohsuke Mitsudome <43976834+mitsudome-r@users.noreply.github.com>
Co-authored-by: Autoware <autoware@tier4.jp>
Co-authored-by: wep21 <border_goldenmarket@yahoo.co.jp>
Co-authored-by: Daisuke Nishimatsu <42202095+wep21@users.noreply.github.com>
Co-authored-by: tkimura4 <tomoya.kimura@tier4.jp>
Co-authored-by: Keisuke Shima <19993104+KeisukeShima@users.noreply.github.com>
Co-authored-by: Kazuki Miyahara <kmiya@outlook.com>
Co-authored-by: pre-commit <pre-commit@example.com>
Co-authored-by: Hiroki OTA <hiroki.ota@tier4.jp>
Co-authored-by: hiro-ya-iv <30652835+hiro-ya-iv@users.noreply.github.com>
Co-authored-by: Satoshi OTA <44889564+satoshi-ota@users.noreply.github.com>
Co-authored-by: taikitanaka3 <65527974+taikitanaka3@users.noreply.github.com>
badai-nguyen pushed a commit to badai-nguyen/autoware.universe that referenced this pull request Feb 4, 2022
* release v0.4.0

* Feature/phased timestamped velodyne (autowarefoundation#53)

* Replace with new velodyne driver, cutting scan based on azimuth

* Fix launch/dependences

* Fix version name for tier4/velodyne_vls

* Add velodyne_driver dependency

* Nodelet tlr (autowarefoundation#56)

* temporary commit tlr_nodelet

Signed-off-by: Yukihiro Saito <yukky.saito@gmail.com>

* compressed to compressed

Signed-off-by: Yukihiro Saito <yukky.saito@gmail.com>

* Update traffic_light.launch

Signed-off-by: Daisuke Nishimatsu <border_goldenmarket@yahoo.co.jp>

* fix bug

Signed-off-by: Yukihiro Saito <yukky.saito@gmail.com>

* change image_transport to relay

Signed-off-by: Yukihiro Saito <yukky.saito@gmail.com>

* fix bug

Signed-off-by: Yukihiro Saito <yukky.saito@gmail.com>

* fix bug

Signed-off-by: Yukihiro Saito <yukky.saito@gmail.com>

* decompress as rgb8

Signed-off-by: Yukihiro Saito <yukky.saito@gmail.com>

* fix bug

Signed-off-by: Yukihiro Saito <yukky.saito@gmail.com>

Co-authored-by: Yukihiro Saito <yukky.saito@gmail.com>

* use env for livox id (autowarefoundation#58)

Signed-off-by: Yukihiro Saito <yukky.saito@gmail.com>

* Feature/optimize scan phase (autowarefoundation#59)

* Rename parameter name, sensor_phase -> scan_phase

Signed-off-by: Akihito Ohasto <aohsato@gmail.com>

* Modify aip_xx1 scan_phase for better perception

* Rename parameter name, sensor_phase -> scan_phase

Signed-off-by: Akihito Ohasto <aohsato@gmail.com>

* Logging simulator (autowarefoundation#65)

* Add logging_simulator.launch

Signed-off-by: Daisuke Nishimatsu <border_goldenmarket@yahoo.co.jp>

* Don't load env when launch driver is false

Signed-off-by: Daisuke Nishimatsu <border_goldenmarket@yahoo.co.jp>

* removed ROS1 package

Signed-off-by: mitsudome-r <ryohsuke.mitsudome@tier4.jp>

* Revert "removed ROS1 package"

This reverts commit 225276afe774a2c9d7bc28ca59accffbdc14dc8a.

* add COLCON_IGNORE file to all ROS1 packages

Signed-off-by: mitsudome-r <ryohsuke.mitsudome@tier4.jp>

* rename *.launch files to *.launch.xml

Signed-off-by: mitsudome-r <ryohsuke.mitsudome@tier4.jp>

* Port sensing_launch (#14)

* [sensing_launch] Initial port without actually launching

* [sensing_launch] default -> value, namespace, first nodelet porting

* [sensing_launch] use usb_cam, eval -> var

* [sensing_launch] Fix syntax errors in pointcloud_preprocessor.launch.py

* [pointcloud-preprocessor] fix ground-filter component name

* [pointcloud-preprocessor] Polish aip_s1/pointcloud_preprocessor.launch.py

Only one error at runtime remains when testing on dev laptop due to pointclouds that need to be available for concatenation

* [sensing_launch] ublox_gps refer to config file properly

* (wip) velodyne_node_container before opaque

* [sensing_launch] Port aip-s1 as far as possible

* [sensing_launch] remove unused pointcloud_preprocessor_nodes.py

* [sensing_launch] Manage to add ComposableNode conditionally

* [sensing_launch] Update camera for s1, x1

* [sensing_launch] Copy aip_s1/ content to aip_customized, aip_x1, aip_x2

because they were identical before the porting

* [sensing_launch] Port livox

* [sensing_launch] Port aip_xx1

* [sensing_launch] Port aip_xx2

* [sensing_launch] Remove superfluous passthrough filter, min_z, max_z

* [sensing_launch] Incorporate changes from vehicle testing

* [sensing_launch] Declare launch argument for base_frame

* [sensing_launch] Missing fixes to launch/velodyne*

* [sensing_launch] Update copied configs

* Added linters (autowarefoundation#32)

* Ros2 v0.8.0 sensing launch (autowarefoundation#57)

* restore file name

Signed-off-by: Takamasa Horibe <horibe.takamasa@gmail.com>

* Update livox_horizon.launch (autowarefoundation#89)

* fix pass through filter launch (autowarefoundation#90)

* fix pass through filter launch

* change if statement style

* update aip_x1 sensing launch (autowarefoundation#100)

* fix livox launch arg (autowarefoundation#108)

* add usb_cam depend (autowarefoundation#118)

* update aip_x1 camera.launch (autowarefoundation#119)

* update imu.launch (autowarefoundation#120)

* fix veodyne setting in aip_x1/lidar.launch (autowarefoundation#125)

* Add velodyne_monitor to velodyne_*.launch (autowarefoundation#101)

Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>

* Uupdate aip_x1 lidar.launch (autowarefoundation#143)

* Format gnss.launch (autowarefoundation#145)

Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>

* Add use_gnss arg to aip_x1 gnss.launch (autowarefoundation#146)

Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>

* support individual params (autowarefoundation#137)

* support individual params

* remove kvaser_hardware_id.txt

* Launch velodyne_monitor only when launch_driver is true (autowarefoundation#163)

Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>

* [sensing_launch] ros2 porting: use container for livox point preprocessor

Signed-off-by: Takamasa Horibe <horibe.takamasa@gmail.com>

* [sensing_launch] ros2-porting: fix vehicle_info params

Signed-off-by: Takamasa Horibe <horibe.takamasa@gmail.com>

* Revert "restore file name"

This reverts commit 37d7ac4f6a2a617b003b4e2a5ac96c48b332ade0.

* [sensing_launch] ros2-porting: fix vehicle_info for livox preprocessor launch

Signed-off-by: Takamasa Horibe <horibe.takamasa@gmail.com>

* [sensing_launch] ros2-porting: fix vehicle_info for api_** points_preprocessor.launch.py

Signed-off-by: Takamasa Horibe <horibe.takamasa@gmail.com>

* fix launch

Signed-off-by: Takamasa Horibe <horibe.takamasa@gmail.com>

* fix livox launch

Signed-off-by: Takamasa Horibe <horibe.takamasa@gmail.com>

* added suffix ".xml" to "velodyne_monitor.launch" in the launch files

* added use_sim_time with AW_ROS2_USE_SIM_TIME envvar for the parameters in  the *.launch.py (autowarefoundation#61)

* added use_sim_time with AW_ROS2_USE_SIM_TIME envvar for the parameters

* changed to use EnvironmentVariable function for use_sim_time parameter

* changed indent

* removed an empty line

Co-authored-by: hosokawa <hosokawa@sng-3f-ros2-eval.l.sng.tier4.jp>

* fixed typo on the arg bd_code_param_path lines (autowarefoundation#63)

Co-authored-by: hosokawa <hosokawa@sng-3f-ros2-eval.l.sng.tier4.jp>

* [sensing_launch]: Fix indentation in gnss launch

Signed-off-by: wep21 <border_goldenmarket@yahoo.co.jp>

* [sensing_launch]: Add missing dependency in package.xml

Signed-off-by: wep21 <border_goldenmarket@yahoo.co.jp>

* [sensing_launch]: Fix velodyne launch

Signed-off-by: wep21 <border_goldenmarket@yahoo.co.jp>

* [sensing_launch]: Fix livox launch

Signed-off-by: wep21 <border_goldenmarket@yahoo.co.jp>

* [sensing_launch]: Add arg for vehicle parameter file in lidar launch

Signed-off-by: wep21 <border_goldenmarket@yahoo.co.jp>

* [sensing_launch]: Cleanup

Signed-off-by: Autoware <autoware@tier4.jp>

* Add new line

Signed-off-by: Autoware <autoware@tier4.jp>

* [sensing_launch]: Add default config for xx1

Signed-off-by: Autoware <autoware@tier4.jp>

* [sensing_launch]: Fix indentation

Signed-off-by: Autoware <autoware@tier4.jp>

Co-authored-by: Yukihiro Saito <yukky.saito@gmail.com>
Co-authored-by: Taichi Higashide <taichi.higashide@tier4.jp>
Co-authored-by: Kenji Miyake <31987104+kenji-miyake@users.noreply.github.com>
Co-authored-by: hiroyuki obinata <58019445+obi-t4@users.noreply.github.com>
Co-authored-by: hosokawa <hosokawa@sng-3f-ros2-eval.l.sng.tier4.jp>
Co-authored-by: HOSOKAWA Ikuto <hosokawa.ikuto@gmail.com>
Co-authored-by: wep21 <border_goldenmarket@yahoo.co.jp>
Co-authored-by: Autoware <autoware@tier4.jp>

* Rename ROS-related .yaml to .param.yaml (autowarefoundation#65)

* Rename ROS-related .yaml to .param.yaml

Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>

* Add missing '--'

Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>

* Rename vehicle_info.yaml to vehicle_info.param.yaml

Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>

* Fix livox param name

Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>

* Sync with Ros2 v0.8.0 beta (autowarefoundation#71)

* update sensing launch to support aip_x1 (autowarefoundation#69)

Signed-off-by: taichiH <azumade.30@gmail.com>

* fix logging_simulator_bug (autowarefoundation#68)

Signed-off-by: taichiH <azumade.30@gmail.com>

* fix aip_x1 param (autowarefoundation#70)

Signed-off-by: taichiH <azumade.30@gmail.com>

Co-authored-by: Taichi Higashide <taichi.higashide@tier4.jp>

* Fix aip_xx1's pointcloud_preprocessor.launch.py (autowarefoundation#72)

Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>

* fix velodyne launch (autowarefoundation#73)

* fix velodyne launch

* fix bug

* add scan_phase arg

* fix bug (autowarefoundation#85)

* Use sensor data qos for pointcloud (autowarefoundation#82)

Signed-off-by: Autoware <autoware@tier4.jp>

Co-authored-by: Autoware <autoware@tier4.jp>

* Remove unused remappings (autowarefoundation#88)

Signed-off-by: wep21 <border_goldenmarket@yahoo.co.jp>

* Livox composable node (autowarefoundation#87)

* Fix default value of use_concat_filter and use_radius_search (autowarefoundation#90)

* Fix default value of use_concat_filter and use_radius_search

Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>

* Fix lint

Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>

* [aip_x1]: Fix imu topic name (autowarefoundation#94)

Signed-off-by: wep21 <border_goldenmarket@yahoo.co.jp>

* Fix various typos in launch files (autowarefoundation#97)

* Move individual params to a separate package (autowarefoundation#100)

Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>

* add use_sim-time option (autowarefoundation#99)

* Format launch files (autowarefoundation#178)

Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>

* Fix bug of pointcloud_preprocessor.py (autowarefoundation#179)

Signed-off-by: autoware <autoware@example.com>

Co-authored-by: autoware <autoware@example.com>

* Replace doc by description (autowarefoundation#182)

Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>

* Ros2 lsim test (autowarefoundation#186)

* Add group to launch file for var scope

Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp>

* Remove pointcloud relay for localization

Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp>

* Add use_sim_time

Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp>

* Remove pointcloud relay for localization

Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp>

Co-authored-by: Takagi, Isamu <isamu.takagi@tier4.jp>

* Add multithread and intra process option (autowarefoundation#187)

* Add multithread and intra process option

Signed-off-by: wep21 <border_goldenmarket@yahoo.co.jp>

* Fix velodyne node container executable

Signed-off-by: wep21 <border_goldenmarket@yahoo.co.jp>

* Add option into aip_xx2

Signed-off-by: wep21 <border_goldenmarket@yahoo.co.jp>

* Add option into aip_x2

Signed-off-by: wep21 <border_goldenmarket@yahoo.co.jp>

* Add option into aip_x1

Signed-off-by: wep21 <border_goldenmarket@yahoo.co.jp>

* Add option into aip_s1

Signed-off-by: wep21 <border_goldenmarket@yahoo.co.jp>

* Add option into aip_customized

Signed-off-by: wep21 <border_goldenmarket@yahoo.co.jp>

* Add option into lidar.launch.xml

Signed-off-by: wep21 <border_goldenmarket@yahoo.co.jp>

* Fix invalid attribute in gnss launch (autowarefoundation#191)

Signed-off-by: wep21 <border_goldenmarket@yahoo.co.jp>

* Fix parameter for scan phase (autowarefoundation#193)

Signed-off-by: wep21 <border_goldenmarket@yahoo.co.jp>

* add septentrio_gnss_driver launcher and switch(septentrio <-> ublox) (autowarefoundation#196)

* add septentrio_gnss_driver launcher and switch(septentrio <-> ublox)

* rm arg(gnss_receiver) escalation and modify septentrio_gnss_driver_node option

* change gnss_receiver default septentrio to ublox

* remap all septentrio_gnss_driver topic names

* replace septentrio gnss driver launch type 'node' to 'include'

* Use set_parameter for use_sim_time (autowarefoundation#198)

* Use set_parameter for use_sim_time

Signed-off-by: wep21 <border_goldenmarket@yahoo.co.jp>

* Add default parameter for scenario simulator

Signed-off-by: wep21 <border_goldenmarket@yahoo.co.jp>

* Format launch files (autowarefoundation#228)

* Format launch files

Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>

* Format launch.py

Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>

* Fix lint

Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>

* Fix aip_xx1 camera launch (autowarefoundation#242)

Signed-off-by: wep21 <border_goldenmarket@yahoo.co.jp>

* Fix gnss topic name (autowarefoundation#243)

Signed-off-by: wep21 <border_goldenmarket@yahoo.co.jp>

* Enable intra process and mt (autowarefoundation#204)

Signed-off-by: wep21 <border_goldenmarket@yahoo.co.jp>

* add imu_corrector (autowarefoundation#296)

* add description for sensing_launch (autowarefoundation#336)

* add description

* fix sentence

* add README.md and svg files (autowarefoundation#328)

* add md and svg

* fix typo

* fix typo

* fix word

* fix typo

* add lack of things

* Update README

* fix depending packages

* fix word

* Fix camera launch invalid type string (autowarefoundation#344)

Signed-off-by: kosuke55 <kosuke.tnp@gmail.com>

* add view width direction to velodyne_node_container.launch.py etc... (autowarefoundation#366)

* add arg of view_width and view_direction

* delete initial value

* add args and params

Co-authored-by: autoware-iv-sync-ci[bot] <87871706+autoware-iv-sync-ci[bot]@users.noreply.github.com>

* Fix pre-commit (autowarefoundation#407)

* Fix pre-commit errors

Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>

* Fix package.xml

Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>

* Fix pre-commit target (autowarefoundation#436)

Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>

* Remove aip xx2 model from sensing launch (autowarefoundation#446)

Signed-off-by: wep21 <border_goldenmarket@yahoo.co.jp>

* Add respawn for ublox (autowarefoundation#449)

Signed-off-by: wep21 <border_goldenmarket@yahoo.co.jp>

* delete aip and modify package settings (autowarefoundation#434)

* Change formatter to black (autowarefoundation#488)

* Update pre-commit settings

* Apply Black

* Replace ament_lint_common with autoware_lint_common

* Update build_depends.repos

* Fix build_depends

* feature/use common pointcloud container (autowarefoundation#147)

* add container argument

* load composable node to pointcloud_container

* fix autoware_launch

* enable multi-thread

* improve readability

* Update package.xml (autowarefoundation#150)

* feat: add default param

* feat: add aip_launcher depends

* fix: add vehicle_info_util as exec_depend

* fix: add velodyne_vls to build_depend.repos

* fix: remove api_launcher at build_depends

Co-authored-by: mitsudome-r <ryohsuke.mitsudome@tier4.jp>
Co-authored-by: Akihito Ohsato <aohsato@gmail.com>
Co-authored-by: Daisuke Nishimatsu <42202095+wep21@users.noreply.github.com>
Co-authored-by: Yukihiro Saito <yukky.saito@gmail.com>
Co-authored-by: Frederik Beaujean <72439809+fred-apex-ai@users.noreply.github.com>
Co-authored-by: Esteve Fernandez <esteve@apache.org>
Co-authored-by: Takamasa Horibe <horibe.takamasa@gmail.com>
Co-authored-by: Taichi Higashide <taichi.higashide@tier4.jp>
Co-authored-by: Kenji Miyake <31987104+kenji-miyake@users.noreply.github.com>
Co-authored-by: hiroyuki obinata <58019445+obi-t4@users.noreply.github.com>
Co-authored-by: hosokawa <hosokawa@sng-3f-ros2-eval.l.sng.tier4.jp>
Co-authored-by: HOSOKAWA Ikuto <hosokawa.ikuto@gmail.com>
Co-authored-by: wep21 <border_goldenmarket@yahoo.co.jp>
Co-authored-by: Autoware <autoware@tier4.jp>
Co-authored-by: Kazuki Miyahara <kmiya@outlook.com>
Co-authored-by: tkimura4 <tomoya.kimura@tier4.jp>
Co-authored-by: autoware <autoware@example.com>
Co-authored-by: Takagi, Isamu <isamu.takagi@tier4.jp>
Co-authored-by: hiro-ya-iv <30652835+hiro-ya-iv@users.noreply.github.com>
Co-authored-by: YamatoAndo <yamato.ando@gmail.com>
Co-authored-by: Hiroki OTA <hiroki.ota@tier4.jp>
Co-authored-by: Kosuke Takeuchi <kosuke.tnp@gmail.com>
Co-authored-by: autoware-iv-sync-ci[bot] <87871706+autoware-iv-sync-ci[bot]@users.noreply.github.com>
Co-authored-by: Kenji Miyake <kenji.miyake@tier4.jp>
Co-authored-by: Satoshi OTA <44889564+satoshi-ota@users.noreply.github.com>
Co-authored-by: taikitanaka3 <65527974+taikitanaka3@users.noreply.github.com>
badai-nguyen pushed a commit to badai-nguyen/autoware.universe that referenced this pull request Feb 4, 2022
* feat: add Werror

Signed-off-by: h-ohta <hiroki.ota@tier4.jp>

* fix: suppress warnings

Signed-off-by: h-ohta <hiroki.ota@tier4.jp>

* fix: still use RCLCPP_ERROR

Signed-off-by: h-ohta <hiroki.ota@tier4.jp>

* fix: add const

Signed-off-by: h-ohta <hiroki.ota@tier4.jp>
badai-nguyen pushed a commit to badai-nguyen/autoware.universe that referenced this pull request Feb 4, 2022
* rename gnss package (autowarefoundation#714)

Signed-off-by: Yamato Ando <yamato.ando@gmail.com>

* Avoid setting CMAKE_BUILD_TYPE=Release in each CMakeLists.txt (autowarefoundation#720)

* remove set CMAKE_BUILD_TYPE Release in each CMakeLists.txt

* remove set CMAKE_BUILD_TYPE Release in ndt_pcl_modified

* set compile options for debug in ndt_omp

* Fix indent

* add warning if -DCMAKE_BUILD_TYPE=Release is not set in ndt_omp

Co-authored-by: Kenji Miyake <31987104+kenji-miyake@users.noreply.github.com>

* remove ROS1 packages temporarily

Signed-off-by: mitsudome-r <ryohsuke.mitsudome@tier4.jp>

* Revert "remove ROS1 packages temporarily"

This reverts commit bc523d679e6737ec37be4fdcbdedca141411bd9d.

Signed-off-by: mitsudome-r <ryohsuke.mitsudome@tier4.jp>

* add COLCON_IGNORE to ros1 packages

Signed-off-by: mitsudome-r <ryohsuke.mitsudome@tier4.jp>

* ROS2 Porting: geo_pos_conv (#8)

* Convert to ROS2 package
 - Update changelog -> 2.0.0
 - Update package xml to use the ROS2 xml schema
 - Update CMakelist with ament cmake commands
 - Add ROS2 compile options

* Convert CMakelist for foxy

* Clean up
 - Remove comments

* Remove colcon ignore

* Rename launch files to launch.xml (autowarefoundation#28)

* ROS2 Porting: gnss_poser (autowarefoundation#18)

* Fix CMakelist
 - Add ublox_msgs package dependency
 - Rename header files to use the .hpp extention
 - Remove colcon ignore
 - Fix Cmake ref to ublox in dependency

* Fix compilation issues with convert.hpp
 - Add sensor_msgs::NavSatFix header which was missing before (?)
 - Remove logging for now
 - Contains warnings - geographic lib error polymorphous error
 - Fix geographic lib -Wcatch-value warnings
 - Add ifndef guard in gnss_stat.hpp

* First pass - successful compilation
 - Fix CMakelist geographic library
 - Remove references to main ROS functions
 - Convert msg references
 - Add ifndef guards
 - Convert tf2 methods
 - Add functionality back
 - Fix type errors

* Add publishers and subscribers
 - Add parameters

* Convert launch files to ROS2 format

* Add logging

* Convert to component

* Fix define guards to follow ROS2/Google style

* Add -Werror compile flag

* Clean up

* Fix CMakelist to allow for the node to be found via ros2 launch
 - Revert filenames so it is easier to review

* Address PR Comments:
 - Fix CMakelist and package.xml
 - Remove redundant depend/exec_depend calls
 - Remove redundant find_package calls
 - Explicitly add headers to the library

* Address PR comments:
 - Revert removal of GNSSPoser namespace
 - Use std::make_shared in place of new
 - Reorder includes to conform with standard

* Address PR Comments:
 - Rename variable to conform with the google style guide
 - Use the node clock in logging method calls

* Address PR Comment:
 - Convert transform broadcaster to shared pointer

* Address PR comment:
 - Remove -Werror compile flag post discussion

* fix duration unit for RCLCPP_*_THROTTLE (autowarefoundation#75)

Signed-off-by: Takamasa Horibe <horibe.takamasa@gmail.com>

* [gnss_poser] switch broadcaster to full member... (autowarefoundation#136)

instead of `shared_ptr` to avoid undefined behavior when executing the node because it used `shared_from_this()` in the constructor

* Adjust copyright notice on 532 out of 699 source files (autowarefoundation#143)

* Use quotes for includes where appropriate (autowarefoundation#144)

* Use quotes for includes where appropriate

* Fix lint tests

* Make tests pass hopefully

* Run uncrustify on the entire Pilot.Auto codebase (autowarefoundation#151)

* Run uncrustify on the entire Pilot.Auto codebase

* Exclude open PRs

* ROS2 Linting: geo_pos_conv (autowarefoundation#165)

* Add linters and fix linter issues
 - convert Cmake to use ament_cmake_auto

* Address PR comments:
 - Remove unneeded cast
 - Throw error instead of setting default values to zero

* ROS2 Linting: gnss_poser (autowarefoundation#166)

* Add linting and fix litner errors

* Address PR comment:
 - Use author name instead of user
 - Remove ROS2 maintainer (remnants of older porting)

* apply env_var to  use_sim_time (autowarefoundation#222)

* [gnss_poser] fix namespace for component (autowarefoundation#295)

Signed-off-by: Takamasa Horibe <horibe.takamasa@gmail.com>

* [gnss_poser] fix link to Geographiclib (autowarefoundation#296)

* [gnss_poser] fix link to Geographiclib

* Fix mismatching spaces inside () after command

Signed-off-by: wep21 <border_goldenmarket@yahoo.co.jp>

Co-authored-by: Autoware <autoware@tier4.jp>
Co-authored-by: wep21 <border_goldenmarket@yahoo.co.jp>

* Ros2 v0.8.0 gnss poser (autowarefoundation#287)

* [gnss poser]: Remove std_msgs (autowarefoundation#341)

Signed-off-by: wep21 <border_goldenmarket@yahoo.co.jp>

* add use_sim-time option (autowarefoundation#454)

* Format launch files (autowarefoundation#1219)

Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>

* Fix for rolling (autowarefoundation#1226)

* Replace doc by description

Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>

* Replace ns by push-ros-namespace

Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>

* Remove use_sim_time for set_parameter (autowarefoundation#1260)

Signed-off-by: wep21 <border_goldenmarket@yahoo.co.jp>

* Add pre-commit (autowarefoundation#1560)

* add pre-commit

* add pre-commit-config

* add additional settings for private repository

* use default pre-commit-config

* update pre-commit setting

* Ignore whitespace for line breaks in markdown

* Update .github/workflows/pre-commit.yml

Co-authored-by: Kazuki Miyahara <kmiya@outlook.com>

* exclude svg

* remove pretty-format-json

* add double-quote-string-fixer

* consider COLCON_IGNORE file when seaching modified package

* format file

* pre-commit fixes

* Update pre-commit.yml

* Update .pre-commit-config.yaml

Co-authored-by: Kazuki Miyahara <kmiya@outlook.com>
Co-authored-by: pre-commit <pre-commit@example.com>
Co-authored-by: Kenji Miyake <31987104+kenji-miyake@users.noreply.github.com>

* Add markdownlint and prettier (autowarefoundation#1661)

* Add markdownlint and prettier

Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>

* Ignore .param.yaml

Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>

* Apply format

Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>

* suppress warnings for sensing packages (autowarefoundation#1729)

* add Werror for tier4_pcl_extensions

* use std::type  instead of pcl::type

* use std::isfinite instead of pcl_isfinite

* fix getFieldIndex

* add Werror

* fix uninitialized

* add Werror

* fix string to char*

* Fix -Wunused-parameter (autowarefoundation#1836)

* Fix -Wunused-parameter

Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>

* Fix mistake

Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>

* fix spell

* Fix lint issues

Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>

* Ignore flake8 warnings

Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>

Co-authored-by: Hiroki OTA <hiroki.ota@tier4.jp>

* Fix clang warnings (autowarefoundation#1859)

* Fix -Wreturn-std-move

Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>

* Fix -Wunused-private-field

Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>

* Ignore -Wnonportable-include-path for mussp

Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>

* Fix -Wunused-const-variable

Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>

* Fix "can not be used when making a shared object"

Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>

* add sort-package-xml hook in pre-commit (autowarefoundation#1881)

* add sort xml hook in pre-commit

* change retval to exit_status

* rename

* add prettier plugin-xml

* use early return

* add license note

* add tier4 license

* restore prettier

* change license order

* move local hooks to public repo

* move prettier-xml to pre-commit-hooks-ros

* update version for bug-fix

* apply pre-commit

* fix gnss_poser transform (autowarefoundation#1493) (autowarefoundation#1623)

* fix gnss_poser transform (autowarefoundation#1493)

* fix gnss_poser transform

* change transformation method from doTransform to tf2::Transform multiplication

* rename tf variables

* correct variable spelling

Signed-off-by: wep21 <border_goldenmarket@yahoo.co.jp>

* Fix lint

Signed-off-by: wep21 <border_goldenmarket@yahoo.co.jp>

Co-authored-by: hiro-ya-iv <30652835+hiro-ya-iv@users.noreply.github.com>

* Change formatter to clang-format and black (autowarefoundation#2332)

* Revert "Temporarily comment out pre-commit hooks"

This reverts commit 748e9cdb145ce12f8b520bcbd97f5ff899fc28a3.

* Replace ament_lint_common with autoware_lint_common

Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>

* Remove ament_cmake_uncrustify and ament_clang_format

Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>

* Apply Black

Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>

* Apply clang-format

Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>

* Fix build errors

Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>

* Fix for cpplint

* Fix include double quotes to angle brackets

Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>

* Apply clang-format

Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>

* Fix build errors

Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>

* Add COLCON_IGNORE (autowarefoundation#500)

Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>

* remove COLCON_IGNORE (autowarefoundation#515)

* doc gnss poser (autowarefoundation#580)

* add minimal doc

* fix document title

* doc geo conv pos (autowarefoundation#573)

* add minimal doc

* fix document title

* Remove template comments from node documents (autowarefoundation#608)

* rename document file

* remove template comment

Co-authored-by: YamatoAndo <yamato.ando@gmail.com>
Co-authored-by: Daichi Murakami <harihitode@gmail.com>
Co-authored-by: Kenji Miyake <31987104+kenji-miyake@users.noreply.github.com>
Co-authored-by: mitsudome-r <ryohsuke.mitsudome@tier4.jp>
Co-authored-by: Jilada Eccleston <jilada.eccleston@gmail.com>
Co-authored-by: Nikolai Morin <nnmmgit@gmail.com>
Co-authored-by: Takamasa Horibe <horibe.takamasa@gmail.com>
Co-authored-by: Frederik Beaujean <72439809+fred-apex-ai@users.noreply.github.com>
Co-authored-by: Kosuke Murakami <kosuke.murakami@tier4.jp>
Co-authored-by: Ryohsuke Mitsudome <43976834+mitsudome-r@users.noreply.github.com>
Co-authored-by: Autoware <autoware@tier4.jp>
Co-authored-by: wep21 <border_goldenmarket@yahoo.co.jp>
Co-authored-by: Daisuke Nishimatsu <42202095+wep21@users.noreply.github.com>
Co-authored-by: tkimura4 <tomoya.kimura@tier4.jp>
Co-authored-by: Keisuke Shima <19993104+KeisukeShima@users.noreply.github.com>
Co-authored-by: Kazuki Miyahara <kmiya@outlook.com>
Co-authored-by: pre-commit <pre-commit@example.com>
Co-authored-by: Hiroki OTA <hiroki.ota@tier4.jp>
Co-authored-by: hiro-ya-iv <30652835+hiro-ya-iv@users.noreply.github.com>
Co-authored-by: Satoshi OTA <44889564+satoshi-ota@users.noreply.github.com>
Co-authored-by: taikitanaka3 <65527974+taikitanaka3@users.noreply.github.com>
badai-nguyen pushed a commit to badai-nguyen/autoware.universe that referenced this pull request Feb 4, 2022
* release v0.4.0

* Feature/phased timestamped velodyne (autowarefoundation#53)

* Replace with new velodyne driver, cutting scan based on azimuth

* Fix launch/dependences

* Fix version name for tier4/velodyne_vls

* Add velodyne_driver dependency

* Nodelet tlr (autowarefoundation#56)

* temporary commit tlr_nodelet

Signed-off-by: Yukihiro Saito <yukky.saito@gmail.com>

* compressed to compressed

Signed-off-by: Yukihiro Saito <yukky.saito@gmail.com>

* Update traffic_light.launch

Signed-off-by: Daisuke Nishimatsu <border_goldenmarket@yahoo.co.jp>

* fix bug

Signed-off-by: Yukihiro Saito <yukky.saito@gmail.com>

* change image_transport to relay

Signed-off-by: Yukihiro Saito <yukky.saito@gmail.com>

* fix bug

Signed-off-by: Yukihiro Saito <yukky.saito@gmail.com>

* fix bug

Signed-off-by: Yukihiro Saito <yukky.saito@gmail.com>

* decompress as rgb8

Signed-off-by: Yukihiro Saito <yukky.saito@gmail.com>

* fix bug

Signed-off-by: Yukihiro Saito <yukky.saito@gmail.com>

Co-authored-by: Yukihiro Saito <yukky.saito@gmail.com>

* use env for livox id (autowarefoundation#58)

Signed-off-by: Yukihiro Saito <yukky.saito@gmail.com>

* Feature/optimize scan phase (autowarefoundation#59)

* Rename parameter name, sensor_phase -> scan_phase

Signed-off-by: Akihito Ohasto <aohsato@gmail.com>

* Modify aip_xx1 scan_phase for better perception

* Rename parameter name, sensor_phase -> scan_phase

Signed-off-by: Akihito Ohasto <aohsato@gmail.com>

* Logging simulator (autowarefoundation#65)

* Add logging_simulator.launch

Signed-off-by: Daisuke Nishimatsu <border_goldenmarket@yahoo.co.jp>

* Don't load env when launch driver is false

Signed-off-by: Daisuke Nishimatsu <border_goldenmarket@yahoo.co.jp>

* removed ROS1 package

Signed-off-by: mitsudome-r <ryohsuke.mitsudome@tier4.jp>

* Revert "removed ROS1 package"

This reverts commit 225276afe774a2c9d7bc28ca59accffbdc14dc8a.

* add COLCON_IGNORE file to all ROS1 packages

Signed-off-by: mitsudome-r <ryohsuke.mitsudome@tier4.jp>

* rename *.launch files to *.launch.xml

Signed-off-by: mitsudome-r <ryohsuke.mitsudome@tier4.jp>

* Port sensing_launch (#14)

* [sensing_launch] Initial port without actually launching

* [sensing_launch] default -> value, namespace, first nodelet porting

* [sensing_launch] use usb_cam, eval -> var

* [sensing_launch] Fix syntax errors in pointcloud_preprocessor.launch.py

* [pointcloud-preprocessor] fix ground-filter component name

* [pointcloud-preprocessor] Polish aip_s1/pointcloud_preprocessor.launch.py

Only one error at runtime remains when testing on dev laptop due to pointclouds that need to be available for concatenation

* [sensing_launch] ublox_gps refer to config file properly

* (wip) velodyne_node_container before opaque

* [sensing_launch] Port aip-s1 as far as possible

* [sensing_launch] remove unused pointcloud_preprocessor_nodes.py

* [sensing_launch] Manage to add ComposableNode conditionally

* [sensing_launch] Update camera for s1, x1

* [sensing_launch] Copy aip_s1/ content to aip_customized, aip_x1, aip_x2

because they were identical before the porting

* [sensing_launch] Port livox

* [sensing_launch] Port aip_xx1

* [sensing_launch] Port aip_xx2

* [sensing_launch] Remove superfluous passthrough filter, min_z, max_z

* [sensing_launch] Incorporate changes from vehicle testing

* [sensing_launch] Declare launch argument for base_frame

* [sensing_launch] Missing fixes to launch/velodyne*

* [sensing_launch] Update copied configs

* Added linters (autowarefoundation#32)

* Ros2 v0.8.0 sensing launch (autowarefoundation#57)

* restore file name

Signed-off-by: Takamasa Horibe <horibe.takamasa@gmail.com>

* Update livox_horizon.launch (autowarefoundation#89)

* fix pass through filter launch (autowarefoundation#90)

* fix pass through filter launch

* change if statement style

* update aip_x1 sensing launch (autowarefoundation#100)

* fix livox launch arg (autowarefoundation#108)

* add usb_cam depend (autowarefoundation#118)

* update aip_x1 camera.launch (autowarefoundation#119)

* update imu.launch (autowarefoundation#120)

* fix veodyne setting in aip_x1/lidar.launch (autowarefoundation#125)

* Add velodyne_monitor to velodyne_*.launch (autowarefoundation#101)

Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>

* Uupdate aip_x1 lidar.launch (autowarefoundation#143)

* Format gnss.launch (autowarefoundation#145)

Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>

* Add use_gnss arg to aip_x1 gnss.launch (autowarefoundation#146)

Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>

* support individual params (autowarefoundation#137)

* support individual params

* remove kvaser_hardware_id.txt

* Launch velodyne_monitor only when launch_driver is true (autowarefoundation#163)

Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>

* [sensing_launch] ros2 porting: use container for livox point preprocessor

Signed-off-by: Takamasa Horibe <horibe.takamasa@gmail.com>

* [sensing_launch] ros2-porting: fix vehicle_info params

Signed-off-by: Takamasa Horibe <horibe.takamasa@gmail.com>

* Revert "restore file name"

This reverts commit 37d7ac4f6a2a617b003b4e2a5ac96c48b332ade0.

* [sensing_launch] ros2-porting: fix vehicle_info for livox preprocessor launch

Signed-off-by: Takamasa Horibe <horibe.takamasa@gmail.com>

* [sensing_launch] ros2-porting: fix vehicle_info for api_** points_preprocessor.launch.py

Signed-off-by: Takamasa Horibe <horibe.takamasa@gmail.com>

* fix launch

Signed-off-by: Takamasa Horibe <horibe.takamasa@gmail.com>

* fix livox launch

Signed-off-by: Takamasa Horibe <horibe.takamasa@gmail.com>

* added suffix ".xml" to "velodyne_monitor.launch" in the launch files

* added use_sim_time with AW_ROS2_USE_SIM_TIME envvar for the parameters in  the *.launch.py (autowarefoundation#61)

* added use_sim_time with AW_ROS2_USE_SIM_TIME envvar for the parameters

* changed to use EnvironmentVariable function for use_sim_time parameter

* changed indent

* removed an empty line

Co-authored-by: hosokawa <hosokawa@sng-3f-ros2-eval.l.sng.tier4.jp>

* fixed typo on the arg bd_code_param_path lines (autowarefoundation#63)

Co-authored-by: hosokawa <hosokawa@sng-3f-ros2-eval.l.sng.tier4.jp>

* [sensing_launch]: Fix indentation in gnss launch

Signed-off-by: wep21 <border_goldenmarket@yahoo.co.jp>

* [sensing_launch]: Add missing dependency in package.xml

Signed-off-by: wep21 <border_goldenmarket@yahoo.co.jp>

* [sensing_launch]: Fix velodyne launch

Signed-off-by: wep21 <border_goldenmarket@yahoo.co.jp>

* [sensing_launch]: Fix livox launch

Signed-off-by: wep21 <border_goldenmarket@yahoo.co.jp>

* [sensing_launch]: Add arg for vehicle parameter file in lidar launch

Signed-off-by: wep21 <border_goldenmarket@yahoo.co.jp>

* [sensing_launch]: Cleanup

Signed-off-by: Autoware <autoware@tier4.jp>

* Add new line

Signed-off-by: Autoware <autoware@tier4.jp>

* [sensing_launch]: Add default config for xx1

Signed-off-by: Autoware <autoware@tier4.jp>

* [sensing_launch]: Fix indentation

Signed-off-by: Autoware <autoware@tier4.jp>

Co-authored-by: Yukihiro Saito <yukky.saito@gmail.com>
Co-authored-by: Taichi Higashide <taichi.higashide@tier4.jp>
Co-authored-by: Kenji Miyake <31987104+kenji-miyake@users.noreply.github.com>
Co-authored-by: hiroyuki obinata <58019445+obi-t4@users.noreply.github.com>
Co-authored-by: hosokawa <hosokawa@sng-3f-ros2-eval.l.sng.tier4.jp>
Co-authored-by: HOSOKAWA Ikuto <hosokawa.ikuto@gmail.com>
Co-authored-by: wep21 <border_goldenmarket@yahoo.co.jp>
Co-authored-by: Autoware <autoware@tier4.jp>

* Rename ROS-related .yaml to .param.yaml (autowarefoundation#65)

* Rename ROS-related .yaml to .param.yaml

Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>

* Add missing '--'

Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>

* Rename vehicle_info.yaml to vehicle_info.param.yaml

Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>

* Fix livox param name

Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>

* Sync with Ros2 v0.8.0 beta (autowarefoundation#71)

* update sensing launch to support aip_x1 (autowarefoundation#69)

Signed-off-by: taichiH <azumade.30@gmail.com>

* fix logging_simulator_bug (autowarefoundation#68)

Signed-off-by: taichiH <azumade.30@gmail.com>

* fix aip_x1 param (autowarefoundation#70)

Signed-off-by: taichiH <azumade.30@gmail.com>

Co-authored-by: Taichi Higashide <taichi.higashide@tier4.jp>

* Fix aip_xx1's pointcloud_preprocessor.launch.py (autowarefoundation#72)

Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>

* fix velodyne launch (autowarefoundation#73)

* fix velodyne launch

* fix bug

* add scan_phase arg

* fix bug (autowarefoundation#85)

* Use sensor data qos for pointcloud (autowarefoundation#82)

Signed-off-by: Autoware <autoware@tier4.jp>

Co-authored-by: Autoware <autoware@tier4.jp>

* Remove unused remappings (autowarefoundation#88)

Signed-off-by: wep21 <border_goldenmarket@yahoo.co.jp>

* Livox composable node (autowarefoundation#87)

* Fix default value of use_concat_filter and use_radius_search (autowarefoundation#90)

* Fix default value of use_concat_filter and use_radius_search

Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>

* Fix lint

Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>

* [aip_x1]: Fix imu topic name (autowarefoundation#94)

Signed-off-by: wep21 <border_goldenmarket@yahoo.co.jp>

* Fix various typos in launch files (autowarefoundation#97)

* Move individual params to a separate package (autowarefoundation#100)

Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>

* add use_sim-time option (autowarefoundation#99)

* Format launch files (autowarefoundation#178)

Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>

* Fix bug of pointcloud_preprocessor.py (autowarefoundation#179)

Signed-off-by: autoware <autoware@example.com>

Co-authored-by: autoware <autoware@example.com>

* Replace doc by description (autowarefoundation#182)

Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>

* Ros2 lsim test (autowarefoundation#186)

* Add group to launch file for var scope

Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp>

* Remove pointcloud relay for localization

Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp>

* Add use_sim_time

Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp>

* Remove pointcloud relay for localization

Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp>

Co-authored-by: Takagi, Isamu <isamu.takagi@tier4.jp>

* Add multithread and intra process option (autowarefoundation#187)

* Add multithread and intra process option

Signed-off-by: wep21 <border_goldenmarket@yahoo.co.jp>

* Fix velodyne node container executable

Signed-off-by: wep21 <border_goldenmarket@yahoo.co.jp>

* Add option into aip_xx2

Signed-off-by: wep21 <border_goldenmarket@yahoo.co.jp>

* Add option into aip_x2

Signed-off-by: wep21 <border_goldenmarket@yahoo.co.jp>

* Add option into aip_x1

Signed-off-by: wep21 <border_goldenmarket@yahoo.co.jp>

* Add option into aip_s1

Signed-off-by: wep21 <border_goldenmarket@yahoo.co.jp>

* Add option into aip_customized

Signed-off-by: wep21 <border_goldenmarket@yahoo.co.jp>

* Add option into lidar.launch.xml

Signed-off-by: wep21 <border_goldenmarket@yahoo.co.jp>

* Fix invalid attribute in gnss launch (autowarefoundation#191)

Signed-off-by: wep21 <border_goldenmarket@yahoo.co.jp>

* Fix parameter for scan phase (autowarefoundation#193)

Signed-off-by: wep21 <border_goldenmarket@yahoo.co.jp>

* add septentrio_gnss_driver launcher and switch(septentrio <-> ublox) (autowarefoundation#196)

* add septentrio_gnss_driver launcher and switch(septentrio <-> ublox)

* rm arg(gnss_receiver) escalation and modify septentrio_gnss_driver_node option

* change gnss_receiver default septentrio to ublox

* remap all septentrio_gnss_driver topic names

* replace septentrio gnss driver launch type 'node' to 'include'

* Use set_parameter for use_sim_time (autowarefoundation#198)

* Use set_parameter for use_sim_time

Signed-off-by: wep21 <border_goldenmarket@yahoo.co.jp>

* Add default parameter for scenario simulator

Signed-off-by: wep21 <border_goldenmarket@yahoo.co.jp>

* Format launch files (autowarefoundation#228)

* Format launch files

Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>

* Format launch.py

Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>

* Fix lint

Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>

* Fix aip_xx1 camera launch (autowarefoundation#242)

Signed-off-by: wep21 <border_goldenmarket@yahoo.co.jp>

* Fix gnss topic name (autowarefoundation#243)

Signed-off-by: wep21 <border_goldenmarket@yahoo.co.jp>

* Enable intra process and mt (autowarefoundation#204)

Signed-off-by: wep21 <border_goldenmarket@yahoo.co.jp>

* add imu_corrector (autowarefoundation#296)

* add description for sensing_launch (autowarefoundation#336)

* add description

* fix sentence

* add README.md and svg files (autowarefoundation#328)

* add md and svg

* fix typo

* fix typo

* fix word

* fix typo

* add lack of things

* Update README

* fix depending packages

* fix word

* Fix camera launch invalid type string (autowarefoundation#344)

Signed-off-by: kosuke55 <kosuke.tnp@gmail.com>

* add view width direction to velodyne_node_container.launch.py etc... (autowarefoundation#366)

* add arg of view_width and view_direction

* delete initial value

* add args and params

Co-authored-by: autoware-iv-sync-ci[bot] <87871706+autoware-iv-sync-ci[bot]@users.noreply.github.com>

* Fix pre-commit (autowarefoundation#407)

* Fix pre-commit errors

Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>

* Fix package.xml

Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>

* Fix pre-commit target (autowarefoundation#436)

Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>

* Remove aip xx2 model from sensing launch (autowarefoundation#446)

Signed-off-by: wep21 <border_goldenmarket@yahoo.co.jp>

* Add respawn for ublox (autowarefoundation#449)

Signed-off-by: wep21 <border_goldenmarket@yahoo.co.jp>

* delete aip and modify package settings (autowarefoundation#434)

* Change formatter to black (autowarefoundation#488)

* Update pre-commit settings

* Apply Black

* Replace ament_lint_common with autoware_lint_common

* Update build_depends.repos

* Fix build_depends

* feature/use common pointcloud container (autowarefoundation#147)

* add container argument

* load composable node to pointcloud_container

* fix autoware_launch

* enable multi-thread

* improve readability

* Update package.xml (autowarefoundation#150)

* feat: add default param

* feat: add aip_launcher depends

* fix: add vehicle_info_util as exec_depend

* fix: add velodyne_vls to build_depend.repos

* fix: remove api_launcher at build_depends

Co-authored-by: mitsudome-r <ryohsuke.mitsudome@tier4.jp>
Co-authored-by: Akihito Ohsato <aohsato@gmail.com>
Co-authored-by: Daisuke Nishimatsu <42202095+wep21@users.noreply.github.com>
Co-authored-by: Yukihiro Saito <yukky.saito@gmail.com>
Co-authored-by: Frederik Beaujean <72439809+fred-apex-ai@users.noreply.github.com>
Co-authored-by: Esteve Fernandez <esteve@apache.org>
Co-authored-by: Takamasa Horibe <horibe.takamasa@gmail.com>
Co-authored-by: Taichi Higashide <taichi.higashide@tier4.jp>
Co-authored-by: Kenji Miyake <31987104+kenji-miyake@users.noreply.github.com>
Co-authored-by: hiroyuki obinata <58019445+obi-t4@users.noreply.github.com>
Co-authored-by: hosokawa <hosokawa@sng-3f-ros2-eval.l.sng.tier4.jp>
Co-authored-by: HOSOKAWA Ikuto <hosokawa.ikuto@gmail.com>
Co-authored-by: wep21 <border_goldenmarket@yahoo.co.jp>
Co-authored-by: Autoware <autoware@tier4.jp>
Co-authored-by: Kazuki Miyahara <kmiya@outlook.com>
Co-authored-by: tkimura4 <tomoya.kimura@tier4.jp>
Co-authored-by: autoware <autoware@example.com>
Co-authored-by: Takagi, Isamu <isamu.takagi@tier4.jp>
Co-authored-by: hiro-ya-iv <30652835+hiro-ya-iv@users.noreply.github.com>
Co-authored-by: YamatoAndo <yamato.ando@gmail.com>
Co-authored-by: Hiroki OTA <hiroki.ota@tier4.jp>
Co-authored-by: Kosuke Takeuchi <kosuke.tnp@gmail.com>
Co-authored-by: autoware-iv-sync-ci[bot] <87871706+autoware-iv-sync-ci[bot]@users.noreply.github.com>
Co-authored-by: Kenji Miyake <kenji.miyake@tier4.jp>
Co-authored-by: Satoshi OTA <44889564+satoshi-ota@users.noreply.github.com>
Co-authored-by: taikitanaka3 <65527974+taikitanaka3@users.noreply.github.com>
badai-nguyen pushed a commit to badai-nguyen/autoware.universe that referenced this pull request Feb 4, 2022
* feat: add Werror

Signed-off-by: h-ohta <hiroki.ota@tier4.jp>

* fix: suppress warnings

Signed-off-by: h-ohta <hiroki.ota@tier4.jp>

* fix: still use RCLCPP_ERROR

Signed-off-by: h-ohta <hiroki.ota@tier4.jp>

* fix: add const

Signed-off-by: h-ohta <hiroki.ota@tier4.jp>
mitsudome-r added a commit to mitsudome-r/autoware.universe that referenced this pull request Mar 1, 2022
* rename gnss package (autowarefoundation#714)

Signed-off-by: Yamato Ando <yamato.ando@gmail.com>

* Avoid setting CMAKE_BUILD_TYPE=Release in each CMakeLists.txt (autowarefoundation#720)

* remove set CMAKE_BUILD_TYPE Release in each CMakeLists.txt

* remove set CMAKE_BUILD_TYPE Release in ndt_pcl_modified

* set compile options for debug in ndt_omp

* Fix indent

* add warning if -DCMAKE_BUILD_TYPE=Release is not set in ndt_omp

Co-authored-by: Kenji Miyake <31987104+kenji-miyake@users.noreply.github.com>

* remove ROS1 packages temporarily

Signed-off-by: mitsudome-r <ryohsuke.mitsudome@tier4.jp>

* Revert "remove ROS1 packages temporarily"

This reverts commit bc523d679e6737ec37be4fdcbdedca141411bd9d.

Signed-off-by: mitsudome-r <ryohsuke.mitsudome@tier4.jp>

* add COLCON_IGNORE to ros1 packages

Signed-off-by: mitsudome-r <ryohsuke.mitsudome@tier4.jp>

* ROS2 Porting: geo_pos_conv (#8)

* Convert to ROS2 package
 - Update changelog -> 2.0.0
 - Update package xml to use the ROS2 xml schema
 - Update CMakelist with ament cmake commands
 - Add ROS2 compile options

* Convert CMakelist for foxy

* Clean up
 - Remove comments

* Remove colcon ignore

* Rename launch files to launch.xml (autowarefoundation#28)

* ROS2 Porting: gnss_poser (autowarefoundation#18)

* Fix CMakelist
 - Add ublox_msgs package dependency
 - Rename header files to use the .hpp extention
 - Remove colcon ignore
 - Fix Cmake ref to ublox in dependency

* Fix compilation issues with convert.hpp
 - Add sensor_msgs::NavSatFix header which was missing before (?)
 - Remove logging for now
 - Contains warnings - geographic lib error polymorphous error
 - Fix geographic lib -Wcatch-value warnings
 - Add ifndef guard in gnss_stat.hpp

* First pass - successful compilation
 - Fix CMakelist geographic library
 - Remove references to main ROS functions
 - Convert msg references
 - Add ifndef guards
 - Convert tf2 methods
 - Add functionality back
 - Fix type errors

* Add publishers and subscribers
 - Add parameters

* Convert launch files to ROS2 format

* Add logging

* Convert to component

* Fix define guards to follow ROS2/Google style

* Add -Werror compile flag

* Clean up

* Fix CMakelist to allow for the node to be found via ros2 launch
 - Revert filenames so it is easier to review

* Address PR Comments:
 - Fix CMakelist and package.xml
 - Remove redundant depend/exec_depend calls
 - Remove redundant find_package calls
 - Explicitly add headers to the library

* Address PR comments:
 - Revert removal of GNSSPoser namespace
 - Use std::make_shared in place of new
 - Reorder includes to conform with standard

* Address PR Comments:
 - Rename variable to conform with the google style guide
 - Use the node clock in logging method calls

* Address PR Comment:
 - Convert transform broadcaster to shared pointer

* Address PR comment:
 - Remove -Werror compile flag post discussion

* fix duration unit for RCLCPP_*_THROTTLE (autowarefoundation#75)

Signed-off-by: Takamasa Horibe <horibe.takamasa@gmail.com>

* [gnss_poser] switch broadcaster to full member... (autowarefoundation#136)

instead of `shared_ptr` to avoid undefined behavior when executing the node because it used `shared_from_this()` in the constructor

* Adjust copyright notice on 532 out of 699 source files (autowarefoundation#143)

* Use quotes for includes where appropriate (autowarefoundation#144)

* Use quotes for includes where appropriate

* Fix lint tests

* Make tests pass hopefully

* Run uncrustify on the entire Pilot.Auto codebase (autowarefoundation#151)

* Run uncrustify on the entire Pilot.Auto codebase

* Exclude open PRs

* ROS2 Linting: geo_pos_conv (autowarefoundation#165)

* Add linters and fix linter issues
 - convert Cmake to use ament_cmake_auto

* Address PR comments:
 - Remove unneeded cast
 - Throw error instead of setting default values to zero

* ROS2 Linting: gnss_poser (autowarefoundation#166)

* Add linting and fix litner errors

* Address PR comment:
 - Use author name instead of user
 - Remove ROS2 maintainer (remnants of older porting)

* apply env_var to  use_sim_time (autowarefoundation#222)

* [gnss_poser] fix namespace for component (autowarefoundation#295)

Signed-off-by: Takamasa Horibe <horibe.takamasa@gmail.com>

* [gnss_poser] fix link to Geographiclib (autowarefoundation#296)

* [gnss_poser] fix link to Geographiclib

* Fix mismatching spaces inside () after command

Signed-off-by: wep21 <border_goldenmarket@yahoo.co.jp>

Co-authored-by: Autoware <autoware@tier4.jp>
Co-authored-by: wep21 <border_goldenmarket@yahoo.co.jp>

* Ros2 v0.8.0 gnss poser (autowarefoundation#287)

* [gnss poser]: Remove std_msgs (autowarefoundation#341)

Signed-off-by: wep21 <border_goldenmarket@yahoo.co.jp>

* add use_sim-time option (autowarefoundation#454)

* Format launch files (autowarefoundation#1219)

Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>

* Fix for rolling (autowarefoundation#1226)

* Replace doc by description

Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>

* Replace ns by push-ros-namespace

Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>

* Remove use_sim_time for set_parameter (autowarefoundation#1260)

Signed-off-by: wep21 <border_goldenmarket@yahoo.co.jp>

* Add pre-commit (autowarefoundation#1560)

* add pre-commit

* add pre-commit-config

* add additional settings for private repository

* use default pre-commit-config

* update pre-commit setting

* Ignore whitespace for line breaks in markdown

* Update .github/workflows/pre-commit.yml

Co-authored-by: Kazuki Miyahara <kmiya@outlook.com>

* exclude svg

* remove pretty-format-json

* add double-quote-string-fixer

* consider COLCON_IGNORE file when seaching modified package

* format file

* pre-commit fixes

* Update pre-commit.yml

* Update .pre-commit-config.yaml

Co-authored-by: Kazuki Miyahara <kmiya@outlook.com>
Co-authored-by: pre-commit <pre-commit@example.com>
Co-authored-by: Kenji Miyake <31987104+kenji-miyake@users.noreply.github.com>

* Add markdownlint and prettier (autowarefoundation#1661)

* Add markdownlint and prettier

Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>

* Ignore .param.yaml

Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>

* Apply format

Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>

* suppress warnings for sensing packages (autowarefoundation#1729)

* add Werror for tier4_pcl_extensions

* use std::type  instead of pcl::type

* use std::isfinite instead of pcl_isfinite

* fix getFieldIndex

* add Werror

* fix uninitialized

* add Werror

* fix string to char*

* Fix -Wunused-parameter (autowarefoundation#1836)

* Fix -Wunused-parameter

Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>

* Fix mistake

Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>

* fix spell

* Fix lint issues

Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>

* Ignore flake8 warnings

Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>

Co-authored-by: Hiroki OTA <hiroki.ota@tier4.jp>

* Fix clang warnings (autowarefoundation#1859)

* Fix -Wreturn-std-move

Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>

* Fix -Wunused-private-field

Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>

* Ignore -Wnonportable-include-path for mussp

Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>

* Fix -Wunused-const-variable

Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>

* Fix "can not be used when making a shared object"

Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>

* add sort-package-xml hook in pre-commit (autowarefoundation#1881)

* add sort xml hook in pre-commit

* change retval to exit_status

* rename

* add prettier plugin-xml

* use early return

* add license note

* add tier4 license

* restore prettier

* change license order

* move local hooks to public repo

* move prettier-xml to pre-commit-hooks-ros

* update version for bug-fix

* apply pre-commit

* fix gnss_poser transform (autowarefoundation#1493) (autowarefoundation#1623)

* fix gnss_poser transform (autowarefoundation#1493)

* fix gnss_poser transform

* change transformation method from doTransform to tf2::Transform multiplication

* rename tf variables

* correct variable spelling

Signed-off-by: wep21 <border_goldenmarket@yahoo.co.jp>

* Fix lint

Signed-off-by: wep21 <border_goldenmarket@yahoo.co.jp>

Co-authored-by: hiro-ya-iv <30652835+hiro-ya-iv@users.noreply.github.com>

* Change formatter to clang-format and black (autowarefoundation#2332)

* Revert "Temporarily comment out pre-commit hooks"

This reverts commit 748e9cdb145ce12f8b520bcbd97f5ff899fc28a3.

* Replace ament_lint_common with autoware_lint_common

Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>

* Remove ament_cmake_uncrustify and ament_clang_format

Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>

* Apply Black

Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>

* Apply clang-format

Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>

* Fix build errors

Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>

* Fix for cpplint

* Fix include double quotes to angle brackets

Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>

* Apply clang-format

Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>

* Fix build errors

Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>

* Add COLCON_IGNORE (autowarefoundation#500)

Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>

* remove COLCON_IGNORE (autowarefoundation#515)

* doc gnss poser (autowarefoundation#580)

* add minimal doc

* fix document title

* doc geo conv pos (autowarefoundation#573)

* add minimal doc

* fix document title

* Remove template comments from node documents (autowarefoundation#608)

* rename document file

* remove template comment

Co-authored-by: YamatoAndo <yamato.ando@gmail.com>
Co-authored-by: Daichi Murakami <harihitode@gmail.com>
Co-authored-by: Kenji Miyake <31987104+kenji-miyake@users.noreply.github.com>
Co-authored-by: mitsudome-r <ryohsuke.mitsudome@tier4.jp>
Co-authored-by: Jilada Eccleston <jilada.eccleston@gmail.com>
Co-authored-by: Nikolai Morin <nnmmgit@gmail.com>
Co-authored-by: Takamasa Horibe <horibe.takamasa@gmail.com>
Co-authored-by: Frederik Beaujean <72439809+fred-apex-ai@users.noreply.github.com>
Co-authored-by: Kosuke Murakami <kosuke.murakami@tier4.jp>
Co-authored-by: Ryohsuke Mitsudome <43976834+mitsudome-r@users.noreply.github.com>
Co-authored-by: Autoware <autoware@tier4.jp>
Co-authored-by: wep21 <border_goldenmarket@yahoo.co.jp>
Co-authored-by: Daisuke Nishimatsu <42202095+wep21@users.noreply.github.com>
Co-authored-by: tkimura4 <tomoya.kimura@tier4.jp>
Co-authored-by: Keisuke Shima <19993104+KeisukeShima@users.noreply.github.com>
Co-authored-by: Kazuki Miyahara <kmiya@outlook.com>
Co-authored-by: pre-commit <pre-commit@example.com>
Co-authored-by: Hiroki OTA <hiroki.ota@tier4.jp>
Co-authored-by: hiro-ya-iv <30652835+hiro-ya-iv@users.noreply.github.com>
Co-authored-by: Satoshi OTA <44889564+satoshi-ota@users.noreply.github.com>
Co-authored-by: taikitanaka3 <65527974+taikitanaka3@users.noreply.github.com>
satoshi-ota pushed a commit to satoshi-ota/autoware.universe that referenced this pull request May 20, 2022
* feat: add Werror

Signed-off-by: h-ohta <hiroki.ota@tier4.jp>

* fix: suppress warnings

Signed-off-by: h-ohta <hiroki.ota@tier4.jp>

* fix: still use RCLCPP_ERROR

Signed-off-by: h-ohta <hiroki.ota@tier4.jp>

* fix: add const

Signed-off-by: h-ohta <hiroki.ota@tier4.jp>
satoshi-ota pushed a commit to satoshi-ota/autoware.universe that referenced this pull request May 20, 2022
* feat: add Werror

Signed-off-by: h-ohta <hiroki.ota@tier4.jp>

* fix: suppress warnings

Signed-off-by: h-ohta <hiroki.ota@tier4.jp>

* fix: still use RCLCPP_ERROR

Signed-off-by: h-ohta <hiroki.ota@tier4.jp>

* fix: add const

Signed-off-by: h-ohta <hiroki.ota@tier4.jp>
satoshi-ota pushed a commit to satoshi-ota/autoware.universe that referenced this pull request May 30, 2022
* feat: add Werror

Signed-off-by: h-ohta <hiroki.ota@tier4.jp>

* fix: suppress warnings

Signed-off-by: h-ohta <hiroki.ota@tier4.jp>

* fix: still use RCLCPP_ERROR

Signed-off-by: h-ohta <hiroki.ota@tier4.jp>

* fix: add const

Signed-off-by: h-ohta <hiroki.ota@tier4.jp>
satoshi-ota pushed a commit to satoshi-ota/autoware.universe that referenced this pull request May 31, 2022
* feat: add Werror

Signed-off-by: h-ohta <hiroki.ota@tier4.jp>

* fix: suppress warnings

Signed-off-by: h-ohta <hiroki.ota@tier4.jp>

* fix: still use RCLCPP_ERROR

Signed-off-by: h-ohta <hiroki.ota@tier4.jp>

* fix: add const

Signed-off-by: h-ohta <hiroki.ota@tier4.jp>
TomohitoAndo pushed a commit to TomohitoAndo/autoware.universe that referenced this pull request Oct 5, 2022
TomohitoAndo pushed a commit to TomohitoAndo/autoware.universe that referenced this pull request Oct 5, 2022
* ci(pre-commit): autoupdate

updates:
- [github.com/tier4/pre-commit-hooks-ros: v0.6.0 → v0.7.0](tier4/pre-commit-hooks-ros@v0.6.0...v0.7.0)

* Update .pre-commit-config.yaml

Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Co-authored-by: Kenji Miyake <31987104+kenji-miyake@users.noreply.github.com>
TomohitoAndo pushed a commit to TomohitoAndo/autoware.universe that referenced this pull request Oct 5, 2022
* ci(pre-commit): autoupdate

updates:
- [github.com/tier4/pre-commit-hooks-ros: v0.6.0 → v0.7.0](tier4/pre-commit-hooks-ros@v0.6.0...v0.7.0)

* Update .pre-commit-config.yaml

Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Co-authored-by: Kenji Miyake <31987104+kenji-miyake@users.noreply.github.com>
keiota pushed a commit to keiota/autoware.universe that referenced this pull request Aug 17, 2023
…vior_velocity (autowarefoundation#296)

removed external input from behavior_velocity

Signed-off-by: Mamoru Sobue <mamoru.sobue@tier4.jp>
kyoichi-sugahara pushed a commit that referenced this pull request Sep 16, 2023
Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>
YamatoAndo pushed a commit to YamatoAndo/autoware.universe that referenced this pull request Aug 8, 2024
* fix(tier4_autoware_utils): build_error

* fix test code

* fix test code

* fix test code
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants