Ali/simple planning simulator with disturbance generator #573

boyali · 2022-03-23T06:10:31Z

Note: Confirm our contribution guidelines before submitting a pull request.

Click the Preview tab and select a PR template:

Small change
We implemented disturbance generator classes for the simple_planning_simulator.

* rename gnss package (autowarefoundation#714) Signed-off-by: Yamato Ando <yamato.ando@gmail.com> * Avoid setting CMAKE_BUILD_TYPE=Release in each CMakeLists.txt (autowarefoundation#720) * remove set CMAKE_BUILD_TYPE Release in each CMakeLists.txt * remove set CMAKE_BUILD_TYPE Release in ndt_pcl_modified * set compile options for debug in ndt_omp * Fix indent * add warning if -DCMAKE_BUILD_TYPE=Release is not set in ndt_omp Co-authored-by: Kenji Miyake <31987104+kenji-miyake@users.noreply.github.com> * remove ROS1 packages temporarily Signed-off-by: mitsudome-r <ryohsuke.mitsudome@tier4.jp> * Revert "remove ROS1 packages temporarily" This reverts commit bc523d679e6737ec37be4fdcbdedca141411bd9d. Signed-off-by: mitsudome-r <ryohsuke.mitsudome@tier4.jp> * add COLCON_IGNORE to ros1 packages Signed-off-by: mitsudome-r <ryohsuke.mitsudome@tier4.jp> * ROS2 Porting: geo_pos_conv (autowarefoundation#8) * Convert to ROS2 package - Update changelog -> 2.0.0 - Update package xml to use the ROS2 xml schema - Update CMakelist with ament cmake commands - Add ROS2 compile options * Convert CMakelist for foxy * Clean up - Remove comments * Remove colcon ignore * Rename launch files to launch.xml (autowarefoundation#28) * ROS2 Porting: gnss_poser (autowarefoundation#18) * Fix CMakelist - Add ublox_msgs package dependency - Rename header files to use the .hpp extention - Remove colcon ignore - Fix Cmake ref to ublox in dependency * Fix compilation issues with convert.hpp - Add sensor_msgs::NavSatFix header which was missing before (?) - Remove logging for now - Contains warnings - geographic lib error polymorphous error - Fix geographic lib -Wcatch-value warnings - Add ifndef guard in gnss_stat.hpp * First pass - successful compilation - Fix CMakelist geographic library - Remove references to main ROS functions - Convert msg references - Add ifndef guards - Convert tf2 methods - Add functionality back - Fix type errors * Add publishers and subscribers - Add parameters * Convert launch files to ROS2 format * Add logging * Convert to component * Fix define guards to follow ROS2/Google style * Add -Werror compile flag * Clean up * Fix CMakelist to allow for the node to be found via ros2 launch - Revert filenames so it is easier to review * Address PR Comments: - Fix CMakelist and package.xml - Remove redundant depend/exec_depend calls - Remove redundant find_package calls - Explicitly add headers to the library * Address PR comments: - Revert removal of GNSSPoser namespace - Use std::make_shared in place of new - Reorder includes to conform with standard * Address PR Comments: - Rename variable to conform with the google style guide - Use the node clock in logging method calls * Address PR Comment: - Convert transform broadcaster to shared pointer * Address PR comment: - Remove -Werror compile flag post discussion * fix duration unit for RCLCPP_*_THROTTLE (autowarefoundation#75) Signed-off-by: Takamasa Horibe <horibe.takamasa@gmail.com> * [gnss_poser] switch broadcaster to full member... (autowarefoundation#136) instead of `shared_ptr` to avoid undefined behavior when executing the node because it used `shared_from_this()` in the constructor * Adjust copyright notice on 532 out of 699 source files (autowarefoundation#143) * Use quotes for includes where appropriate (autowarefoundation#144) * Use quotes for includes where appropriate * Fix lint tests * Make tests pass hopefully * Run uncrustify on the entire Pilot.Auto codebase (autowarefoundation#151) * Run uncrustify on the entire Pilot.Auto codebase * Exclude open PRs * ROS2 Linting: geo_pos_conv (autowarefoundation#165) * Add linters and fix linter issues - convert Cmake to use ament_cmake_auto * Address PR comments: - Remove unneeded cast - Throw error instead of setting default values to zero * ROS2 Linting: gnss_poser (autowarefoundation#166) * Add linting and fix litner errors * Address PR comment: - Use author name instead of user - Remove ROS2 maintainer (remnants of older porting) * apply env_var to use_sim_time (autowarefoundation#222) * [gnss_poser] fix namespace for component (autowarefoundation#295) Signed-off-by: Takamasa Horibe <horibe.takamasa@gmail.com> * [gnss_poser] fix link to Geographiclib (autowarefoundation#296) * [gnss_poser] fix link to Geographiclib * Fix mismatching spaces inside () after command Signed-off-by: wep21 <border_goldenmarket@yahoo.co.jp> Co-authored-by: Autoware <autoware@tier4.jp> Co-authored-by: wep21 <border_goldenmarket@yahoo.co.jp> * Ros2 v0.8.0 gnss poser (autowarefoundation#287) * [gnss poser]: Remove std_msgs (autowarefoundation#341) Signed-off-by: wep21 <border_goldenmarket@yahoo.co.jp> * add use_sim-time option (autowarefoundation#454) * Format launch files (autowarefoundation#1219) Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp> * Fix for rolling (autowarefoundation#1226) * Replace doc by description Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp> * Replace ns by push-ros-namespace Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp> * Remove use_sim_time for set_parameter (autowarefoundation#1260) Signed-off-by: wep21 <border_goldenmarket@yahoo.co.jp> * Add pre-commit (autowarefoundation#1560) * add pre-commit * add pre-commit-config * add additional settings for private repository * use default pre-commit-config * update pre-commit setting * Ignore whitespace for line breaks in markdown * Update .github/workflows/pre-commit.yml Co-authored-by: Kazuki Miyahara <kmiya@outlook.com> * exclude svg * remove pretty-format-json * add double-quote-string-fixer * consider COLCON_IGNORE file when seaching modified package * format file * pre-commit fixes * Update pre-commit.yml * Update .pre-commit-config.yaml Co-authored-by: Kazuki Miyahara <kmiya@outlook.com> Co-authored-by: pre-commit <pre-commit@example.com> Co-authored-by: Kenji Miyake <31987104+kenji-miyake@users.noreply.github.com> * Add markdownlint and prettier (autowarefoundation#1661) * Add markdownlint and prettier Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp> * Ignore .param.yaml Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp> * Apply format Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp> * suppress warnings for sensing packages (autowarefoundation#1729) * add Werror for tier4_pcl_extensions * use std::type instead of pcl::type * use std::isfinite instead of pcl_isfinite * fix getFieldIndex * add Werror * fix uninitialized * add Werror * fix string to char* * Fix -Wunused-parameter (autowarefoundation#1836) * Fix -Wunused-parameter Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp> * Fix mistake Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp> * fix spell * Fix lint issues Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp> * Ignore flake8 warnings Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp> Co-authored-by: Hiroki OTA <hiroki.ota@tier4.jp> * Fix clang warnings (autowarefoundation#1859) * Fix -Wreturn-std-move Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp> * Fix -Wunused-private-field Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp> * Ignore -Wnonportable-include-path for mussp Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp> * Fix -Wunused-const-variable Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp> * Fix "can not be used when making a shared object" Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp> * add sort-package-xml hook in pre-commit (autowarefoundation#1881) * add sort xml hook in pre-commit * change retval to exit_status * rename * add prettier plugin-xml * use early return * add license note * add tier4 license * restore prettier * change license order * move local hooks to public repo * move prettier-xml to pre-commit-hooks-ros * update version for bug-fix * apply pre-commit * fix gnss_poser transform (autowarefoundation#1493) (autowarefoundation#1623) * fix gnss_poser transform (autowarefoundation#1493) * fix gnss_poser transform * change transformation method from doTransform to tf2::Transform multiplication * rename tf variables * correct variable spelling Signed-off-by: wep21 <border_goldenmarket@yahoo.co.jp> * Fix lint Signed-off-by: wep21 <border_goldenmarket@yahoo.co.jp> Co-authored-by: hiro-ya-iv <30652835+hiro-ya-iv@users.noreply.github.com> * Change formatter to clang-format and black (autowarefoundation#2332) * Revert "Temporarily comment out pre-commit hooks" This reverts commit 748e9cdb145ce12f8b520bcbd97f5ff899fc28a3. * Replace ament_lint_common with autoware_lint_common Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp> * Remove ament_cmake_uncrustify and ament_clang_format Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp> * Apply Black Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp> * Apply clang-format Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp> * Fix build errors Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp> * Fix for cpplint * Fix include double quotes to angle brackets Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp> * Apply clang-format Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp> * Fix build errors Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp> * Add COLCON_IGNORE (autowarefoundation#500) Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp> * remove COLCON_IGNORE (autowarefoundation#515) * doc gnss poser (autowarefoundation#580) * add minimal doc * fix document title * doc geo conv pos (autowarefoundation#573) * add minimal doc * fix document title * Remove template comments from node documents (autowarefoundation#608) * rename document file * remove template comment Co-authored-by: YamatoAndo <yamato.ando@gmail.com> Co-authored-by: Daichi Murakami <harihitode@gmail.com> Co-authored-by: Kenji Miyake <31987104+kenji-miyake@users.noreply.github.com> Co-authored-by: mitsudome-r <ryohsuke.mitsudome@tier4.jp> Co-authored-by: Jilada Eccleston <jilada.eccleston@gmail.com> Co-authored-by: Nikolai Morin <nnmmgit@gmail.com> Co-authored-by: Takamasa Horibe <horibe.takamasa@gmail.com> Co-authored-by: Frederik Beaujean <72439809+fred-apex-ai@users.noreply.github.com> Co-authored-by: Kosuke Murakami <kosuke.murakami@tier4.jp> Co-authored-by: Ryohsuke Mitsudome <43976834+mitsudome-r@users.noreply.github.com> Co-authored-by: Autoware <autoware@tier4.jp> Co-authored-by: wep21 <border_goldenmarket@yahoo.co.jp> Co-authored-by: Daisuke Nishimatsu <42202095+wep21@users.noreply.github.com> Co-authored-by: tkimura4 <tomoya.kimura@tier4.jp> Co-authored-by: Keisuke Shima <19993104+KeisukeShima@users.noreply.github.com> Co-authored-by: Kazuki Miyahara <kmiya@outlook.com> Co-authored-by: pre-commit <pre-commit@example.com> Co-authored-by: Hiroki OTA <hiroki.ota@tier4.jp> Co-authored-by: hiro-ya-iv <30652835+hiro-ya-iv@users.noreply.github.com> Co-authored-by: Satoshi OTA <44889564+satoshi-ota@users.noreply.github.com> Co-authored-by: taikitanaka3 <65527974+taikitanaka3@users.noreply.github.com>

… hpp.

…hin the vehicle models.

… time update.

mitsudome-r · 2022-06-28T15:51:20Z

@boyali @TakaHoribe Could you share the current status of this PR?
This seems to be inactive for three weeks.

boyali · 2022-06-29T09:28:16Z

@mitsudome-r -san, @TakaHoribe -san will decide.

…dation#573) * refactor: intersection module (autowarefoundation#3899) Signed-off-by: Mamoru Sobue <mamoru.sobue@tier4.jp> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> Co-authored-by: Shumpei Wakabayashi <42209144+shmpwk@users.noreply.github.com> * style(pre-commit): autofix --------- Signed-off-by: Mamoru Sobue <mamoru.sobue@tier4.jp> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> Co-authored-by: Shumpei Wakabayashi <42209144+shmpwk@users.noreply.github.com>

Signed-off-by: GitHub <noreply@github.com> Signed-off-by: GitHub <noreply@github.com> Co-authored-by: kenji-miyake <kenji-miyake@users.noreply.github.com>

boyali requested a review from TakaHoribe March 23, 2022 06:10

boyali added 7 commits May 13, 2022 15:27

Started to implement standalone control_toolbox.

77c92de

Reproduced the linking problem.

8a784c5

Solved the linking problem.

0735ca9

Solved fvisibility setting and will use in other packages.

a110033

Syncronized with the other repos that uses the ACT.

253ae2a

Syncronized with the other repos that uses the ACT.

2e385c8

Version txt is added.

27cd1ec

boyali force-pushed the ali/simple_planning_simulator_with_disturbance_generator branch from 328d14c to a6eb350 Compare May 26, 2022 14:06

boyali added 9 commits May 30, 2022 12:01

Tustin Bilinear discretization is added.

e5f404d

ACT is separated into the headers. Started balancing algorithm.

8df1702

Implemented matrix balancing.

4fa6606

Balancing finished, comparing with others.

3b1197d

Balancing finished: lapack diag subtraction is enabled.

0834ee9

Balancing finalized:integrating into the ss methods.

dfd9735

Automatic discretization is added to tf2ss.

03f80b8

Automatic balancing is added to tf2ss.

428a674

Balancing permutation method signature is added.

1051e5c

boyali force-pushed the ali/simple_planning_simulator_with_disturbance_generator branch from a6eb350 to 351ec1d Compare May 31, 2022 02:02

boyali added 10 commits May 31, 2022 15:50

Introduced the signal builder methods.

410de74

Triangle wave implementation is changed.

031da29

Added tffactor_zero initializaiton.

2ae4255

added F inversion.

ae7fb8e

added TF from tf_factor construciton.

c409aca

Implementing TF*TF multiplication.

6f2fb8c

Implementing TF*TF LAZY evaluation implemented.

32c4e51

COmpleted TF TF multiplication.

4578522

std vector is overloaded. A TF multiplication bug is removed.

0939f02

std vector is overloaded

135e18e

boyali added 22 commits June 6, 2022 15:40

Geared Vehicle Model is tested with the disturbance generator.

6a38edb

Slope is added to the plotjuggler and core.

b93b6bc

Started to implement TIME-VARYING DEADZONE disturbance.

be677af

progressed in Deadzon. Improved the code navigation in dist generator…

9c37450

… hpp.

progressed in Deadzone. Implemented getDeadzone

1fa2482

Some clang-tidy and MISRA corrections.

ab0a5dc

Parameters added for the deadzone.

210c198

Deadzone is put in the disturbance collection. Ready to integrate wit…

a0f7557

…hin the vehicle models.

Put use_steering_input_delay option in the parameters.

28a535a

Put use_acceleration_input_delay option in the parameters.

a8adc0d

Put use_road_slope_disturbance option in the parameters.

9b397be

Put use_deadzone_disturbance option in the parameters.

582d240

Disturbance message structure is implemented.

c7ab167

Deadzone is completed, will check deadzone function implementation.

bc1052b

Deadzone description is added to the MD file.

2e67ef3

Deadzone function is amended.

8e3bfcb

Autoware_Control_Toolbox is separately implemented.

a87c6ab

Autoware_Control_Toolbox is separately implemented.

ee40a29

utils in ACT changed to act_utils

c03756c

Rebased on to the ACT, delay model continuous time update -> discrete…

3637295

… time update.

Rebased on to the improved ACT.

7559481

Virtual destructors added to the disturbance interfaces.

e6a8638

boyali force-pushed the ali/simple_planning_simulator_with_disturbance_generator branch from b8533e7 to e6a8638 Compare June 6, 2022 06:51

boyali closed this Jul 19, 2022

boyali deleted the ali/simple_planning_simulator_with_disturbance_generator branch July 19, 2022 02:35

kyoichi-sugahara pushed a commit that referenced this pull request Sep 16, 2023

chore: sync files (#573)

afd4efc

Signed-off-by: GitHub <noreply@github.com> Signed-off-by: GitHub <noreply@github.com> Co-authored-by: kenji-miyake <kenji-miyake@users.noreply.github.com>

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Ali/simple planning simulator with disturbance generator #573

Ali/simple planning simulator with disturbance generator #573

boyali commented Mar 23, 2022

mitsudome-r commented Jun 28, 2022

boyali commented Jun 29, 2022

Ali/simple planning simulator with disturbance generator #573

Ali/simple planning simulator with disturbance generator #573

Conversation

boyali commented Mar 23, 2022

mitsudome-r commented Jun 28, 2022

boyali commented Jun 29, 2022