-
Notifications
You must be signed in to change notification settings - Fork 667
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(motion_velocity_smoother): delete unnecessary linear interpolation #1729
feat(motion_velocity_smoother): delete unnecessary linear interpolation #1729
Conversation
Signed-off-by: yutaka <purewater0901@gmail.com>
Codecov Report
@@ Coverage Diff @@
## main #1729 +/- ##
==========================================
- Coverage 10.24% 10.17% -0.08%
==========================================
Files 1204 1204
Lines 86772 88003 +1231
Branches 20054 20824 +770
==========================================
+ Hits 8894 8957 +63
- Misses 68616 69672 +1056
- Partials 9262 9374 +112
*This pull request uses carry forward flags. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
@purewater0901 |
@taikitanaka3 This PR just deletes the unnecessary files, and I did not add new functions. So I think we don't need to add unit tests for this PR. |
@purewater0901 |
@taikitanaka3 Yes |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
…on (tier4#1729) Signed-off-by: yutaka <purewater0901@gmail.com> Signed-off-by: yutaka <purewater0901@gmail.com>
…on (tier4#1729) Signed-off-by: yutaka <purewater0901@gmail.com> Signed-off-by: yutaka <purewater0901@gmail.com>
…on (tier4#1729) Signed-off-by: yutaka <purewater0901@gmail.com> Signed-off-by: yutaka <purewater0901@gmail.com>
…on (autowarefoundation#1729) Signed-off-by: yutaka <purewater0901@gmail.com> Signed-off-by: yutaka <purewater0901@gmail.com>
…on (tier4#1729) Signed-off-by: yutaka <purewater0901@gmail.com> Signed-off-by: yutaka <purewater0901@gmail.com>
Signed-off-by: yutaka purewater0901@gmail.com
Description
Delete linear interpolation file from motion velocity smoother and use interpolation function from interpolation directory. It works well in the Planning Simulator.
Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.
In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.
Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.
After all checkboxes are checked, anyone who has write access can merge the PR.