Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(behavior_velocity): occlusion spot partition #608

Conversation

taikitanaka3
Copy link
Contributor

@taikitanaka3 taikitanaka3 commented Mar 30, 2022

Description

  • fix unused member variables

image

  • make sure close_partition_ is not used

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

@taikitanaka3 taikitanaka3 requested a review from 0x126 March 30, 2022 09:47
@taikitanaka3 taikitanaka3 force-pushed the fix-behavior-velocity-occlusion-spot-partition branch from 5e46915 to 9bb3468 Compare March 30, 2022 10:03
@taikitanaka3 taikitanaka3 changed the title fix(behavior_velocity): fix occlusion spot partition fix(behavior_velocity): occlusion spot partition Mar 30, 2022
@taikitanaka3 taikitanaka3 changed the title fix(behavior_velocity): occlusion spot partition fix(behavior_velocity): occlusion spot partition Mar 30, 2022
@codecov
Copy link

codecov bot commented Mar 30, 2022

Codecov Report

Merging #608 (9bb3468) into main (ca59048) will decrease coverage by 4.94%.
The diff coverage is 0.00%.

@@            Coverage Diff            @@
##             main    #608      +/-   ##
=========================================
- Coverage   10.76%   5.81%   -4.95%     
=========================================
  Files         712      68     -644     
  Lines       50569    5053   -45516     
  Branches     6572     545    -6027     
=========================================
- Hits         5445     294    -5151     
+ Misses      40717    4596   -36121     
+ Partials     4407     163    -4244     
Impacted Files Coverage Δ
...ene_module/occlusion_spot/scene_occlusion_spot.cpp 0.00% <0.00%> (ø)
sensing/imu_corrector/src/imu_corrector_core.cpp
...nal_processing/test/src/lowpass_filter_1d_test.cpp
...er/src/scene_module/pull_over/pull_over_module.cpp
...ction_by_tracker/src/detection_by_tracker_core.cpp
...include/tier4_autoware_utils/system/stop_watch.hpp
...ude/freespace_planning_algorithms/astar_search.hpp
...ject_tracker/src/tracker/model/bicycle_tracker.cpp
common/osqp_interface/test/test_osqp_interface.cpp
...eespace_planning_algorithms/abstract_algorithm.hpp
... and 635 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ca59048...9bb3468. Read the comment docs.

@taikitanaka3 taikitanaka3 marked this pull request as ready for review April 1, 2022 00:06
Copy link
Contributor

@0x126 0x126 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@taikitanaka3 taikitanaka3 merged commit a8025f0 into autowarefoundation:main Apr 1, 2022
@taikitanaka3 taikitanaka3 deleted the fix-behavior-velocity-occlusion-spot-partition branch April 3, 2022 04:31
TomohitoAndo pushed a commit to TomohitoAndo/autoware.universe that referenced this pull request May 16, 2022
badai-nguyen pushed a commit to badai-nguyen/autoware.universe that referenced this pull request Jun 26, 2023
kyoichi-sugahara pushed a commit that referenced this pull request Sep 16, 2023
Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants