Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(avoidance): reset rtc status in yield status #3798

Conversation

satoshi-ota
Copy link
Contributor

@satoshi-ota satoshi-ota commented May 23, 2023

Description

The avoidance module clears RTC status when it reverts avoidance path in yield situation. But it seems not to be cleared correctly in current implementation and invalid shift line is remaining.

image

rviz_screenshot_2023_05_23-21_52_56

Tests performed

rviz_screenshot_2023_05_23-21_47_11

Effects on system behavior

Improve RTC operation.

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>
@github-actions github-actions bot added the component:planning Route planning, decision-making, and navigation. (auto-assigned) label May 23, 2023
@codecov
Copy link

codecov bot commented May 23, 2023

Codecov Report

Patch coverage: 46.15% and no project coverage change.

Comparison is base (d4ad155) 14.13% compared to head (24ddbc5) 14.14%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #3798   +/-   ##
=======================================
  Coverage   14.13%   14.14%           
=======================================
  Files        1438     1438           
  Lines      101322   101320    -2     
  Branches    27009    27010    +1     
=======================================
+ Hits        14321    14327    +6     
+ Misses      71312    71302   -10     
- Partials    15689    15691    +2     
Flag Coverage Δ *Carryforward flag
differential 13.19% <46.15%> (?)
total 14.13% <ø> (+<0.01%) ⬆️ Carriedforward from d4ad155

*This pull request uses carry forward flags. Click here to find out more.

Impacted Files Coverage Δ
...lanner/scene_module/avoidance/avoidance_module.hpp 0.00% <ø> (ø)
...on_planner/src/mission_planner/mission_planner.cpp 0.00% <ø> (ø)
...er/src/scene_module/avoidance/avoidance_module.cpp 3.94% <36.36%> (+0.29%) ⬆️
.../scene_module/goal_planner/goal_planner_module.cpp 6.02% <100.00%> (+0.14%) ⬆️

... and 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Contributor

@shmpwk shmpwk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@satoshi-ota satoshi-ota merged commit 2dc28a1 into autowarefoundation:main May 23, 2023
@satoshi-ota satoshi-ota deleted the fix/reset-rtc-status-in-yield-status branch May 23, 2023 13:17
satoshi-ota added a commit to tier4/autoware.universe that referenced this pull request May 23, 2023
…3798)

Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>
tkimura4 pushed a commit to tier4/autoware.universe that referenced this pull request May 23, 2023
…3798) (#513)

Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>
satoshi-ota added a commit to satoshi-ota/autoware.universe that referenced this pull request May 25, 2023
…3798)

Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>
satoshi-ota added a commit to satoshi-ota/autoware.universe that referenced this pull request Jun 7, 2023
…3798)

Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>
kosuke55 pushed a commit to tier4/autoware.universe that referenced this pull request Jun 19, 2023
…3798)

Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>
kosuke55 pushed a commit to tier4/autoware.universe that referenced this pull request Jun 19, 2023
…3798)

Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>
satoshi-ota added a commit to satoshi-ota/autoware.universe that referenced this pull request Jun 20, 2023
…3798)

Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>
kosuke55 added a commit to tier4/autoware.universe that referenced this pull request Jun 22, 2023
tkimura4 pushed a commit to tier4/autoware.universe that referenced this pull request Jun 22, 2023
…on#3798) (#608)

Revert "fix(avoidance): reset rtc status in yield status (autowarefoundation#3798)"

This reverts commit 65a5065.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:planning Route planning, decision-making, and navigation. (auto-assigned)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants