-
Notifications
You must be signed in to change notification settings - Fork 667
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(avoidance): reset rtc status in yield status #3798
fix(avoidance): reset rtc status in yield status #3798
Conversation
Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #3798 +/- ##
=======================================
Coverage 14.13% 14.14%
=======================================
Files 1438 1438
Lines 101322 101320 -2
Branches 27009 27010 +1
=======================================
+ Hits 14321 14327 +6
+ Misses 71312 71302 -10
- Partials 15689 15691 +2
*This pull request uses carry forward flags. Click here to find out more.
☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
…3798) Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>
…3798) Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>
…3798) Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>
…3798) Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>
…3798) Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>
…3798) Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>
…ndation#3798)" This reverts commit 65a5065.
…on#3798) (#608) Revert "fix(avoidance): reset rtc status in yield status (autowarefoundation#3798)" This reverts commit 65a5065.
Description
The avoidance module clears RTC status when it reverts avoidance path in yield situation. But it seems not to be cleared correctly in current implementation and invalid shift line is remaining.
Tests performed
Effects on system behavior
Improve RTC operation.
Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.
In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.
Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.
After all checkboxes are checked, anyone who has write access can merge the PR.